From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc: kernel@pengutronix.de, linux-can <linux-can@vger.kernel.org>
Subject: Re: [PATCH v13 05/11] can: etas_es58x: remove setting of dql.min_limit for now
Date: Fri, 19 Mar 2021 15:06:10 +0100 [thread overview]
Message-ID: <73f58c85-d07b-0ae8-6331-b0148c183aab@pengutronix.de> (raw)
In-Reply-To: <CAMZ6RqLhD8Dz0XZDrO8GZfeq+2QP3bxNKJtKFTnyVvv9B306Vw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2176 bytes --]
On 3/19/21 2:39 PM, Vincent MAILHOL wrote:
> On Fri. 19 Mar 2021 at 21:41, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> drivers/net/can/usb/etas_es58x/es58x_core.c | 5 -----
>> drivers/net/can/usb/etas_es58x/es58x_core.h | 3 ---
>> 2 files changed, 8 deletions(-)
>>
>> diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
>> index 89a4051afc82..d6a114a7e090 100644
>> --- a/drivers/net/can/usb/etas_es58x/es58x_core.c
>> +++ b/drivers/net/can/usb/etas_es58x/es58x_core.c
>> @@ -2150,11 +2150,6 @@ static int es58x_init_netdev(struct es58x_device *es58x_dev, int channel_idx)
>> netdev_dbg(netdev, "%s: Registered channel %s\n",
>> es58x_dev->udev->product, netdev->name);
>>
>> -#ifdef CONFIG_BQL
>> - netdev_get_tx_queue(netdev, 0)->dql.min_limit =
>> - es58x_dev->param->dql_limit_min;
>> -#endif
>> -
>> return ret;
>> }
>>
>> diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.h b/drivers/net/can/usb/etas_es58x/es58x_core.h
>> index 71f278e6e85c..ba6cdb9dfcf4 100644
>> --- a/drivers/net/can/usb/etas_es58x/es58x_core.h
>> +++ b/drivers/net/can/usb/etas_es58x/es58x_core.h
>> @@ -306,9 +306,6 @@ struct es58x_parameters {
>> u16 tx_urb_cmd_max_len;
>> u16 rx_urb_cmd_max_len;
>> u16 fifo_mask;
>> -#ifdef CONFIG_BQL
>> - u16 dql_limit_min;
>> -#endif
>> u8 tx_bulk_max;
>> u8 urb_cmd_header_len;
>> u8 rx_urb_max;
>
> My current idea was to add an helper function
> es58x_netdev_queue_set_dql_min_limit() as below and to remove it
> the day the patch got accepted in the network devices.
>
> Does it make sense? If you prefer to remove it for now, I will do so.
Okay, make this a 4th patch after the other 3.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-19 14:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 12:41 [PATCH v13 00/11] Introducing ETAS ES58X CAN USB interfaces Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 01/11] can: etas_es58x: add core support for " Marc Kleine-Budde
2021-03-19 14:57 ` Marc Kleine-Budde
2021-03-20 10:33 ` Vincent MAILHOL
2021-03-29 9:18 ` Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 02/11] can: etas_es58x: make core driver compile without glue code drivers Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 03/11] can: etas_es58x: es58x_rx_err_msg() fix typo Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 04/11] can: etas_es58x: es58x_rx_cmd_ret_u32() fix kernel doc Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 05/11] can: etas_es58x: remove setting of dql.min_limit for now Marc Kleine-Budde
2021-03-19 13:39 ` Vincent MAILHOL
2021-03-19 14:06 ` Marc Kleine-Budde [this message]
2021-03-19 12:41 ` [PATCH v13 06/11] can: etas_es58x: add support for ETAS ES581.4 CAN USB interface Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 07/11] can: etas_es58x: es581_4: es581_4_sizeof_rx_tx_msg(): fix kernel doc Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 08/11] can: etas_es58x: es581_4: remove setting of dql.min_limit for now Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 09/11] can: etas_es58x: es58x_fd: add support for the ETAS ES58X_FD CAN USB interfaces Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 10/11] can: etas_es58x: es58x_fd: es58x_fd_sizeof_rx_tx_msg(): fix kernel doc Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 11/11] can: etas_es58x: es58x_fd: remove setting of dql.min_limit for now Marc Kleine-Budde
2021-03-19 13:32 ` [PATCH v13 00/11] Introducing ETAS ES58X CAN USB interfaces Vincent MAILHOL
2021-03-19 13:34 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73f58c85-d07b-0ae8-6331-b0148c183aab@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).