linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can <linux-can@vger.kernel.org>, kernel@pengutronix.de
Subject: Re: [PATCH v13 00/11] Introducing ETAS ES58X CAN USB interfaces
Date: Fri, 19 Mar 2021 22:32:46 +0900	[thread overview]
Message-ID: <CAMZ6RqJB_2c1MX8EaO+ZH+qgSjQDbq6PrsNJCJM=kw=hqxFMSw@mail.gmail.com> (raw)
In-Reply-To: <20210319124141.247844-1-mkl@pengutronix.de>

On Fri 19 mars 2021 at 21:41, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> Hello,
>
> this my attempt to split the driver into 3 patches, so that it can be
> send via mailing lists:
> - core support
> - es581_4
> - es58x_fd
>
> For now I've removed the setting of dql.min_limit, that can be added
> back in a later patch, once discussed with upstream netdev. While
> working on the code, I've added some typo and kernel doc fixes.
>
> I plan to squash the patches, I've kept them separate for better
> illustration.

Thanks a lot for your support! You could have asked me to split the patches :)

I was also myself working on a new version:
  - addressing the comments from Jimmy
  - following my exchange with Oliver yesterday, I realised that
    I totally misunderstood the meaning of CAN_CTRLMODE_LOOPBACK,
    I will remove it.

If fine with you, I can directly squash your suggestions while
preparing my v14 and just keep the 3 patches split as suggested.


Yours sincerely,
Vincent

  parent reply	other threads:[~2021-03-19 13:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 12:41 [PATCH v13 00/11] Introducing ETAS ES58X CAN USB interfaces Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 01/11] can: etas_es58x: add core support for " Marc Kleine-Budde
2021-03-19 14:57   ` Marc Kleine-Budde
2021-03-20 10:33     ` Vincent MAILHOL
2021-03-29  9:18       ` Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 02/11] can: etas_es58x: make core driver compile without glue code drivers Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 03/11] can: etas_es58x: es58x_rx_err_msg() fix typo Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 04/11] can: etas_es58x: es58x_rx_cmd_ret_u32() fix kernel doc Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 05/11] can: etas_es58x: remove setting of dql.min_limit for now Marc Kleine-Budde
2021-03-19 13:39   ` Vincent MAILHOL
2021-03-19 14:06     ` Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 06/11] can: etas_es58x: add support for ETAS ES581.4 CAN USB interface Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 07/11] can: etas_es58x: es581_4: es581_4_sizeof_rx_tx_msg(): fix kernel doc Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 08/11] can: etas_es58x: es581_4: remove setting of dql.min_limit for now Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 09/11] can: etas_es58x: es58x_fd: add support for the ETAS ES58X_FD CAN USB interfaces Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 10/11] can: etas_es58x: es58x_fd: es58x_fd_sizeof_rx_tx_msg(): fix kernel doc Marc Kleine-Budde
2021-03-19 12:41 ` [PATCH v13 11/11] can: etas_es58x: es58x_fd: remove setting of dql.min_limit for now Marc Kleine-Budde
2021-03-19 13:32 ` Vincent MAILHOL [this message]
2021-03-19 13:34   ` [PATCH v13 00/11] Introducing ETAS ES58X CAN USB interfaces Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMZ6RqJB_2c1MX8EaO+ZH+qgSjQDbq6PrsNJCJM=kw=hqxFMSw@mail.gmail.com' \
    --to=mailhol.vincent@wanadoo.fr \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).