From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED49C4332F for ; Sun, 13 Nov 2022 14:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233069AbiKMOSM (ORCPT ); Sun, 13 Nov 2022 09:18:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232799AbiKMOSL (ORCPT ); Sun, 13 Nov 2022 09:18:11 -0500 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41CC2BCBD for ; Sun, 13 Nov 2022 06:18:11 -0800 (PST) Received: by mail-pf1-f176.google.com with SMTP id b29so8794353pfp.13 for ; Sun, 13 Nov 2022 06:18:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hYZYPEIXWJ+wDwe6DAjChgcVc0aa6AX8yXUrWNfM5OY=; b=OLTPzG7dC+xiqJEduHsg1cx5dJAOwAeeL5jTHiVaDPe+20fyGDkn5ZDK3e7oomi60f u4Q6Qx8TqMOV6WWr54Sp/QrrwBNPFDstQh/5Zjbvl7vu3jmm0caYERTuCMmvc0y8bday mbqfveeuVQMfOK5Rq6m/MIEMowzXgJXp8mHBYJz+Mab25PguVJCcATG1Vsx3Wq9ps9TJ oko2sMWNmDVz4lW7InTFMIlEs+mAIkXMlA6aQdQF/FrEwmu2BQJGWhzGCj3sahR486bg 6Z8+dBkwMi06YdR/l2rylbH3CX2mi9VN+XvMdp78K+4fuFiOBQnfhp0W5OPm6zTCA2+t 7VEA== X-Gm-Message-State: ANoB5pnHfION6i6lu95oJxkIc/otoxFlYI5CN+A8GJCucDCanWZUYv5w w9JWC+Y4G9jDmU3rSXDYsH8D04BhV0VnMsMdMYh2tdEIFvA= X-Google-Smtp-Source: AA0mqf7BdzElTIsn2c1Vq2+FToyQTfQEGImbWvaujAxyFiPMzHQiye+W0fV4OehYt7beDq5guPUk2pvR/ApENNRrk7w= X-Received: by 2002:a63:4d43:0:b0:41d:c892:2e9 with SMTP id n3-20020a634d43000000b0041dc89202e9mr8532483pgl.457.1668349090716; Sun, 13 Nov 2022 06:18:10 -0800 (PST) MIME-Version: 1.0 References: <20221113085321.87910-1-mailhol.vincent@wanadoo.fr> <20221113085321.87910-3-mailhol.vincent@wanadoo.fr> <20221113130325.5tagqsi4t4523uob@pengutronix.de> <20221113133406.bmwavedn66wng3cu@pengutronix.de> <20221113135653.klh4g7ng4pd4olon@pengutronix.de> In-Reply-To: <20221113135653.klh4g7ng4pd4olon@pengutronix.de> From: Vincent MAILHOL Date: Sun, 13 Nov 2022 23:17:59 +0900 Message-ID: Subject: Re: [PATCH can-utils-dev 2/5] lib: add pr_debug() macro To: Marc Kleine-Budde Cc: linux-can@vger.kernel.org, Oliver Hartkopp Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Sun. 13 Nov. 2022 at 23:04, Marc Kleine-Budde wrote: > On 13.11.2022 22:47:14, Vincent MAILHOL wrote: > > On Sun. 13 nov. 2022 at 22:39, Marc Kleine-Budde wrote: > > > On 13.11.2022 22:19:23, Vincent MAILHOL wrote: > > > > On Sun. 13 Nov. 2022 at 22:12, Marc Kleine-Budde wrote: > > > > > On 13.11.2022 17:53:18, Vincent Mailhol wrote: > > > > > > > > > > > diff --git a/mcp251xfd/mcp251xfd-dev-coredump.c b/mcp251xfd/mcp251xfd-dev-coredump.c > > > > > > index 5874d24..422900f 100644 > > > > > > --- a/mcp251xfd/mcp251xfd-dev-coredump.c > > > > > > +++ b/mcp251xfd/mcp251xfd-dev-coredump.c > > > > > > @@ -17,18 +17,10 @@ > > > > > > > > > > > > #include > > > > > > > > > > > > +#include "../lib.h" > > > > > > > > > > Does #include work? > > > > > > > > Unfortunately, no: > > > > > > Using the plain makefile without autotools and cmake? > > > > It works with autotools. Actually, I am now confused, I thought that > > Makefile would be generated by ./autogen.sh and ./configure. To be > > honest, after seeing the Makefile, I did not pay attention to the rest > > and did not realize that this was also a autotools project. > > Shouldn't the Makefile be removed? It is odd to have both. > > I don't see any benefits in the handcrafted Makefile, Oliver seems to > like it :) Well, I think it should be either, not both. And can-utils being popular and included in many distro such as Debian, I think it is better to keep the autotools. But I am not going to change it myself. This also means that it will be #include "../lib.h" and not #include (unless the handcrafted Makefile gets a header include directive). Unless you have a last comment, I will send the v2 in a couple of minutes. Yours sincerely, Vincent Mailhol