From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-can-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id AF483C4332F
	for <linux-can@archiver.kernel.org>; Sat, 26 Nov 2022 10:42:21 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229493AbiKZKmT (ORCPT <rfc822;linux-can@archiver.kernel.org>);
        Sat, 26 Nov 2022 05:42:19 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58688 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229502AbiKZKmT (ORCPT
        <rfc822;linux-can@vger.kernel.org>); Sat, 26 Nov 2022 05:42:19 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 592B128E31;
        Sat, 26 Nov 2022 02:42:18 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 11608B8119B;
        Sat, 26 Nov 2022 10:42:17 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CF7BC433D6;
        Sat, 26 Nov 2022 10:42:15 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1669459335;
        bh=slQWqXMaJzUSxWeIEcuX/WIiJyoDdLAFAoGyCECDXz0=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=DDCqhtvnVFouEff+o76t1wMOWcYUiy8xgD++2mTlGz1k3s3bX3c5TjOku5eN5raYL
         3LQfZs6ErRncUnT635UFx/0buAof0NEI6DzqIA6ybqLYgvIxjFs/Uh8VwY2KwXe+rG
         RQFPw9jNnTw0g6CheDAYqO32WjgA09u+PhRiDG2M=
Date:   Sat, 26 Nov 2022 08:04:11 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     linux-can@vger.kernel.org, Peter Fink <pfink@christ-es.de>,
        stable@vger.kernel.org, Ryan Edwards <ryan.edwards@gmail.com>
Subject: Re: [PATCH] can: gs_usb: fix size parameter to usb_free_coherent()
 calls
Message-ID: <Y4G6a4hlJFgH+iAy@kroah.com>
References: <20221125201727.1558965-1-mkl@pengutronix.de>
 <20221125203217.cuv63t4ijxwmqun7@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221125203217.cuv63t4ijxwmqun7@pengutronix.de>
Precedence: bulk
List-ID: <linux-can.vger.kernel.org>
X-Mailing-List: linux-can@vger.kernel.org

On Fri, Nov 25, 2022 at 09:32:17PM +0100, Marc Kleine-Budde wrote:
> Hello Greg,
> 
> with v5.18-rc1 in commit
> 
> | c359931d2545 ("can: gs_usb: use union and FLEX_ARRAY for data in struct gs_host_frame")
> 
> a bug in the gs_usb driver in the usage of usb_free_coherent() was
> introduced. With v6.1-rc1
> 
> | 62f102c0d156 ("can: gs_usb: remove dma allocations")
> 
> the DMA allocation was removed altogether from the driver, fixing the
> bug unintentionally.
> 
> We can either cherry-pick 62f102c0d156 ("can: gs_usb: remove dma
> allocations") on v6.0, v5.19, and v5.18 or apply this patch, which fixes
> the usage of usb_free_coherent() only.

We should always take what is in Linus's tree, that's the best solution.
Does the change backport cleanly?

And 5.19 and 5.18 are long end-of-life, no need to worry about them.
Only 6.0 matters right now.

thanks,

greg k-h