From: Matt Kline <matt@bitbashing.io>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Subject: Re: [PATCH v3 2/3] can: m_can: Batch FIFO reads during CAN receive
Date: Mon, 27 Sep 2021 01:25:06 -0700 [thread overview]
Message-ID: <YVF/4iJDwLXTJOCJ@kline-desktop> (raw)
In-Reply-To: <aa0d3bed-dd0d-ae13-d0ef-6fb130db5aa5@ti.com>
Hey Aswath,
Definitely looks like a silly mistake on my part, thanks for sending fixes!
Apologies for the slow response; I was out for the past week or so.
Best,
Matt
On Thu, Sep 16, 2021 at 05:34:45PM +0530, Aswath Govindraju wrote:
> Hi Matt, Marc,
>
> While reading multiple register fields and calling iomap_read_fifo() in
> m_can_platform.c is causing an issue.
>
> In iomap_read_fifo(), ioread32_rep() is being used for reading.
> ioread32_rep reads() from the same source address for val_count times.
> This is not the intended behavior here. The source address also needs to
> be shifted along with the destination address.
>
> Is a fix required in iomap_read_fifo() ?
>
> Thanks,
> Aswath
next prev parent reply other threads:[~2021-09-27 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 5:08 [PATCH v3 0/3] can: m_can: Merge FIFO ops to increase throughput Matt Kline
2021-08-17 5:08 ` [PATCH v3 1/3] can: m_can: Disable IRQs on FIFO bus errors Matt Kline
2021-08-19 11:30 ` Marc Kleine-Budde
2021-08-17 5:08 ` [PATCH v3 2/3] can: m_can: Batch FIFO reads during CAN receive Matt Kline
2021-08-19 11:45 ` Marc Kleine-Budde
2021-09-16 12:04 ` Aswath Govindraju
2021-09-27 8:25 ` Matt Kline [this message]
2021-08-17 5:08 ` [PATCH v3 3/3] can: m_can: Batch FIFO writes during CAN transmit Matt Kline
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVF/4iJDwLXTJOCJ@kline-desktop \
--to=matt@bitbashing.io \
--cc=a-govindraju@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).