From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FF9C433EF for ; Mon, 27 Sep 2021 08:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 719FB60F94 for ; Mon, 27 Sep 2021 08:25:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233385AbhI0I0q (ORCPT ); Mon, 27 Sep 2021 04:26:46 -0400 Received: from h4.fbrelay.privateemail.com ([131.153.2.45]:32809 "EHLO h4.fbrelay.privateemail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233337AbhI0I0q (ORCPT ); Mon, 27 Sep 2021 04:26:46 -0400 Received: from MTA-05-3.privateemail.com (mta-05-1.privateemail.com [198.54.122.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by h3.fbrelay.privateemail.com (Postfix) with ESMTPS id 4411480C30 for ; Mon, 27 Sep 2021 04:25:08 -0400 (EDT) Received: from mta-05.privateemail.com (localhost [127.0.0.1]) by mta-05.privateemail.com (Postfix) with ESMTP id 2E74918000B8; Mon, 27 Sep 2021 04:25:07 -0400 (EDT) Received: from localhost (unknown [10.20.151.233]) by mta-05.privateemail.com (Postfix) with ESMTPA id F195918000A1; Mon, 27 Sep 2021 04:25:06 -0400 (EDT) Date: Mon, 27 Sep 2021 01:25:06 -0700 From: Matt Kline To: Aswath Govindraju Cc: Marc Kleine-Budde , linux-can@vger.kernel.org Subject: Re: [PATCH v3 2/3] can: m_can: Batch FIFO reads during CAN receive Message-ID: References: <20210817050853.14875-1-matt@bitbashing.io> <20210817050853.14875-3-matt@bitbashing.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hey Aswath, Definitely looks like a silly mistake on my part, thanks for sending fixes! Apologies for the slow response; I was out for the past week or so. Best, Matt On Thu, Sep 16, 2021 at 05:34:45PM +0530, Aswath Govindraju wrote: > Hi Matt, Marc, > > While reading multiple register fields and calling iomap_read_fifo() in > m_can_platform.c is causing an issue. > > In iomap_read_fifo(), ioread32_rep() is being used for reading. > ioread32_rep reads() from the same source address for val_count times. > This is not the intended behavior here. The source address also needs to > be shifted along with the destination address. > > Is a fix required in iomap_read_fifo() ? > > Thanks, > Aswath