From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Stefan Metzmacher'" <metze@samba.org>
Cc: <linux-cifsd-devel@lists.sourceforge.net>, <linux-cifs@vger.kernel.org>
Subject: RE: [Linux-cifsd-devel] [PATCH] ksmbd-tools: add support for SMB3 multichannel
Date: Fri, 16 Jul 2021 16:56:33 +0900 [thread overview]
Message-ID: <003001d77a18$17fadfc0$47f09f40$@samsung.com> (raw)
In-Reply-To: <d6d4e15b-95aa-38d1-40f7-14f99fe24260@samba.org>
> Hi Namjae,
Hi Metze,
>
> > Add support for SMB3 multichannel.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > ---
> > Documentation/configuration.txt | 3 +++
> > include/linux/ksmbd_server.h | 1 +
> > lib/config_parser.c | 9 +++++++++
> > 3 files changed, 13 insertions(+)
> >
> > diff --git a/Documentation/configuration.txt
> > b/Documentation/configuration.txt index f38aceb..1289cbf 100644
> > --- a/Documentation/configuration.txt
> > +++ b/Documentation/configuration.txt
> > @@ -109,6 +109,9 @@ Define ksmbd configuration parameters list.
> > host where ksmbd runs. the format is "cifs/<FQDN>". if this
> > option is not given, ksmbd sets "cifs" to the service name and
> > try to get the host FQDN using getaddrinfo(3).
> > + - server multi channel support
> > + This boolean parameter controls whether ksmbd will support
> > + SMB3 multi-channel.
>
> Did you actually implemented all replay related features?
> - Create replay
> - Lock replay
> - Write/IOCtl/SetInfo replay
> - Lease/OplockBreak replay
Not yet.
>
> Otherwise you should mark this as experimental, as it's likely to end with potential data coruption.
> That's why Samba had this flagged as experimental up to now, Samba 4.15 will be the first release with
> all required features in order to enable multi channel.
Okay. I will mark it as experimental till relay features are implemented.
Thanks for your review!
>
> metze
prev parent reply other threads:[~2021-07-16 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210614085106epcas1p4143f68f380c480f5f8a504370b10a969@epcas1p4.samsung.com>
[not found] ` <20210614084135.19753-1-namjae.jeon@samsung.com>
2021-07-16 7:50 ` [Linux-cifsd-devel] [PATCH] ksmbd-tools: add support for SMB3 multichannel Stefan Metzmacher
2021-07-16 7:56 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003001d77a18$17fadfc0$47f09f40$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-cifsd-devel@lists.sourceforge.net \
--cc=metze@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).