Re: [Linux-cifsd-devel] [PATCH] ksmbd-tools: add support for SMB3 multichannel

Re: [Linux-cifsd-devel] [PATCH] ksmbd-tools: add support for SMB3 multichannel

[Stefan Metzmacher]

[-- Attachment #1.1: Type: text/plain, Size: 1307 bytes --]


Hi Namjae,

> Add support for SMB3 multichannel.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> ---
>  Documentation/configuration.txt | 3 +++
>  include/linux/ksmbd_server.h    | 1 +
>  lib/config_parser.c             | 9 +++++++++
>  3 files changed, 13 insertions(+)
> 
> diff --git a/Documentation/configuration.txt b/Documentation/configuration.txt
> index f38aceb..1289cbf 100644
> --- a/Documentation/configuration.txt
> +++ b/Documentation/configuration.txt
> @@ -109,6 +109,9 @@ Define ksmbd configuration parameters list.
>  		host where ksmbd runs. the format is "cifs/<FQDN>". if this
>  		option is not given, ksmbd sets "cifs" to the service name and
>  		try to get the host FQDN using getaddrinfo(3).
> +	- server multi channel support
> +		This boolean parameter controls whether ksmbd will support
> +		SMB3 multi-channel.

Did you actually implemented all replay related features?
- Create replay
- Lock replay
- Write/IOCtl/SetInfo replay
- Lease/OplockBreak replay

Otherwise you should mark this as experimental,
as it's likely to end with potential data coruption.
That's why Samba had this flagged as experimental up to now,
Samba 4.15 will be the first release with all required features
in order to enable multi channel.

metze


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

RE: [Linux-cifsd-devel] [PATCH] ksmbd-tools: add support for SMB3 multichannel

[Namjae Jeon]

> Hi Namjae,
Hi Metze,

> 
> > Add support for SMB3 multichannel.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > ---
> >  Documentation/configuration.txt | 3 +++
> >  include/linux/ksmbd_server.h    | 1 +
> >  lib/config_parser.c             | 9 +++++++++
> >  3 files changed, 13 insertions(+)
> >
> > diff --git a/Documentation/configuration.txt
> > b/Documentation/configuration.txt index f38aceb..1289cbf 100644
> > --- a/Documentation/configuration.txt
> > +++ b/Documentation/configuration.txt
> > @@ -109,6 +109,9 @@ Define ksmbd configuration parameters list.
> >  		host where ksmbd runs. the format is "cifs/<FQDN>". if this
> >  		option is not given, ksmbd sets "cifs" to the service name and
> >  		try to get the host FQDN using getaddrinfo(3).
> > +	- server multi channel support
> > +		This boolean parameter controls whether ksmbd will support
> > +		SMB3 multi-channel.
> 
> Did you actually implemented all replay related features?
> - Create replay
> - Lock replay
> - Write/IOCtl/SetInfo replay
> - Lease/OplockBreak replay
Not yet.
> 
> Otherwise you should mark this as experimental, as it's likely to end with potential data coruption.
> That's why Samba had this flagged as experimental up to now, Samba 4.15 will be the first release with
> all required features in order to enable multi channel.
Okay. I will mark it as experimental till relay features are implemented.

Thanks for your review!
> 
> metze