* [PATCH v2] ksmbd: reduce smb direct max read/write size
@ 2022-02-01 9:15 Namjae Jeon
2022-02-01 13:17 ` Tom Talpey
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2022-02-01 9:15 UTC (permalink / raw)
To: linux-cifs; +Cc: Namjae Jeon, Tom Talpey
ksmbd does not support more than one Buffer Descriptor V1 element in
an smbdirect protocol request. Reducing the maximum read/write size to
about 512KB allows interoperability with Windows over a wider variety
of RDMA NICs, as an interim workaround.
Cc: Tom Talpey <tom@talpey.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
---
v2:
- update patch description (Written by Tom Talpey).
fs/ksmbd/transport_rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
index 3c1ec1ac0b27..ba5a22bc2e6d 100644
--- a/fs/ksmbd/transport_rdma.c
+++ b/fs/ksmbd/transport_rdma.c
@@ -80,7 +80,7 @@ static int smb_direct_max_fragmented_recv_size = 1024 * 1024;
/* The maximum single-message size which can be received */
static int smb_direct_max_receive_size = 8192;
-static int smb_direct_max_read_write_size = 1048512;
+static int smb_direct_max_read_write_size = 524224;
static int smb_direct_max_outstanding_rw_ops = 8;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ksmbd: reduce smb direct max read/write size
2022-02-01 9:15 [PATCH v2] ksmbd: reduce smb direct max read/write size Namjae Jeon
@ 2022-02-01 13:17 ` Tom Talpey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Talpey @ 2022-02-01 13:17 UTC (permalink / raw)
To: Namjae Jeon; +Cc: linux-cifs
Thanks for walking me through the explanation.
Reviewed-By: Tom Talpey <tom@talpey.com>
Feb 1, 2022 4:16:59 AM Namjae Jeon <linkinjeon@kernel.org>:
> ksmbd does not support more than one Buffer Descriptor V1 element in
> an smbdirect protocol request. Reducing the maximum read/write size to
> about 512KB allows interoperability with Windows over a wider variety
> of RDMA NICs, as an interim workaround.
>
> Cc: Tom Talpey <tom@talpey.com>
> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
> ---
> v2:
> - update patch description (Written by Tom Talpey).
>
> fs/ksmbd/transport_rdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
> index 3c1ec1ac0b27..ba5a22bc2e6d 100644
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -80,7 +80,7 @@ static int smb_direct_max_fragmented_recv_size = 1024 * 1024;
> /* The maximum single-message size which can be received */
> static int smb_direct_max_receive_size = 8192;
>
> -static int smb_direct_max_read_write_size = 1048512;
> +static int smb_direct_max_read_write_size = 524224;
>
> static int smb_direct_max_outstanding_rw_ops = 8;
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-01 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01 9:15 [PATCH v2] ksmbd: reduce smb direct max read/write size Namjae Jeon
2022-02-01 13:17 ` Tom Talpey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).