From: Joe Perches <joe@perches.com>
To: "Aurélien Aptel" <aaptel@suse.com>, "Steve French" <sfrench@samba.org>
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [trivial PATCH] cifs: Use #define in cifs_dbg
Date: Fri, 21 Feb 2020 05:55:56 -0800 [thread overview]
Message-ID: <0f2c5adb37454dacbd57d65ba8743bb6092876ff.camel@perches.com> (raw)
In-Reply-To: <87eeuo5a2y.fsf@suse.com>
On Fri, 2020-02-21 at 14:44 +0100, Aurélien Aptel wrote:
> Joe Perches <joe@perches.com> writes:
> > + cifs_dbg(VFS, "bogus file nlink value %u\n",
> > + fattr->cf_nlink);
>
> Good catch :)
> I realize that 1 is VFS but this should probably be FYI.
change it as you please.
fyi:
Perhaps commit f2f176b41 ("CIFS: add ONCE flag for cifs_dbg type")
may have increased object size quite a bit as it now tests
an external variable.
next prev parent reply other threads:[~2020-02-21 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 13:20 [trivial PATCH] cifs: Use #define in cifs_dbg Joe Perches
2020-02-21 13:44 ` Aurélien Aptel
2020-02-21 13:55 ` Joe Perches [this message]
2020-02-24 5:58 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f2c5adb37454dacbd57d65ba8743bb6092876ff.camel@perches.com \
--to=joe@perches.com \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).