From: Julian Sikorski <belegdol@gmail.com>
To: Stefan Metzmacher <metze@samba.org>,
Steve French <smfrench@gmail.com>, Jeremy Allison <jra@samba.org>
Cc: Enzo Matsumiya <ematsumiya@suse.de>, Paulo Alcantara <pc@cjr.nz>,
ronnie sahlberg <ronniesahlberg@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: kernel-5.18.8 breaks cifs mounts
Date: Mon, 4 Jul 2022 18:29:06 +0200 [thread overview]
Message-ID: <11b3feeb-7ddb-1297-5080-7c2fc986475a@gmail.com> (raw)
In-Reply-To: <fccdb4af-697e-b7fc-6421-f16e9b35bb8e@samba.org>
Am 03.07.22 um 19:51 schrieb Stefan Metzmacher:
> Am 03.07.22 um 07:01 schrieb Steve French:
>> I lean toward thinking that this is a Samba bug (although I don't see
>> it on my local system - it works to samba for me, although I was
>> trying against a slightly different version, Samba 4.15.5-Ubuntu).
>>
>> Looking at the traces in more detail they look the same (failing vs.
>> working) other than the order of the negotiate context, which fails
>> with POSIX as the 3rd context, and netname as the 4th, but works with
>> the order reversed (although same contexts, and same overall length)
>> ie with POSIX context as the fourth one and netname context as the
>> third one.
>>
>> The failing server code in Samba is in
>> smbd_smb2_request_process_negprot but I don't see changes to it
>> recently around this error.
>>
>> Does this fail to anyone else's Samba version?
>>
>> This is probably a Samba server bug but ... seems odd since it doesn't
>> fail to Samba for me.
>>
>> Jeremy/Metze,
>> Does this look familiar?
>
> Maybe this one:
>
> https://git.samba.org/?p=samba.git;a=commitdiff;h=147dd9d58a429695a3b6c6e45c8b0eaafc67908a
>
>
> that went only into 4.15 and higher.
>
> metze
Nice catch, I can confirm that adding this patch to debian samba
2:4.13.13+dfsg-1~deb11u3 package makes the mounts work again. How do we
get this patch into debian?
Best regards,
Julian
next prev parent reply other threads:[~2022-07-04 16:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 16:47 kernel-5.18.8 breaks cifs mounts Julian Sikorski
2022-06-30 17:02 ` ronnie sahlberg
2022-06-30 17:41 ` Julian Sikorski
2022-06-30 17:55 ` Paulo Alcantara
2022-06-30 18:11 ` Julian Sikorski
2022-06-30 18:28 ` Paulo Alcantara
2022-06-30 19:12 ` Julian Sikorski
2022-06-30 20:32 ` Enzo Matsumiya
2022-07-04 8:12 ` Shyam Prasad N
2022-07-04 16:30 ` Julian Sikorski
[not found] ` <CAH2r5mtVwZggJ9Fi0zsK5hCci4uxee-kOSC3brb56xpb0_xn7w@mail.gmail.com>
[not found] ` <56afe80b-bf6a-2508-063a-7b091cdbbe0f@gmail.com>
[not found] ` <CAH2r5mvoyhZGjf_wgvjgmkCz=+2iDxCSpbyJ79NMtpE1Ecjdnw@mail.gmail.com>
[not found] ` <fccdb4af-697e-b7fc-6421-f16e9b35bb8e@samba.org>
2022-07-04 16:29 ` Julian Sikorski [this message]
2022-07-05 5:28 ` Shyam Prasad N
2022-07-05 10:55 ` Julian Sikorski
2022-07-06 11:18 ` Julian Sikorski
2022-07-12 4:36 ` Steve French
2022-07-13 21:25 ` Georg Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11b3feeb-7ddb-1297-5080-7c2fc986475a@gmail.com \
--to=belegdol@gmail.com \
--cc=ematsumiya@suse.de \
--cc=jra@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=metze@samba.org \
--cc=pc@cjr.nz \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).