From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ilya Dryomov <idryomov@gmail.com>,
Dave Wysochanski <dwysocha@redhat.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
Dominique Martinet <asmadeus@codewreck.org>,
linux-mm@kvack.org, Rohith Surabattula <rohiths.msft@gmail.com>,
v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org,
linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
Matthew Wilcox <willy@infradead.org>,
Steve French <sfrench@samba.org>,
linux-fsdevel@vger.kernel.org, dhowells@redhat.com,
Matthew Wilcox <willy@infradead.org>,
Jeff Layton <jlayton@kernel.org>,
linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org,
linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net,
linux-erofs@lists.ozlabs.org, linux-cachefs@redhat.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache
Date: Wed, 23 Nov 2022 22:48:25 +0000 [thread overview]
Message-ID: <166924370539.1772793.13730698360771821317.stgit@warthog.procyon.org.uk> (raw)
Hi Linus,
How about this then?
I've split the folio_has_private()/filemap_release_folio() call pair
merging into its own patch, separate from the actual bugfix and pulled out
the folio_needs_release() function into mm/internal.h and made
filemap_release_folio() use it. I've also got rid of the bit clearances
from the network filesystem evict_inode functions as they doesn't seem to
be necessary.
I've also added an additional experimental patch to see if the pair in
shrink_folio_list() can be reduced cleanly to just the release call. This
involves making filemap_release_folio() have a three-state return.
David
Changes:
========
ver #4)
- Split has_private/release call pairs into own patch.
- Moved folio_needs_release() to mm/internal.h and removed open-coded
version from filemap_release_folio().
- Don't need to clear AS_RELEASE_ALWAYS in ->evict_inode().
- Added experimental patch to reduce shrink_folio_list().
ver #3)
- Fixed mapping_clear_release_always() to use clear_bit() not set_bit().
- Moved a '&&' to the correct line.
ver #2)
- Rewrote entirely according to Willy's suggestion[1].
Link: https://lore.kernel.org/r/Yk9V/03wgdYi65Lb@casper.infradead.org/ [1]
Link: https://lore.kernel.org/r/164928630577.457102.8519251179327601178.stgit@warthog.procyon.org.uk/ # v1
Link: https://lore.kernel.org/r/166844174069.1124521.10890506360974169994.stgit@warthog.procyon.org.uk/ # v2
Link: https://lore.kernel.org/r/166869495238.3720468.4878151409085146764.stgit@warthog.procyon.org.uk/ # v3
Link: https://lore.kernel.org/r/1459152.1669208550@warthog.procyon.org.uk/ # v3 also
---
David Howells (3):
mm: Merge folio_has_private()/filemap_release_folio() call pairs
mm, netfs, fscache: Stop read optimisation when folio removed from pagecache
mm: Make filemap_release_folio() better inform shrink_folio_list()
fs/9p/cache.c | 2 ++
fs/afs/internal.h | 2 ++
fs/cachefiles/namei.c | 2 ++
fs/ceph/cache.c | 2 ++
fs/cifs/fscache.c | 2 ++
fs/splice.c | 3 +--
include/linux/pagemap.h | 23 ++++++++++++++++++++++-
mm/filemap.c | 20 +++++++++++++++-----
mm/huge_memory.c | 3 +--
mm/internal.h | 11 +++++++++++
mm/khugepaged.c | 3 +--
mm/memory-failure.c | 3 +--
mm/migrate.c | 3 +--
mm/truncate.c | 6 ++----
mm/vmscan.c | 34 +++++++++++++++++-----------------
15 files changed, 82 insertions(+), 37 deletions(-)
next reply other threads:[~2022-11-23 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 22:48 David Howells [this message]
2022-11-23 22:48 ` [RFC PATCH v4 1/3] mm: Merge folio_has_private()/filemap_release_folio() call pairs David Howells
2022-11-23 22:48 ` [RFC PATCH v4 2/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache David Howells
2022-11-23 22:48 ` [RFC PATCH v4 3/3] mm: Make filemap_release_folio() better inform shrink_folio_list() David Howells
2022-11-23 22:52 ` [PATCH v4 0/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache Linus Torvalds
2022-11-23 23:12 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166924370539.1772793.13730698360771821317.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dwysocha@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=sfrench@samba.org \
--cc=torvalds@linux-foundation.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).