From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1915C433FF for ; Thu, 1 Aug 2019 08:20:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B75E320665 for ; Thu, 1 Aug 2019 08:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731043AbfHAIUM (ORCPT ); Thu, 1 Aug 2019 04:20:12 -0400 Received: from verein.lst.de ([213.95.11.211]:41407 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728146AbfHAIUM (ORCPT ); Thu, 1 Aug 2019 04:20:12 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 21DE768AFE; Thu, 1 Aug 2019 10:20:05 +0200 (CEST) Date: Thu, 1 Aug 2019 10:20:04 +0200 From: Christoph Hellwig To: Jerome Glisse Cc: Christoph Hellwig , Christoph Hellwig , john.hubbard@gmail.com, Andrew Morton , Alexander Viro , Anna Schumaker , "David S . Miller" , Dominique Martinet , Eric Van Hensbergen , Jason Gunthorpe , Jason Wang , Jens Axboe , Latchesar Ionkov , "Michael S . Tsirkin" , Miklos Szeredi , Trond Myklebust , Matthew Wilcox , linux-mm@kvack.org, LKML , ceph-devel@vger.kernel.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, samba-technical@lists.samba.org, v9fs-developer@lists.sourceforge.net, virtualization@lists.linux-foundation.org, John Hubbard , Minwoo Im Subject: Re: [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool Message-ID: <20190801082004.GA17348@lst.de> References: <20190724042518.14363-1-jhubbard@nvidia.com> <20190724042518.14363-4-jhubbard@nvidia.com> <20190724053053.GA18330@infradead.org> <20190729205721.GB3760@redhat.com> <20190730102557.GA1700@lst.de> <20190730155702.GB10366@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190730155702.GB10366@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Tue, Jul 30, 2019 at 11:57:02AM -0400, Jerome Glisse wrote: > Other user can also add page that are not coming from GUP but need to > have a reference see __blkdev_direct_IO() Except for the zero page case I mentioned in my last mail explicitly, and the KVEC/PIPE type iov vecs from the original mail what other pages do you see to get added?