Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
* seek sanity check failures
@ 2019-09-15  2:08 Murphy Zhou
  2019-09-15  4:11 ` Steve French
  0 siblings, 1 reply; 3+ messages in thread
From: Murphy Zhou @ 2019-09-15  2:08 UTC (permalink / raw)
  To: linux-cifs

Hi,

On latest Linus tree, several seek tests fails:

generic/285 generic/490 generic/539    fails on v3.11 v3.02 v3.0
generic/285 generic/490                fails on v2.0 v2.1
generic/285 generic/448 generic/490    fails on v1.0


Are they expected or being worked on?

Thanks!


FSTYP         -- cifs
PLATFORM      -- Linux/x86_64 hp-dl380pg8-14 5.3.0-rc8+ #1 SMP Thu Sep 12 07:31:21 EDT 2019
MKFS_OPTIONS  -- //hp-dl380pg8-14.rhts.eng.pek2.redhat.com/scratch
MOUNT_OPTIONS -- -o vers=3.11,mfsymlinks -o username=root,password=redhat -o context=system_u:object_r:nfs_t:s0 //hp-dl380pg8-14.rhts.eng.pek2.redhat.com/scratch /mnt/testarea/scratch

generic/285	[failed, exit status 1]- output mismatch (see /var/lib/xfstests/results//generic/285.out.bad)
    --- tests/generic/285.out	2019-09-12 08:04:14.120990746 -0400
    +++ /var/lib/xfstests/results//generic/285.out.bad	2019-09-12 08:36:49.151230335 -0400
    @@ -1 +1,3 @@
     QA output created by 285
    +seek sanity check failed!
    +(see /var/lib/xfstests/results//generic/285.full for details)
    ...

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: seek sanity check failures
  2019-09-15  2:08 seek sanity check failures Murphy Zhou
@ 2019-09-15  4:11 ` Steve French
  2019-09-16  8:47   ` Murphy Zhou
  0 siblings, 1 reply; 3+ messages in thread
From: Steve French @ 2019-09-15  4:11 UTC (permalink / raw)
  To: Murphy Zhou; +Cc: CIFS

Test 285 and 490 broke when xfstests were updated on the buildbot, and
are temporarily deleted (commented out in the buildbot script).  We
had a difficult choice - update xfstests and add 10 new tests but
disable 3 tests which broke with updated tests, or not add the 10
tests by keeping running last year's old xfstest test suite.

Ronnie and I did some investigation of why 285 and 490 failed and any
additional data would help - since we both got distracted with other
features and fixes

On Sat, Sep 14, 2019 at 10:14 PM Murphy Zhou <jencce.kernel@gmail.com> wrote:
>
> Hi,
>
> On latest Linus tree, several seek tests fails:
>
> generic/285 generic/490 generic/539    fails on v3.11 v3.02 v3.0
> generic/285 generic/490                fails on v2.0 v2.1
> generic/285 generic/448 generic/490    fails on v1.0
>
>
> Are they expected or being worked on?
>
> Thanks!
>
>
> FSTYP         -- cifs
> PLATFORM      -- Linux/x86_64 hp-dl380pg8-14 5.3.0-rc8+ #1 SMP Thu Sep 12 07:31:21 EDT 2019
> MKFS_OPTIONS  -- //hp-dl380pg8-14.rhts.eng.pek2.redhat.com/scratch
> MOUNT_OPTIONS -- -o vers=3.11,mfsymlinks -o username=root,password=redhat -o context=system_u:object_r:nfs_t:s0 //hp-dl380pg8-14.rhts.eng.pek2.redhat.com/scratch /mnt/testarea/scratch
>
> generic/285     [failed, exit status 1]- output mismatch (see /var/lib/xfstests/results//generic/285.out.bad)
>     --- tests/generic/285.out   2019-09-12 08:04:14.120990746 -0400
>     +++ /var/lib/xfstests/results//generic/285.out.bad  2019-09-12 08:36:49.151230335 -0400
>     @@ -1 +1,3 @@
>      QA output created by 285
>     +seek sanity check failed!
>     +(see /var/lib/xfstests/results//generic/285.full for details)
>     ...



-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: seek sanity check failures
  2019-09-15  4:11 ` Steve French
@ 2019-09-16  8:47   ` Murphy Zhou
  0 siblings, 0 replies; 3+ messages in thread
From: Murphy Zhou @ 2019-09-16  8:47 UTC (permalink / raw)
  To: Steve French; +Cc: Murphy Zhou, CIFS, amir73il, fstests

On Sat, Sep 14, 2019 at 11:11:49PM -0500, Steve French wrote:
> Test 285 and 490 broke when xfstests were updated on the buildbot, and
> are temporarily deleted (commented out in the buildbot script).  We
> had a difficult choice - update xfstests and add 10 new tests but
> disable 3 tests which broke with updated tests, or not add the 10
> tests by keeping running last year's old xfstest test suite.
> 
> Ronnie and I did some investigation of why 285 and 490 failed and any
> additional data would help - since we both got distracted with other
> features and fixes

In Apr 2019, Amir updated seek_sanity_check:

(xfstests commit 34081087748)

pwrite a file, then double the filesize by ftruncate, then SEEK_HOLE.
If SEEK_HOLE returns EOF, and fstype is in this list:

+       btrfs|ext4|xfs|ceph|cifs|f2fs|gfs2|nfs*|ocfs2|tmpfs)

It's the default behavior and it's NOT allowed. Test prints error and exit.

If cifs is removed from above list, all seek sanity check tests pass on cifs.

cifs SEEK_DATA SEEK_HOLE support were added in May 2019 with Linux
commit dece44e381a

A xfstests patch removing cifs from the list can address these failures,
but is the "default behavior" of SEEK_HOLE on cifs expected?

If it's not expected and need to work on, we should keep current status.

Thanks!
M

> 
> On Sat, Sep 14, 2019 at 10:14 PM Murphy Zhou <jencce.kernel@gmail.com> wrote:
> >
> > Hi,
> >
> > On latest Linus tree, several seek tests fails:
> >
> > generic/285 generic/490 generic/539    fails on v3.11 v3.02 v3.0
> > generic/285 generic/490                fails on v2.0 v2.1
> > generic/285 generic/448 generic/490    fails on v1.0
> >
> >
> > Are they expected or being worked on?
> >
> > Thanks!
> >
> >
> > FSTYP         -- cifs
> > PLATFORM      -- Linux/x86_64 hp-dl380pg8-14 5.3.0-rc8+ #1 SMP Thu Sep 12 07:31:21 EDT 2019
> > MKFS_OPTIONS  -- //hp-dl380pg8-14.rhts.eng.pek2.redhat.com/scratch
> > MOUNT_OPTIONS -- -o vers=3.11,mfsymlinks -o username=root,password=redhat -o context=system_u:object_r:nfs_t:s0 //hp-dl380pg8-14.rhts.eng.pek2.redhat.com/scratch /mnt/testarea/scratch
> >
> > generic/285     [failed, exit status 1]- output mismatch (see /var/lib/xfstests/results//generic/285.out.bad)
> >     --- tests/generic/285.out   2019-09-12 08:04:14.120990746 -0400
> >     +++ /var/lib/xfstests/results//generic/285.out.bad  2019-09-12 08:36:49.151230335 -0400
> >     @@ -1 +1,3 @@
> >      QA output created by 285
> >     +seek sanity check failed!
> >     +(see /var/lib/xfstests/results//generic/285.full for details)
> >     ...
> 
> 
> 
> -- 
> Thanks,
> 
> Steve

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-15  2:08 seek sanity check failures Murphy Zhou
2019-09-15  4:11 ` Steve French
2019-09-16  8:47   ` Murphy Zhou

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git