Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
* Re: nsdeps not working on modules in 5.4-rc1
       [not found] <CAH2r5mv49T9gwwoJxKJfkgdi6xbf+hDALUiAJHghGikgUNParw@mail.gmail.com>
@ 2019-10-02 23:54 ` Steve French
  2019-10-03 10:43   ` Matthias Maennich
  0 siblings, 1 reply; 10+ messages in thread
From: Steve French @ 2019-10-02 23:54 UTC (permalink / raw)
  To: LKML, Matthias Maennich; +Cc: CIFS

And running the build differently, from the root of the git tree
(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails

e.g. "make  M=fs/cifs modules nsdeps"

...
  LD [M]  fs/cifs/cifs.o
  Building modules, stage 2.
  MODPOST 1 modules
WARNING: module cifs uses symbol sigprocmask from namespace
_fs/cifs/cache.o), but does not import it.
...
WARNING: module cifs uses symbol posix_test_lock from namespace
cifs/cache.o), but does not import it.
  CC [M]  fs/cifs/cifs.mod.o
  LD [M]  fs/cifs/cifs.ko
  Building modules, stage 2.
  MODPOST 1 modules
./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
make: *** [Makefile:1710: nsdeps] Error 2

On Wed, Oct 2, 2019 at 6:45 PM Steve French <smfrench@gmail.com> wrote:
>
> Following the instructions in Documentation/namespaces to autogenerate
> the namespace changes to avoid the multiple build warnings in 5.4-rc1
> for my module ... I am not able to get nsdeps to work.   For example
> in my module directory (fs/cifs) trying to build with nsdeps:
>
>       make -C /usr/src/linux-headers-`uname -r` M=`pwd` modules nsdeps
>
> gets the error "cat: ./modules.order: No such file or directory"
>
> This is on Ubuntu 18, running current 5.4-rc1 kernel.  It looks like
> it is looking for modules.order in the wrong directory (it is present
> in fs/cifs - but it looks like it is looking for it in /usr/src where
> of course it won't be found)
>
> I am trying to remove the hundreds of new warnings introduced by
> namespaces in 5.4-rc1 when building my module e.g.
>
> WARNING: module cifs uses symbol __fscache_acquire_cookie from
> namespace .o: $(deps_/home/sfrench/cifs-2.6/fs/cifs/cache.o), but does
> not import it.
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: nsdeps not working on modules in 5.4-rc1
  2019-10-02 23:54 ` nsdeps not working on modules in 5.4-rc1 Steve French
@ 2019-10-03 10:43   ` Matthias Maennich
  2019-10-03 15:14     ` Steve French
  0 siblings, 1 reply; 10+ messages in thread
From: Matthias Maennich @ 2019-10-03 10:43 UTC (permalink / raw)
  To: Steve French; +Cc: LKML, CIFS, Masahiro Yamada, Jessica Yu

Hi Steve!

On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
>And running the build differently, from the root of the git tree
>(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
>
>e.g. "make  M=fs/cifs modules nsdeps"
>
>...
>  LD [M]  fs/cifs/cifs.o
>  Building modules, stage 2.
>  MODPOST 1 modules
>WARNING: module cifs uses symbol sigprocmask from namespace
>_fs/cifs/cache.o), but does not import it.
>...
>WARNING: module cifs uses symbol posix_test_lock from namespace
>cifs/cache.o), but does not import it.
>  CC [M]  fs/cifs/cifs.mod.o
>  LD [M]  fs/cifs/cifs.ko
>  Building modules, stage 2.
>  MODPOST 1 modules
>./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
>make: *** [Makefile:1710: nsdeps] Error 2

Thanks for reporting this. It appears to me you hit a bug that was
recently discovered: when building with `make M=some/subdirectory`,
modpost is misbehaving. Can you try whether this patch series solves
your problems:
https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
In particular patch 2/6 out of the series.

Cheers,
Matthias

>On Wed, Oct 2, 2019 at 6:45 PM Steve French <smfrench@gmail.com> wrote:
>>
>> Following the instructions in Documentation/namespaces to autogenerate
>> the namespace changes to avoid the multiple build warnings in 5.4-rc1
>> for my module ... I am not able to get nsdeps to work.   For example
>> in my module directory (fs/cifs) trying to build with nsdeps:
>>
>>       make -C /usr/src/linux-headers-`uname -r` M=`pwd` modules nsdeps
>>
>> gets the error "cat: ./modules.order: No such file or directory"
>>
>> This is on Ubuntu 18, running current 5.4-rc1 kernel.  It looks like
>> it is looking for modules.order in the wrong directory (it is present
>> in fs/cifs - but it looks like it is looking for it in /usr/src where
>> of course it won't be found)
>>
>> I am trying to remove the hundreds of new warnings introduced by
>> namespaces in 5.4-rc1 when building my module e.g.
>>
>> WARNING: module cifs uses symbol __fscache_acquire_cookie from
>> namespace .o: $(deps_/home/sfrench/cifs-2.6/fs/cifs/cache.o), but does
>> not import it.
>> --
>> Thanks,
>>
>> Steve
>
>
>
>-- 
>Thanks,
>
>Steve

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: nsdeps not working on modules in 5.4-rc1
  2019-10-03 10:43   ` Matthias Maennich
@ 2019-10-03 15:14     ` Steve French
  2019-10-03 15:23       ` Masahiro Yamada
  0 siblings, 1 reply; 10+ messages in thread
From: Steve French @ 2019-10-03 15:14 UTC (permalink / raw)
  To: Matthias Maennich; +Cc: LKML, CIFS, Masahiro Yamada, Jessica Yu

On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
>
> Hi Steve!
>
> On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> >And running the build differently, from the root of the git tree
> >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> >
> >e.g. "make  M=fs/cifs modules nsdeps"
> >
> >...
> >  LD [M]  fs/cifs/cifs.o
> >  Building modules, stage 2.
> >  MODPOST 1 modules
> >WARNING: module cifs uses symbol sigprocmask from namespace
> >_fs/cifs/cache.o), but does not import it.
> >...
> >WARNING: module cifs uses symbol posix_test_lock from namespace
> >cifs/cache.o), but does not import it.
> >  CC [M]  fs/cifs/cifs.mod.o
> >  LD [M]  fs/cifs/cifs.ko
> >  Building modules, stage 2.
> >  MODPOST 1 modules
> >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> >make: *** [Makefile:1710: nsdeps] Error 2
>
> Thanks for reporting this. It appears to me you hit a bug that was
> recently discovered: when building with `make M=some/subdirectory`,
> modpost is misbehaving. Can you try whether this patch series solves
> your problems:
> https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> In particular patch 2/6 out of the series.
>
> Cheers,
> Matthias


Applying just patch 2 and doing "make" from the root of the git tree
(5.4-rc1), at the tail end of the build I got

...
Kernel: arch/x86/boot/bzImage is ready  (#87)
  Building modules, stage 2.
  MODPOST 5340 modules
free(): invalid pointer
Aborted (core dumped)
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 134
make: *** [Makefile:1303: modules] Error 2

With patch 2 and doing make M=fs/cifs nsdeps from the root of the git tree I get

$ make M=fs/cifs nsdeps
  Building modules, stage 2.
  MODPOST 1 modules
  Building modules, stage 2.
  MODPOST 1 modules
./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
make: *** [Makefile:1710: nsdeps] Error 2


-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: nsdeps not working on modules in 5.4-rc1
  2019-10-03 15:14     ` Steve French
@ 2019-10-03 15:23       ` Masahiro Yamada
  2019-10-03 16:06         ` Steve French
  0 siblings, 1 reply; 10+ messages in thread
From: Masahiro Yamada @ 2019-10-03 15:23 UTC (permalink / raw)
  To: Steve French; +Cc: Matthias Maennich, LKML, CIFS, Jessica Yu

Hi Steve,

On Fri, Oct 4, 2019 at 12:15 AM Steve French <smfrench@gmail.com> wrote:
>
> On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
> >
> > Hi Steve!
> >
> > On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> > >And running the build differently, from the root of the git tree
> > >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> > >
> > >e.g. "make  M=fs/cifs modules nsdeps"
> > >
> > >...
> > >  LD [M]  fs/cifs/cifs.o
> > >  Building modules, stage 2.
> > >  MODPOST 1 modules
> > >WARNING: module cifs uses symbol sigprocmask from namespace
> > >_fs/cifs/cache.o), but does not import it.
> > >...
> > >WARNING: module cifs uses symbol posix_test_lock from namespace
> > >cifs/cache.o), but does not import it.
> > >  CC [M]  fs/cifs/cifs.mod.o
> > >  LD [M]  fs/cifs/cifs.ko
> > >  Building modules, stage 2.
> > >  MODPOST 1 modules
> > >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> > >make: *** [Makefile:1710: nsdeps] Error 2
> >
> > Thanks for reporting this. It appears to me you hit a bug that was
> > recently discovered: when building with `make M=some/subdirectory`,
> > modpost is misbehaving. Can you try whether this patch series solves
> > your problems:
> > https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> > In particular patch 2/6 out of the series.
> >
> > Cheers,
> > Matthias
>
>
> Applying just patch 2 and doing "make" from the root of the git tree
> (5.4-rc1), at the tail end of the build I got
>
> ...
> Kernel: arch/x86/boot/bzImage is ready  (#87)
>   Building modules, stage 2.
>   MODPOST 5340 modules
> free(): invalid pointer
> Aborted (core dumped)


Right.

Since 2/6 depends on 1/6,
applying only the second one does not work.




> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 134
> make: *** [Makefile:1303: modules] Error 2
>
> With patch 2 and doing make M=fs/cifs nsdeps from the root of the git tree I get
>
> $ make M=fs/cifs nsdeps
>   Building modules, stage 2.
>   MODPOST 1 modules
>   Building modules, stage 2.
>   MODPOST 1 modules
> ./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> make: *** [Makefile:1710: nsdeps] Error 2
>
>
> --
> Thanks,
>
> Steve



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: nsdeps not working on modules in 5.4-rc1
  2019-10-03 15:23       ` Masahiro Yamada
@ 2019-10-03 16:06         ` Steve French
  2019-10-04  3:40           ` Masahiro Yamada
  0 siblings, 1 reply; 10+ messages in thread
From: Steve French @ 2019-10-03 16:06 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: Matthias Maennich, LKML, CIFS, Jessica Yu

On Thu, Oct 3, 2019 at 10:24 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Hi Steve,
>
> On Fri, Oct 4, 2019 at 12:15 AM Steve French <smfrench@gmail.com> wrote:
> >
> > On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
> > >
> > > Hi Steve!
> > >
> > > On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> > > >And running the build differently, from the root of the git tree
> > > >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> > > >
> > > >e.g. "make  M=fs/cifs modules nsdeps"
> > > >
> > > >...
> > > >  LD [M]  fs/cifs/cifs.o
> > > >  Building modules, stage 2.
> > > >  MODPOST 1 modules
> > > >WARNING: module cifs uses symbol sigprocmask from namespace
> > > >_fs/cifs/cache.o), but does not import it.
> > > >...
> > > >WARNING: module cifs uses symbol posix_test_lock from namespace
> > > >cifs/cache.o), but does not import it.
> > > >  CC [M]  fs/cifs/cifs.mod.o
> > > >  LD [M]  fs/cifs/cifs.ko
> > > >  Building modules, stage 2.
> > > >  MODPOST 1 modules
> > > >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> > > >make: *** [Makefile:1710: nsdeps] Error 2
> > >
> > > Thanks for reporting this. It appears to me you hit a bug that was
> > > recently discovered: when building with `make M=some/subdirectory`,
> > > modpost is misbehaving. Can you try whether this patch series solves
> > > your problems:
> > > https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> > > In particular patch 2/6 out of the series.
> > >
> > > Cheers,
> > > Matthias
> >
> >
> > Applying just patch 2 and doing "make" from the root of the git tree
> > (5.4-rc1), at the tail end of the build I got
> >
> > ...
> > Kernel: arch/x86/boot/bzImage is ready  (#87)
> >   Building modules, stage 2.
> >   MODPOST 5340 modules
> > free(): invalid pointer
> > Aborted (core dumped)
>
>
> Right.
>
> Since 2/6 depends on 1/6,
> applying only the second one does not work.

Applying both 1 and 2 I get the following error doing make (although
it makes it a long way into the build)

<snip>
WARNING: drivers/usb/storage/usb-storage: 'USB_STORAGE' exported
twice. Previous export was in drivers/usb/storage/usb-storage.ko
ERROR: "usb_stor_set_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
ERROR: "usb_stor_access_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
ERROR: "usb_stor_post_reset" [drivers/usb/storage/ums-usbat.ko] undefined!
ERROR: "usb_stor_disconnect" [drivers/usb/storage/ums-usbat.ko] undefined!
<snip>
ERROR: "usb_stor_adjust_quirks" [drivers/usb/storage/uas.ko] undefined!
ERROR: "usb_stor_sense_invalidCDB" [drivers/usb/storage/uas.ko] undefined!
WARNING: "USB_STORAGE" [drivers/usb/storage/usb-storage] is a static
EXPORT_SYMBOL_GPL
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1303: modules] Error 2

Running "make M=fs/cifs nsdeps" I still get the error

  Building modules, stage 2.
  MODPOST 1 modules
./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
make: *** [Makefile:1710: nsdeps] Error 2



-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: nsdeps not working on modules in 5.4-rc1
  2019-10-03 16:06         ` Steve French
@ 2019-10-04  3:40           ` Masahiro Yamada
  2019-10-04  4:27             ` Steve French
  0 siblings, 1 reply; 10+ messages in thread
From: Masahiro Yamada @ 2019-10-04  3:40 UTC (permalink / raw)
  To: Steve French; +Cc: Matthias Maennich, LKML, CIFS, Jessica Yu

Hi Steve,

On Fri, Oct 4, 2019 at 1:07 AM Steve French <smfrench@gmail.com> wrote:
>
> On Thu, Oct 3, 2019 at 10:24 AM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > Hi Steve,
> >
> > On Fri, Oct 4, 2019 at 12:15 AM Steve French <smfrench@gmail.com> wrote:
> > >
> > > On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
> > > >
> > > > Hi Steve!
> > > >
> > > > On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> > > > >And running the build differently, from the root of the git tree
> > > > >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> > > > >
> > > > >e.g. "make  M=fs/cifs modules nsdeps"
> > > > >
> > > > >...
> > > > >  LD [M]  fs/cifs/cifs.o
> > > > >  Building modules, stage 2.
> > > > >  MODPOST 1 modules
> > > > >WARNING: module cifs uses symbol sigprocmask from namespace
> > > > >_fs/cifs/cache.o), but does not import it.
> > > > >...
> > > > >WARNING: module cifs uses symbol posix_test_lock from namespace
> > > > >cifs/cache.o), but does not import it.
> > > > >  CC [M]  fs/cifs/cifs.mod.o
> > > > >  LD [M]  fs/cifs/cifs.ko
> > > > >  Building modules, stage 2.
> > > > >  MODPOST 1 modules
> > > > >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> > > > >make: *** [Makefile:1710: nsdeps] Error 2
> > > >
> > > > Thanks for reporting this. It appears to me you hit a bug that was
> > > > recently discovered: when building with `make M=some/subdirectory`,
> > > > modpost is misbehaving. Can you try whether this patch series solves
> > > > your problems:
> > > > https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> > > > In particular patch 2/6 out of the series.
> > > >
> > > > Cheers,
> > > > Matthias
> > >
> > >
> > > Applying just patch 2 and doing "make" from the root of the git tree
> > > (5.4-rc1), at the tail end of the build I got
> > >
> > > ...
> > > Kernel: arch/x86/boot/bzImage is ready  (#87)
> > >   Building modules, stage 2.
> > >   MODPOST 5340 modules
> > > free(): invalid pointer
> > > Aborted (core dumped)
> >
> >
> > Right.
> >
> > Since 2/6 depends on 1/6,
> > applying only the second one does not work.
>
> Applying both 1 and 2 I get the following error doing make (although
> it makes it a long way into the build)
>
> <snip>
> WARNING: drivers/usb/storage/usb-storage: 'USB_STORAGE' exported
> twice. Previous export was in drivers/usb/storage/usb-storage.ko
> ERROR: "usb_stor_set_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
> ERROR: "usb_stor_access_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
> ERROR: "usb_stor_post_reset" [drivers/usb/storage/ums-usbat.ko] undefined!
> ERROR: "usb_stor_disconnect" [drivers/usb/storage/ums-usbat.ko] undefined!
> <snip>
> ERROR: "usb_stor_adjust_quirks" [drivers/usb/storage/uas.ko] undefined!
> ERROR: "usb_stor_sense_invalidCDB" [drivers/usb/storage/uas.ko] undefined!
> WARNING: "USB_STORAGE" [drivers/usb/storage/usb-storage] is a static
> EXPORT_SYMBOL_GPL
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1303: modules] Error 2


Hmm, I do not see those error.
I was able to build the kernel successfully.
(I asked the 0-day bot to test whole of my patch set
in case I am missing something.)


Could you share the steps to reproduce the errors and your .config file?






> Running "make M=fs/cifs nsdeps" I still get the error

Sorry, I do not understand why you are doing this.


>
>   Building modules, stage 2.
>   MODPOST 1 modules
> ./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> make: *** [Makefile:1710: nsdeps] Error 2
>
>
>
> --
> Thanks,
>
> Steve



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: nsdeps not working on modules in 5.4-rc1
  2019-10-04  3:40           ` Masahiro Yamada
@ 2019-10-04  4:27             ` Steve French
  2019-10-04  4:50               ` Masahiro Yamada
  0 siblings, 1 reply; 10+ messages in thread
From: Steve French @ 2019-10-04  4:27 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: Matthias Maennich, LKML, CIFS, Jessica Yu

On Thu, Oct 3, 2019 at 10:41 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Hi Steve,
>
> On Fri, Oct 4, 2019 at 1:07 AM Steve French <smfrench@gmail.com> wrote:
> >
> > On Thu, Oct 3, 2019 at 10:24 AM Masahiro Yamada
> > <yamada.masahiro@socionext.com> wrote:
> > >
> > > Hi Steve,
> > >
> > > On Fri, Oct 4, 2019 at 12:15 AM Steve French <smfrench@gmail.com> wrote:
> > > >
> > > > On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
> > > > >
> > > > > Hi Steve!
> > > > >
> > > > > On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> > > > > >And running the build differently, from the root of the git tree
> > > > > >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> > > > > >
> > > > > >e.g. "make  M=fs/cifs modules nsdeps"
> > > > > >
> > > > > >...
> > > > > >  LD [M]  fs/cifs/cifs.o
> > > > > >  Building modules, stage 2.
> > > > > >  MODPOST 1 modules
> > > > > >WARNING: module cifs uses symbol sigprocmask from namespace
> > > > > >_fs/cifs/cache.o), but does not import it.
> > > > > >...
> > > > > >WARNING: module cifs uses symbol posix_test_lock from namespace
> > > > > >cifs/cache.o), but does not import it.
> > > > > >  CC [M]  fs/cifs/cifs.mod.o
> > > > > >  LD [M]  fs/cifs/cifs.ko
> > > > > >  Building modules, stage 2.
> > > > > >  MODPOST 1 modules
> > > > > >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> > > > > >make: *** [Makefile:1710: nsdeps] Error 2
> > > > >
> > > > > Thanks for reporting this. It appears to me you hit a bug that was
> > > > > recently discovered: when building with `make M=some/subdirectory`,
> > > > > modpost is misbehaving. Can you try whether this patch series solves
> > > > > your problems:
> > > > > https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> > > > > In particular patch 2/6 out of the series.
> > > > >
> > > > > Cheers,
> > > > > Matthias
> > > >
> > > >
> > > > Applying just patch 2 and doing "make" from the root of the git tree
> > > > (5.4-rc1), at the tail end of the build I got
> > > >
> > > > ...
> > > > Kernel: arch/x86/boot/bzImage is ready  (#87)
> > > >   Building modules, stage 2.
> > > >   MODPOST 5340 modules
> > > > free(): invalid pointer
> > > > Aborted (core dumped)
> > >
> > >
> > > Right.
> > >
> > > Since 2/6 depends on 1/6,
> > > applying only the second one does not work.
> >
> > Applying both 1 and 2 I get the following error doing make (although
> > it makes it a long way into the build)
> >
> > <snip>
> > WARNING: drivers/usb/storage/usb-storage: 'USB_STORAGE' exported
> > twice. Previous export was in drivers/usb/storage/usb-storage.ko
> > ERROR: "usb_stor_set_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
> > ERROR: "usb_stor_access_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
> > ERROR: "usb_stor_post_reset" [drivers/usb/storage/ums-usbat.ko] undefined!
> > ERROR: "usb_stor_disconnect" [drivers/usb/storage/ums-usbat.ko] undefined!
> > <snip>
> > ERROR: "usb_stor_adjust_quirks" [drivers/usb/storage/uas.ko] undefined!
> > ERROR: "usb_stor_sense_invalidCDB" [drivers/usb/storage/uas.ko] undefined!
> > WARNING: "USB_STORAGE" [drivers/usb/storage/usb-storage] is a static
> > EXPORT_SYMBOL_GPL
> > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> > make: *** [Makefile:1303: modules] Error 2
>
>
> Hmm, I do not see those error.
> I was able to build the kernel successfully.
> (I asked the 0-day bot to test whole of my patch set
> in case I am missing something.)
>
>
> Could you share the steps to reproduce the errors and your .config file?

From the root of git tree - at exactly 5.4-rc1

~/cifs-2.6$ make nsdeps
  CALL    scripts/checksyscalls.sh
  CALL    scripts/atomic/check-atomics.sh
  DESCEND  objtool
  CHK     include/generated/compile.h
  CHK     kernel/kheaders_data.tar.xz
  Building modules, stage 2.
  MODPOST 5340 modules
  Building modules, stage 2.
  MODPOST 5340 modules
./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
make: *** [Makefile:1710: nsdeps] Error 2

I get the same error doing "rm fs/cifs/*.o" and repeating the "make
nsdeps" command

I will send you the .config

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: nsdeps not working on modules in 5.4-rc1
  2019-10-04  4:27             ` Steve French
@ 2019-10-04  4:50               ` Masahiro Yamada
  2019-10-04  5:01                 ` Steve French
  0 siblings, 1 reply; 10+ messages in thread
From: Masahiro Yamada @ 2019-10-04  4:50 UTC (permalink / raw)
  To: Steve French; +Cc: Matthias Maennich, LKML, CIFS, Jessica Yu

Hi Steve,

On Fri, Oct 4, 2019 at 1:28 PM Steve French <smfrench@gmail.com> wrote:
>
> On Thu, Oct 3, 2019 at 10:41 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > Hi Steve,
> >
> > On Fri, Oct 4, 2019 at 1:07 AM Steve French <smfrench@gmail.com> wrote:
> > >
> > > On Thu, Oct 3, 2019 at 10:24 AM Masahiro Yamada
> > > <yamada.masahiro@socionext.com> wrote:
> > > >
> > > > Hi Steve,
> > > >
> > > > On Fri, Oct 4, 2019 at 12:15 AM Steve French <smfrench@gmail.com> wrote:
> > > > >
> > > > > On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
> > > > > >
> > > > > > Hi Steve!
> > > > > >
> > > > > > On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> > > > > > >And running the build differently, from the root of the git tree
> > > > > > >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> > > > > > >
> > > > > > >e.g. "make  M=fs/cifs modules nsdeps"
> > > > > > >
> > > > > > >...
> > > > > > >  LD [M]  fs/cifs/cifs.o
> > > > > > >  Building modules, stage 2.
> > > > > > >  MODPOST 1 modules
> > > > > > >WARNING: module cifs uses symbol sigprocmask from namespace
> > > > > > >_fs/cifs/cache.o), but does not import it.
> > > > > > >...
> > > > > > >WARNING: module cifs uses symbol posix_test_lock from namespace
> > > > > > >cifs/cache.o), but does not import it.
> > > > > > >  CC [M]  fs/cifs/cifs.mod.o
> > > > > > >  LD [M]  fs/cifs/cifs.ko
> > > > > > >  Building modules, stage 2.
> > > > > > >  MODPOST 1 modules
> > > > > > >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> > > > > > >make: *** [Makefile:1710: nsdeps] Error 2
> > > > > >
> > > > > > Thanks for reporting this. It appears to me you hit a bug that was
> > > > > > recently discovered: when building with `make M=some/subdirectory`,
> > > > > > modpost is misbehaving. Can you try whether this patch series solves
> > > > > > your problems:
> > > > > > https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> > > > > > In particular patch 2/6 out of the series.
> > > > > >
> > > > > > Cheers,
> > > > > > Matthias
> > > > >
> > > > >
> > > > > Applying just patch 2 and doing "make" from the root of the git tree
> > > > > (5.4-rc1), at the tail end of the build I got
> > > > >
> > > > > ...
> > > > > Kernel: arch/x86/boot/bzImage is ready  (#87)
> > > > >   Building modules, stage 2.
> > > > >   MODPOST 5340 modules
> > > > > free(): invalid pointer
> > > > > Aborted (core dumped)
> > > >
> > > >
> > > > Right.
> > > >
> > > > Since 2/6 depends on 1/6,
> > > > applying only the second one does not work.
> > >
> > > Applying both 1 and 2 I get the following error doing make (although
> > > it makes it a long way into the build)
> > >
> > > <snip>
> > > WARNING: drivers/usb/storage/usb-storage: 'USB_STORAGE' exported
> > > twice. Previous export was in drivers/usb/storage/usb-storage.ko
> > > ERROR: "usb_stor_set_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
> > > ERROR: "usb_stor_access_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
> > > ERROR: "usb_stor_post_reset" [drivers/usb/storage/ums-usbat.ko] undefined!
> > > ERROR: "usb_stor_disconnect" [drivers/usb/storage/ums-usbat.ko] undefined!
> > > <snip>
> > > ERROR: "usb_stor_adjust_quirks" [drivers/usb/storage/uas.ko] undefined!
> > > ERROR: "usb_stor_sense_invalidCDB" [drivers/usb/storage/uas.ko] undefined!
> > > WARNING: "USB_STORAGE" [drivers/usb/storage/usb-storage] is a static
> > > EXPORT_SYMBOL_GPL
> > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> > > make: *** [Makefile:1303: modules] Error 2
> >
> >
> > Hmm, I do not see those error.
> > I was able to build the kernel successfully.
> > (I asked the 0-day bot to test whole of my patch set
> > in case I am missing something.)
> >
> >
> > Could you share the steps to reproduce the errors and your .config file?
>
> From the root of git tree - at exactly 5.4-rc1
>
> ~/cifs-2.6$ make nsdeps
>   CALL    scripts/checksyscalls.sh
>   CALL    scripts/atomic/check-atomics.sh
>   DESCEND  objtool
>   CHK     include/generated/compile.h
>   CHK     kernel/kheaders_data.tar.xz
>   Building modules, stage 2.
>   MODPOST 5340 modules
>   Building modules, stage 2.
>   MODPOST 5340 modules
> ./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> make: *** [Makefile:1710: nsdeps] Error 2
>
> I get the same error doing "rm fs/cifs/*.o" and repeating the "make
> nsdeps" command
>
> I will send you the .config



You need to clarify your problem.

In the first post from you, you pointed out
"hundreds of new warnings introduced by namespaces in 5.4-rc1 when
building my module"

So, 1/6 and 2/6 should address that problem.
https://lore.kernel.org/patchwork/patch/1133628/
https://lore.kernel.org/patchwork/patch/1133626/


Then, in the previous email ("Applying both 1 and 2 I get the
following error doing make")
it looks like you were talking about in-kernel building
instead of the external module.


Then, in this email, you are talking about "make nsdeps".
"make nsdeps" obviously does not support M=.


I am afraid you are mixing up different issues,
which is so confusing. (and I am afraid you were too confused)

Currently, the namespace is used only by USB_STORAGE.
So, it should not be a problem for your module.

To sum up, you do not need to run nsdeps at all.
The hundreds of false-positive warnings came from the modpost bug,
and should be fixed soon.


-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: nsdeps not working on modules in 5.4-rc1
  2019-10-04  4:50               ` Masahiro Yamada
@ 2019-10-04  5:01                 ` Steve French
  2019-10-04 10:40                   ` Matthias Maennich
  0 siblings, 1 reply; 10+ messages in thread
From: Steve French @ 2019-10-04  5:01 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: Matthias Maennich, LKML, CIFS, Jessica Yu

[-- Attachment #1: Type: text/plain, Size: 6611 bytes --]

ok - so to sum up, it sounds like you are saying the 350 false
positives (see attached file) that happen on building cifs.ko .will be
fixed by a
future change to modpost?  This is  a typical module build ...
download and install current kernel package (in this case Ubuntu
5.4-rc1). which saves huge amount of build time, then build just the
module of interest (in my case cifs.ko)

                   cd fs/cifs
                   make C=1 -C /usr/src/linux-headers-`uname -r` M=`pwd` modules

If nsdeps is not needed to fixup some namespace issue then shouldn't
be a problem, just trying to avoid the distraction of 300+
warning messages every time I build just this one module.  Is there a
workaround?

On Thu, Oct 3, 2019 at 11:51 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Hi Steve,
>
> On Fri, Oct 4, 2019 at 1:28 PM Steve French <smfrench@gmail.com> wrote:
> >
> > On Thu, Oct 3, 2019 at 10:41 PM Masahiro Yamada
> > <yamada.masahiro@socionext.com> wrote:
> > >
> > > Hi Steve,
> > >
> > > On Fri, Oct 4, 2019 at 1:07 AM Steve French <smfrench@gmail.com> wrote:
> > > >
> > > > On Thu, Oct 3, 2019 at 10:24 AM Masahiro Yamada
> > > > <yamada.masahiro@socionext.com> wrote:
> > > > >
> > > > > Hi Steve,
> > > > >
> > > > > On Fri, Oct 4, 2019 at 12:15 AM Steve French <smfrench@gmail.com> wrote:
> > > > > >
> > > > > > On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
> > > > > > >
> > > > > > > Hi Steve!
> > > > > > >
> > > > > > > On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> > > > > > > >And running the build differently, from the root of the git tree
> > > > > > > >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> > > > > > > >
> > > > > > > >e.g. "make  M=fs/cifs modules nsdeps"
> > > > > > > >
> > > > > > > >...
> > > > > > > >  LD [M]  fs/cifs/cifs.o
> > > > > > > >  Building modules, stage 2.
> > > > > > > >  MODPOST 1 modules
> > > > > > > >WARNING: module cifs uses symbol sigprocmask from namespace
> > > > > > > >_fs/cifs/cache.o), but does not import it.
> > > > > > > >...
> > > > > > > >WARNING: module cifs uses symbol posix_test_lock from namespace
> > > > > > > >cifs/cache.o), but does not import it.
> > > > > > > >  CC [M]  fs/cifs/cifs.mod.o
> > > > > > > >  LD [M]  fs/cifs/cifs.ko
> > > > > > > >  Building modules, stage 2.
> > > > > > > >  MODPOST 1 modules
> > > > > > > >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> > > > > > > >make: *** [Makefile:1710: nsdeps] Error 2
> > > > > > >
> > > > > > > Thanks for reporting this. It appears to me you hit a bug that was
> > > > > > > recently discovered: when building with `make M=some/subdirectory`,
> > > > > > > modpost is misbehaving. Can you try whether this patch series solves
> > > > > > > your problems:
> > > > > > > https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> > > > > > > In particular patch 2/6 out of the series.
> > > > > > >
> > > > > > > Cheers,
> > > > > > > Matthias
> > > > > >
> > > > > >
> > > > > > Applying just patch 2 and doing "make" from the root of the git tree
> > > > > > (5.4-rc1), at the tail end of the build I got
> > > > > >
> > > > > > ...
> > > > > > Kernel: arch/x86/boot/bzImage is ready  (#87)
> > > > > >   Building modules, stage 2.
> > > > > >   MODPOST 5340 modules
> > > > > > free(): invalid pointer
> > > > > > Aborted (core dumped)
> > > > >
> > > > >
> > > > > Right.
> > > > >
> > > > > Since 2/6 depends on 1/6,
> > > > > applying only the second one does not work.
> > > >
> > > > Applying both 1 and 2 I get the following error doing make (although
> > > > it makes it a long way into the build)
> > > >
> > > > <snip>
> > > > WARNING: drivers/usb/storage/usb-storage: 'USB_STORAGE' exported
> > > > twice. Previous export was in drivers/usb/storage/usb-storage.ko
> > > > ERROR: "usb_stor_set_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
> > > > ERROR: "usb_stor_access_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
> > > > ERROR: "usb_stor_post_reset" [drivers/usb/storage/ums-usbat.ko] undefined!
> > > > ERROR: "usb_stor_disconnect" [drivers/usb/storage/ums-usbat.ko] undefined!
> > > > <snip>
> > > > ERROR: "usb_stor_adjust_quirks" [drivers/usb/storage/uas.ko] undefined!
> > > > ERROR: "usb_stor_sense_invalidCDB" [drivers/usb/storage/uas.ko] undefined!
> > > > WARNING: "USB_STORAGE" [drivers/usb/storage/usb-storage] is a static
> > > > EXPORT_SYMBOL_GPL
> > > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> > > > make: *** [Makefile:1303: modules] Error 2
> > >
> > >
> > > Hmm, I do not see those error.
> > > I was able to build the kernel successfully.
> > > (I asked the 0-day bot to test whole of my patch set
> > > in case I am missing something.)
> > >
> > >
> > > Could you share the steps to reproduce the errors and your .config file?
> >
> > From the root of git tree - at exactly 5.4-rc1
> >
> > ~/cifs-2.6$ make nsdeps
> >   CALL    scripts/checksyscalls.sh
> >   CALL    scripts/atomic/check-atomics.sh
> >   DESCEND  objtool
> >   CHK     include/generated/compile.h
> >   CHK     kernel/kheaders_data.tar.xz
> >   Building modules, stage 2.
> >   MODPOST 5340 modules
> >   Building modules, stage 2.
> >   MODPOST 5340 modules
> > ./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> > make: *** [Makefile:1710: nsdeps] Error 2
> >
> > I get the same error doing "rm fs/cifs/*.o" and repeating the "make
> > nsdeps" command
> >
> > I will send you the .config
>
>
>
> You need to clarify your problem.
>
> In the first post from you, you pointed out
> "hundreds of new warnings introduced by namespaces in 5.4-rc1 when
> building my module"
>
> So, 1/6 and 2/6 should address that problem.
> https://lore.kernel.org/patchwork/patch/1133628/
> https://lore.kernel.org/patchwork/patch/1133626/
>
>
> Then, in the previous email ("Applying both 1 and 2 I get the
> following error doing make")
> it looks like you were talking about in-kernel building
> instead of the external module.
>
>
> Then, in this email, you are talking about "make nsdeps".
> "make nsdeps" obviously does not support M=.
>
>
> I am afraid you are mixing up different issues,
> which is so confusing. (and I am afraid you were too confused)
>
> Currently, the namespace is used only by USB_STORAGE.
> So, it should not be a problem for your module.
>
> To sum up, you do not need to run nsdeps at all.
> The hundreds of false-positive warnings came from the modpost bug,
> and should be fixed soon.
>
>
> --
> Best Regards
> Masahiro Yamada



-- 
Thanks,

Steve

[-- Attachment #2: out --]
[-- Type: application/octet-stream, Size: 57312 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: nsdeps not working on modules in 5.4-rc1
  2019-10-04  5:01                 ` Steve French
@ 2019-10-04 10:40                   ` Matthias Maennich
  0 siblings, 0 replies; 10+ messages in thread
From: Matthias Maennich @ 2019-10-04 10:40 UTC (permalink / raw)
  To: Steve French; +Cc: Masahiro Yamada, LKML, CIFS, Jessica Yu

Hi Steve,

On Fri, Oct 04, 2019 at 12:01:20AM -0500, Steve French wrote:
>ok - so to sum up, it sounds like you are saying the 350 false
>positives (see attached file) that happen on building cifs.ko .will be
>fixed by a
>future change to modpost?  This is  a typical module build ...

Yes, the reason for you to see these false positive warnings is a bug in
modpost. The patch series we were referring to addresses this problem
(and some others). I do not believe you need to run nsdeps to fixup
anything in fs/cifs at this time.

>download and install current kernel package (in this case Ubuntu
>5.4-rc1). which saves huge amount of build time, then build just the
>module of interest (in my case cifs.ko)
>
>                   cd fs/cifs
>                   make C=1 -C /usr/src/linux-headers-`uname -r` M=`pwd` modules
>
>If nsdeps is not needed to fixup some namespace issue then shouldn't
>be a problem, just trying to avoid the distraction of 300+
>warning messages every time I build just this one module.  Is there a
>workaround?

Sorry for the noise this creates. The only known workaround is to
locally apply the complete patch series.

Cheers,
Matthias

>On Thu, Oct 3, 2019 at 11:51 PM Masahiro Yamada
><yamada.masahiro@socionext.com> wrote:
>>
>> Hi Steve,
>>
>> On Fri, Oct 4, 2019 at 1:28 PM Steve French <smfrench@gmail.com> wrote:
>> >
>> > On Thu, Oct 3, 2019 at 10:41 PM Masahiro Yamada
>> > <yamada.masahiro@socionext.com> wrote:
>> > >
>> > > Hi Steve,
>> > >
>> > > On Fri, Oct 4, 2019 at 1:07 AM Steve French <smfrench@gmail.com> wrote:
>> > > >
>> > > > On Thu, Oct 3, 2019 at 10:24 AM Masahiro Yamada
>> > > > <yamada.masahiro@socionext.com> wrote:
>> > > > >
>> > > > > Hi Steve,
>> > > > >
>> > > > > On Fri, Oct 4, 2019 at 12:15 AM Steve French <smfrench@gmail.com> wrote:
>> > > > > >
>> > > > > > On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
>> > > > > > >
>> > > > > > > Hi Steve!
>> > > > > > >
>> > > > > > > On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
>> > > > > > > >And running the build differently, from the root of the git tree
>> > > > > > > >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
>> > > > > > > >
>> > > > > > > >e.g. "make  M=fs/cifs modules nsdeps"
>> > > > > > > >
>> > > > > > > >...
>> > > > > > > >  LD [M]  fs/cifs/cifs.o
>> > > > > > > >  Building modules, stage 2.
>> > > > > > > >  MODPOST 1 modules
>> > > > > > > >WARNING: module cifs uses symbol sigprocmask from namespace
>> > > > > > > >_fs/cifs/cache.o), but does not import it.
>> > > > > > > >...
>> > > > > > > >WARNING: module cifs uses symbol posix_test_lock from namespace
>> > > > > > > >cifs/cache.o), but does not import it.
>> > > > > > > >  CC [M]  fs/cifs/cifs.mod.o
>> > > > > > > >  LD [M]  fs/cifs/cifs.ko
>> > > > > > > >  Building modules, stage 2.
>> > > > > > > >  MODPOST 1 modules
>> > > > > > > >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
>> > > > > > > >make: *** [Makefile:1710: nsdeps] Error 2
>> > > > > > >
>> > > > > > > Thanks for reporting this. It appears to me you hit a bug that was
>> > > > > > > recently discovered: when building with `make M=some/subdirectory`,
>> > > > > > > modpost is misbehaving. Can you try whether this patch series solves
>> > > > > > > your problems:
>> > > > > > > https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
>> > > > > > > In particular patch 2/6 out of the series.
>> > > > > > >
>> > > > > > > Cheers,
>> > > > > > > Matthias
>> > > > > >
>> > > > > >
>> > > > > > Applying just patch 2 and doing "make" from the root of the git tree
>> > > > > > (5.4-rc1), at the tail end of the build I got
>> > > > > >
>> > > > > > ...
>> > > > > > Kernel: arch/x86/boot/bzImage is ready  (#87)
>> > > > > >   Building modules, stage 2.
>> > > > > >   MODPOST 5340 modules
>> > > > > > free(): invalid pointer
>> > > > > > Aborted (core dumped)
>> > > > >
>> > > > >
>> > > > > Right.
>> > > > >
>> > > > > Since 2/6 depends on 1/6,
>> > > > > applying only the second one does not work.
>> > > >
>> > > > Applying both 1 and 2 I get the following error doing make (although
>> > > > it makes it a long way into the build)
>> > > >
>> > > > <snip>
>> > > > WARNING: drivers/usb/storage/usb-storage: 'USB_STORAGE' exported
>> > > > twice. Previous export was in drivers/usb/storage/usb-storage.ko
>> > > > ERROR: "usb_stor_set_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
>> > > > ERROR: "usb_stor_access_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
>> > > > ERROR: "usb_stor_post_reset" [drivers/usb/storage/ums-usbat.ko] undefined!
>> > > > ERROR: "usb_stor_disconnect" [drivers/usb/storage/ums-usbat.ko] undefined!
>> > > > <snip>
>> > > > ERROR: "usb_stor_adjust_quirks" [drivers/usb/storage/uas.ko] undefined!
>> > > > ERROR: "usb_stor_sense_invalidCDB" [drivers/usb/storage/uas.ko] undefined!
>> > > > WARNING: "USB_STORAGE" [drivers/usb/storage/usb-storage] is a static
>> > > > EXPORT_SYMBOL_GPL
>> > > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
>> > > > make: *** [Makefile:1303: modules] Error 2
>> > >
>> > >
>> > > Hmm, I do not see those error.
>> > > I was able to build the kernel successfully.
>> > > (I asked the 0-day bot to test whole of my patch set
>> > > in case I am missing something.)
>> > >
>> > >
>> > > Could you share the steps to reproduce the errors and your .config file?
>> >
>> > From the root of git tree - at exactly 5.4-rc1
>> >
>> > ~/cifs-2.6$ make nsdeps
>> >   CALL    scripts/checksyscalls.sh
>> >   CALL    scripts/atomic/check-atomics.sh
>> >   DESCEND  objtool
>> >   CHK     include/generated/compile.h
>> >   CHK     kernel/kheaders_data.tar.xz
>> >   Building modules, stage 2.
>> >   MODPOST 5340 modules
>> >   Building modules, stage 2.
>> >   MODPOST 5340 modules
>> > ./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
>> > make: *** [Makefile:1710: nsdeps] Error 2
>> >
>> > I get the same error doing "rm fs/cifs/*.o" and repeating the "make
>> > nsdeps" command
>> >
>> > I will send you the .config
>>
>>
>>
>> You need to clarify your problem.
>>
>> In the first post from you, you pointed out
>> "hundreds of new warnings introduced by namespaces in 5.4-rc1 when
>> building my module"
>>
>> So, 1/6 and 2/6 should address that problem.
>> https://lore.kernel.org/patchwork/patch/1133628/
>> https://lore.kernel.org/patchwork/patch/1133626/
>>
>>
>> Then, in the previous email ("Applying both 1 and 2 I get the
>> following error doing make")
>> it looks like you were talking about in-kernel building
>> instead of the external module.
>>
>>
>> Then, in this email, you are talking about "make nsdeps".
>> "make nsdeps" obviously does not support M=.
>>
>>
>> I am afraid you are mixing up different issues,
>> which is so confusing. (and I am afraid you were too confused)
>>
>> Currently, the namespace is used only by USB_STORAGE.
>> So, it should not be a problem for your module.
>>
>> To sum up, you do not need to run nsdeps at all.
>> The hundreds of false-positive warnings came from the modpost bug,
>> and should be fixed soon.
>>
>>
>> --
>> Best Regards
>> Masahiro Yamada
>
>
>
>-- 
>Thanks,
>
>Steve



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, back to index

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAH2r5mv49T9gwwoJxKJfkgdi6xbf+hDALUiAJHghGikgUNParw@mail.gmail.com>
2019-10-02 23:54 ` nsdeps not working on modules in 5.4-rc1 Steve French
2019-10-03 10:43   ` Matthias Maennich
2019-10-03 15:14     ` Steve French
2019-10-03 15:23       ` Masahiro Yamada
2019-10-03 16:06         ` Steve French
2019-10-04  3:40           ` Masahiro Yamada
2019-10-04  4:27             ` Steve French
2019-10-04  4:50               ` Masahiro Yamada
2019-10-04  5:01                 ` Steve French
2019-10-04 10:40                   ` Matthias Maennich

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git