From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: sfrench@samba.org, linux-cifs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] cifs: Don't use iov_iter::type directly
Date: Thu, 21 Nov 2019 00:19:23 -0800 [thread overview]
Message-ID: <20191121081923.GA19366@infradead.org> (raw)
In-Reply-To: <157432403818.17624.9300948341879954830.stgit@warthog.procyon.org.uk>
On Thu, Nov 21, 2019 at 08:13:58AM +0000, David Howells wrote:
> Don't use iov_iter::type directly, but rather use the new accessor
> functions that have been added. This allows the .type field to be split
> and rearranged without the need to update the filesystems.
I'd rather get rid of the accessor and access the fields directly, as
that is much easier to follow.
next prev parent reply other threads:[~2019-11-21 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 8:13 [PATCH] cifs: Don't use iov_iter::type directly David Howells
2019-11-21 8:19 ` Christoph Hellwig [this message]
2019-11-21 9:11 ` David Howells
2019-11-21 16:07 ` Christoph Hellwig
2019-11-22 16:26 ` Al Viro
2019-12-06 8:35 ` David Howells
2020-01-15 20:53 ` Steve French
2020-01-15 21:19 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121081923.GA19366@infradead.org \
--to=hch@infradead.org \
--cc=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).