Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
From: Murphy Zhou <jencce.kernel@gmail.com>
To: Pavel Shilovsky <piastryyy@gmail.com>
Cc: Murphy Zhou <jencce.kernel@gmail.com>,
	Jeff Layton <jlayton@kernel.org>,
	linux-cifs <linux-cifs@vger.kernel.org>,
	Steve French <smfrench@gmail.com>
Subject: Re: [PATCH] CIFS: unlock file across process
Date: Tue, 25 Feb 2020 13:15:51 +0800
Message-ID: <20200225051551.erpp36onb2kxmxjn@xzhoux.usersys.redhat.com> (raw)
In-Reply-To: <CAKywueRvfABoVrdipic6x5_V31K0sOqs8T5y9VzJuyB4Q40bUQ@mail.gmail.com>

On Mon, Feb 24, 2020 at 11:39:27AM -0800, Pavel Shilovsky wrote:
> вт, 18 февр. 2020 г. в 18:10, Murphy Zhou <jencce.kernel@gmail.com>:
> >
> > On Fri, Feb 14, 2020 at 11:03:00AM -0800, Pavel Shilovsky wrote:
> > > Also, please make sure that resulting patch works against Windows file
> > > share since the locking semantics may be different there.
> >
> > OK.
> >
> > >
> > > Depending on a kind of lease we have on a file, locks may be cached or
> > > not. We probably don't want to have different behavior for cached and
> > > non-cached locks. Especially given the fact that a lease may be broken
> > > in the middle of app execution and the different behavior will be
> > > applied immediately.
> >
> > Testing new patch with and without cache=none option, both samba
> > and Win2019 server.
> >
> > Thanks very much for reviewing!
> >
> 
> cache=none only affects IO and doesn't change the client behavior
> regarding locks. "nolease" mount option can be used to turn off leases
> and make all locks go to the server.

Great to know! I can't find it in any man page. Doing more tests.

Thanks!

> 
> --
> Best regards,
> Pavel Shilovsky

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  4:35 Murphy Zhou
2020-02-14  5:32 ` Steve French
2020-02-14 12:26 ` Jeff Layton
2020-02-14 14:28   ` Murphy Zhou
2020-02-14 19:03     ` Pavel Shilovsky
2020-02-19  2:10       ` Murphy Zhou
2020-02-24 19:39         ` Pavel Shilovsky
2020-02-25  5:15           ` Murphy Zhou [this message]
2020-02-25 19:21             ` Pavel Shilovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200225051551.erpp36onb2kxmxjn@xzhoux.usersys.redhat.com \
    --to=jencce.kernel@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=piastryyy@gmail.com \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git