* [PATCH] cifs: Fix build error when no CONFIG_DNS_RESOLVER
@ 2021-04-09 7:46 Zhang Xiaoxu
2021-04-09 15:58 ` [EXTERNAL] " Shyam Prasad
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Xiaoxu @ 2021-04-09 7:46 UTC (permalink / raw)
To: zhangxiaoxu5, sfrench, linux-cifs, samba-technical, yukuai3, sprasad
hulk robot following build error:
ld: fs/cifs/dns_resolve.o: in function `dns_resolve_server_name_to_ip':
dns_resolve.c:(.text+0x154): undefined reference to `dns_query'
make: *** [Makefile:1251: vmlinux] Error 1
Fixes: e488292a31fa ("cifs: On cifs_reconnect, resolve the hostname again.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
---
fs/cifs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
index fe03cbdae959..0d8199765045 100644
--- a/fs/cifs/Kconfig
+++ b/fs/cifs/Kconfig
@@ -18,6 +18,7 @@ config CIFS
select CRYPTO_AES
select CRYPTO_LIB_DES
select KEYS
+ select DNS_RESOLVER
help
This is the client VFS module for the SMB3 family of NAS protocols,
(including support for the most recent, most secure dialect SMB3.1.1)
@@ -179,7 +180,6 @@ config CIFS_DEBUG_DUMP_KEYS
config CIFS_DFS_UPCALL
bool "DFS feature support"
depends on CIFS
- select DNS_RESOLVER
help
Distributed File System (DFS) support is used to access shares
transparently in an enterprise name space, even if the share
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [EXTERNAL] [PATCH] cifs: Fix build error when no CONFIG_DNS_RESOLVER
2021-04-09 7:46 [PATCH] cifs: Fix build error when no CONFIG_DNS_RESOLVER Zhang Xiaoxu
@ 2021-04-09 15:58 ` Shyam Prasad
0 siblings, 0 replies; 2+ messages in thread
From: Shyam Prasad @ 2021-04-09 15:58 UTC (permalink / raw)
To: Zhang Xiaoxu, sfrench, linux-cifs, samba-technical, yukuai3
Hi Zhang,
Thanks for the catch.
But it looks like Steve had already made this change yesterday. Can you please pull and check now?
Regards,
Shyam
-----Original Message-----
From: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Sent: Friday, April 9, 2021 1:17 PM
To: zhangxiaoxu5@huawei.com; sfrench@samba.org; linux-cifs@vger.kernel.org; samba-technical@lists.samba.org; yukuai3@huawei.com; Shyam Prasad <Shyam.Prasad@microsoft.com>
Subject: [EXTERNAL] [PATCH] cifs: Fix build error when no CONFIG_DNS_RESOLVER
hulk robot following build error:
ld: fs/cifs/dns_resolve.o: in function `dns_resolve_server_name_to_ip':
dns_resolve.c:(.text+0x154): undefined reference to `dns_query'
make: *** [Makefile:1251: vmlinux] Error 1
Fixes: e488292a31fa ("cifs: On cifs_reconnect, resolve the hostname again.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
---
fs/cifs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index fe03cbdae959..0d8199765045 100644
--- a/fs/cifs/Kconfig
+++ b/fs/cifs/Kconfig
@@ -18,6 +18,7 @@ config CIFS
select CRYPTO_AES
select CRYPTO_LIB_DES
select KEYS
+ select DNS_RESOLVER
help
This is the client VFS module for the SMB3 family of NAS protocols,
(including support for the most recent, most secure dialect SMB3.1.1) @@ -179,7 +180,6 @@ config CIFS_DEBUG_DUMP_KEYS config CIFS_DFS_UPCALL
bool "DFS feature support"
depends on CIFS
- select DNS_RESOLVER
help
Distributed File System (DFS) support is used to access shares
transparently in an enterprise name space, even if the share
--
2.25.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-09 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 7:46 [PATCH] cifs: Fix build error when no CONFIG_DNS_RESOLVER Zhang Xiaoxu
2021-04-09 15:58 ` [EXTERNAL] " Shyam Prasad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).