From: Khaled Romdhani <khaledromdhani216@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: sfrench@samba.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH-next] fs/cifs: Fix resource leak
Date: Tue, 4 May 2021 15:14:35 +0100 [thread overview]
Message-ID: <20210504141435.GA24514@ard0534> (raw)
In-Reply-To: <20210504134244.GW1981@kadam>
On Tue, May 04, 2021 at 04:44:45PM +0300, Dan Carpenter wrote:
> On Tue, May 04, 2021 at 01:43:43PM +0100, Khaled ROMDHANI wrote:
> > The -EIO error return path is leaking memory allocated
> > to page. Fix this by invoking the free_dentry_path before
> > the return.
> >
> > Addresses-Coverity: ("Resource leak")
> > Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com>
>
> Add a Fixes tag.
>
> Fixes: 583248493f78 ("cifs: add shutdown support")
>
Yes, I will add a Fixes tag.
> > ---
> > fs/cifs/link.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/cifs/link.c b/fs/cifs/link.c
> > index 1cbe7ec73728..1485c6095ba1 100644
> > --- a/fs/cifs/link.c
> > +++ b/fs/cifs/link.c
> > @@ -686,8 +686,10 @@ cifs_symlink(struct user_namespace *mnt_userns, struct inode *inode,
> > void *page = alloc_dentry_path();
> > struct inode *newinode = NULL;
> >
> > - if (unlikely(cifs_forced_shutdown(cifs_sb)))
> > + if (unlikely(cifs_forced_shutdown(cifs_sb))) {
> > + free_dentry_path(page);
> > return -EIO;
> > + }
>
> Better to move the allocation here. Avoid calling functions which can
> fail in the declaration block. Better to test for NULL directly instead
> of hiding the test inside the build_path_from_dentry() function.
>
> page = alloc_dentry_path();
> if (!page)
> return -ENOMEM;
>
> The error handling in this function is slightly unweildy...
>
> regards,
> dan carpenter
>
Yes, it would be better to move the allocation...
I will send a V2.
Thanks.
next prev parent reply other threads:[~2021-05-04 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 12:43 [PATCH-next] fs/cifs: Fix resource leak Khaled ROMDHANI
2021-05-04 13:44 ` Dan Carpenter
2021-05-04 14:14 ` Khaled Romdhani [this message]
2021-05-04 13:22 Khaled ROMDHANI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504141435.GA24514@ard0534 \
--to=khaledromdhani216@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).