linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH-V2] fs/cifs: Fix resource leak
@ 2021-05-04 15:38 Khaled ROMDHANI
  0 siblings, 0 replies; only message in thread
From: Khaled ROMDHANI @ 2021-05-04 15:38 UTC (permalink / raw)
  To: sfrench
  Cc: Khaled ROMDHANI, linux-cifs, samba-technical, linux-kernel,
	kernel-janitors

The -EIO error return path is leaking memory allocated
to page. Fix this by moving the allocation block after
the check of cifs_forced_shutdown.

Addresses-Coverity: ("Resource leak")
Fixes: 087f757b0129 ("cifs: add shutdown support")
Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com>
---
V2: Add a fix tag and move the allocation to avoid its failure
in the declaration block as suggested by Dan Carpenter.
V1: Invoke the free_dentry_path before the return.
---
 fs/cifs/link.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index 1cbe7ec73728..970fcf2adb08 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -683,12 +683,16 @@ cifs_symlink(struct user_namespace *mnt_userns, struct inode *inode,
 	struct tcon_link *tlink;
 	struct cifs_tcon *pTcon;
 	const char *full_path;
-	void *page = alloc_dentry_path();
+	void *page;
 	struct inode *newinode = NULL;
 
 	if (unlikely(cifs_forced_shutdown(cifs_sb)))
 		return -EIO;
 
+	page = alloc_dentry_path();
+	if (!page)
+		return -ENOMEM;
+
 	xid = get_xid();
 
 	tlink = cifs_sb_tlink(cifs_sb);
-- 
2.17.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-04 15:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-04 15:38 [PATCH-V2] fs/cifs: Fix resource leak Khaled ROMDHANI

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).