From: kernel test robot <lkp@intel.com>
To: Paulo Alcantara <pc@cjr.nz>,
linux-cifs@vger.kernel.org, smfrench@gmail.com
Cc: kbuild-all@lists.01.org, Paulo Alcantara <pc@cjr.nz>
Subject: Re: [PATCH 2/3] cifs: handle multiple ip addresses per hostname
Date: Wed, 12 May 2021 02:47:57 +0800 [thread overview]
Message-ID: <202105120245.hE46sl5x-lkp@intel.com> (raw)
In-Reply-To: <20210511163609.11019-3-pc@cjr.nz>
[-- Attachment #1: Type: text/plain, Size: 5930 bytes --]
Hi Paulo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on cifs/for-next]
[also build test WARNING on v5.13-rc1 next-20210511]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Paulo-Alcantara/Support-multiple-ips-per-hostname/20210512-003751
base: git://git.samba.org/sfrench/cifs-2.6.git for-next
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/210f8e08a6bb153136929af6da6e0a7289ba5931
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Paulo-Alcantara/Support-multiple-ips-per-hostname/20210512-003751
git checkout 210f8e08a6bb153136929af6da6e0a7289ba5931
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs/cifs/connect.c: In function 'cifs_create_socket':
fs/cifs/connect.c:177:6: warning: variable 'slen' set but not used [-Wunused-but-set-variable]
177 | int slen, sfamily;
| ^~~~
fs/cifs/connect.c: In function 'next_dfs_prepath':
>> fs/cifs/connect.c:3540:1: warning: the frame size of 2516 bytes is larger than 1024 bytes [-Wframe-larger-than=]
3540 | }
| ^
fs/cifs/connect.c: In function 'do_dfs_failover':
fs/cifs/connect.c:3313:1: warning: the frame size of 2584 bytes is larger than 1024 bytes [-Wframe-larger-than=]
3313 | }
| ^
--
fs/cifs/dfs_cache.c: In function 'find_root_ses.isra.0':
>> fs/cifs/dfs_cache.c:1483:1: warning: the frame size of 2548 bytes is larger than 1024 bytes [-Wframe-larger-than=]
1483 | }
| ^
vim +3540 fs/cifs/connect.c
7efd081582619e Paulo Alcantara 2020-07-21 3497
ff2c54a04097de Paulo Alcantara 2021-02-24 3498 /* Set up next dfs prefix path in @dfs_path */
ff2c54a04097de Paulo Alcantara 2021-02-24 3499 static int next_dfs_prepath(struct cifs_sb_info *cifs_sb, struct smb3_fs_context *ctx,
7efd081582619e Paulo Alcantara 2020-07-21 3500 const unsigned int xid, struct TCP_Server_Info *server,
7efd081582619e Paulo Alcantara 2020-07-21 3501 struct cifs_tcon *tcon, char **dfs_path)
56c762eb9bee33 Paulo Alcantara 2018-11-14 3502 {
ff2c54a04097de Paulo Alcantara 2021-02-24 3503 char *path, *npath;
ff2c54a04097de Paulo Alcantara 2021-02-24 3504 int added_treename = is_tcon_dfs(tcon);
ff2c54a04097de Paulo Alcantara 2021-02-24 3505 int rc;
7efd081582619e Paulo Alcantara 2020-07-21 3506
3fa1c6d1b8f5c3 Ronnie Sahlberg 2020-12-09 3507 path = cifs_build_path_to_root(ctx, cifs_sb, tcon, added_treename);
7efd081582619e Paulo Alcantara 2020-07-21 3508 if (!path)
7efd081582619e Paulo Alcantara 2020-07-21 3509 return -ENOMEM;
ce558b0e17f8a6 Steve French 2018-05-31 3510
ff2c54a04097de Paulo Alcantara 2021-02-24 3511 rc = is_path_remote(cifs_sb, ctx, xid, server, tcon);
ff2c54a04097de Paulo Alcantara 2021-02-24 3512 if (rc == -EREMOTE) {
3fa1c6d1b8f5c3 Ronnie Sahlberg 2020-12-09 3513 struct smb3_fs_context v = {NULL};
7efd081582619e Paulo Alcantara 2020-07-21 3514 /* if @path contains a tree name, skip it in the prefix path */
7efd081582619e Paulo Alcantara 2020-07-21 3515 if (added_treename) {
66e7b09c731175 Ronnie Sahlberg 2020-11-05 3516 rc = smb3_parse_devname(path, &v);
7efd081582619e Paulo Alcantara 2020-07-21 3517 if (rc)
ff2c54a04097de Paulo Alcantara 2021-02-24 3518 goto out;
7efd081582619e Paulo Alcantara 2020-07-21 3519 npath = build_unc_path_to_root(&v, cifs_sb, true);
c741cba2cd1d14 Ronnie Sahlberg 2020-12-14 3520 smb3_cleanup_fs_context_contents(&v);
7efd081582619e Paulo Alcantara 2020-07-21 3521 } else {
3fa1c6d1b8f5c3 Ronnie Sahlberg 2020-12-09 3522 v.UNC = ctx->UNC;
7efd081582619e Paulo Alcantara 2020-07-21 3523 v.prepath = path + 1;
7efd081582619e Paulo Alcantara 2020-07-21 3524 npath = build_unc_path_to_root(&v, cifs_sb, true);
5072010ccf0592 Paulo Alcantara (SUSE 2019-03-19 3525) }
ff2c54a04097de Paulo Alcantara 2021-02-24 3526
7efd081582619e Paulo Alcantara 2020-07-21 3527 if (IS_ERR(npath)) {
7efd081582619e Paulo Alcantara 2020-07-21 3528 rc = PTR_ERR(npath);
ff2c54a04097de Paulo Alcantara 2021-02-24 3529 goto out;
a6b5058fafdf50 Aurelien Aptel 2016-05-25 3530 }
ff2c54a04097de Paulo Alcantara 2021-02-24 3531
7efd081582619e Paulo Alcantara 2020-07-21 3532 kfree(*dfs_path);
7efd081582619e Paulo Alcantara 2020-07-21 3533 *dfs_path = npath;
ff2c54a04097de Paulo Alcantara 2021-02-24 3534 rc = -EREMOTE;
1bfe73c258addc Igor Mammedov 2009-04-01 3535 }
1bfe73c258addc Igor Mammedov 2009-04-01 3536
ff2c54a04097de Paulo Alcantara 2021-02-24 3537 out:
7efd081582619e Paulo Alcantara 2020-07-21 3538 kfree(path);
7efd081582619e Paulo Alcantara 2020-07-21 3539 return rc;
4a367dc0443566 Paulo Alcantara 2018-11-14 @3540 }
4a367dc0443566 Paulo Alcantara 2018-11-14 3541
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68132 bytes --]
next prev parent reply other threads:[~2021-05-11 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 16:36 [PATCH 0/3] Support multiple ips per hostname Paulo Alcantara
2021-05-11 16:36 ` [PATCH 1/3] cifs: introduce smb3_options_for_each() helper Paulo Alcantara
2021-05-11 18:15 ` kernel test robot
2021-05-11 16:36 ` [PATCH 2/3] cifs: handle multiple ip addresses per hostname Paulo Alcantara
2021-05-11 18:47 ` kernel test robot
2021-05-11 18:47 ` kernel test robot [this message]
2021-05-11 16:36 ` [PATCH 3/3] cifs: fix find_root_ses() when refresing dfs cache Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105120245.hE46sl5x-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@cjr.nz \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).