linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: wenhuizhang <wenhui@gwmail.gwu.edu>
To: unlisted-recipients:; (no To-header on input)
Cc: wenhuizhang <wenhui@gwmail.gwu.edu>,
	Steve French <sfrench@samba.org>,
	linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] cifs: deadstore delete in deferred files
Date: Thu, 13 May 2021 12:53:23 -0400	[thread overview]
Message-ID: <20210513165323.16593-1-wenhui@gwmail.gwu.edu> (raw)
In-Reply-To: <20210509233327.22241-1-wenhui@gwmail.gwu.edu>

Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group).

line 741 struct cifsInodeInfo *cinode;
line 747 cinode = CIFS_I(d_inode(cfile->dentry));
could be deleted.

cinode on filesystem should not be deleted when files are closed, they are representations of some data fields on a physical disk, thus no further action is required.
The virtual inode on vfs will be handled by vfs automatically, and the denotation is inode, which is different from the cinode.

Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu>

---
 fs/cifs/misc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index 524dbdfb7184..801a5300f765 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -738,13 +738,11 @@ void
 cifs_close_all_deferred_files(struct cifs_tcon *tcon)
 {
 	struct cifsFileInfo *cfile;
-	struct cifsInodeInfo *cinode;
 	struct list_head *tmp;
 
 	spin_lock(&tcon->open_file_lock);
 	list_for_each(tmp, &tcon->openFileList) {
 		cfile = list_entry(tmp, struct cifsFileInfo, tlist);
-		cinode = CIFS_I(d_inode(cfile->dentry));
 		if (delayed_work_pending(&cfile->deferred))
 			mod_delayed_work(deferredclose_wq, &cfile->deferred, 0);
 	}
-- 
2.17.1


  parent reply	other threads:[~2021-05-13 16:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-09 23:33 [PATCH] Signed-off-by: wenhuizhang <wenhui@gwmail.gwu.edu> wenhuizhang
2021-05-11 16:32 ` Aurélien Aptel
     [not found]   ` <CAOSEQ1p80+JemJkj975ZTt5xw4XCPtOf2uBEvQs9RfW4UkDWXg@mail.gmail.com>
2021-05-11 18:06     ` Aurélien Aptel
2021-05-11 22:34 ` [PATCH] Deadstore detected by Lukas Bulwahn's CodeChecker Tool (ELISA group) wenhuizhang
2021-05-12  9:38   ` Aurélien Aptel
2021-05-13 16:53 ` wenhuizhang [this message]
2021-05-13 16:55 ` [PATCH] cifs: remove deadstore in cifs_close_all_deferred_files() wenhuizhang
2021-05-14 10:59   ` Aurélien Aptel
2021-05-14 16:01     ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210513165323.16593-1-wenhui@gwmail.gwu.edu \
    --to=wenhui@gwmail.gwu.edu \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).