From: "Darrick J. Wong" <djwong@kernel.org> To: Jan Kara <jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>, Dave Chinner <david@fromorbit.com>, ceph-devel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>, Damien Le Moal <damien.lemoal@wdc.com>, "Darrick J. Wong" <darrick.wong@oracle.com>, Jaegeuk Kim <jaegeuk@kernel.org>, Jeff Layton <jlayton@kernel.org>, Johannes Thumshirn <jth@kernel.org>, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>, Steve French <sfrench@samba.org>, Ted Tso <tytso@mit.edu>, Matthew Wilcox <willy@infradead.org> Subject: Re: [PATCH 02/13] documentation: Sync file_operations members with reality Date: Tue, 25 May 2021 13:43:13 -0700 [thread overview] Message-ID: <20210525204313.GL202121@locust> (raw) In-Reply-To: <20210525135100.11221-2-jack@suse.cz> On Tue, May 25, 2021 at 03:50:39PM +0200, Jan Kara wrote: > Sync listing of struct file_operations members with the real one in > fs.h. > > Signed-off-by: Jan Kara <jack@suse.cz> > --- > Documentation/filesystems/locking.rst | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst > index 1e894480115b..4ed2b22bd0a8 100644 > --- a/Documentation/filesystems/locking.rst > +++ b/Documentation/filesystems/locking.rst > @@ -506,6 +506,7 @@ prototypes:: > ssize_t (*write) (struct file *, const char __user *, size_t, loff_t *); > ssize_t (*read_iter) (struct kiocb *, struct iov_iter *); > ssize_t (*write_iter) (struct kiocb *, struct iov_iter *); > + int (*iopoll) (struct kiocb *kiocb, bool spin); > int (*iterate) (struct file *, struct dir_context *); > int (*iterate_shared) (struct file *, struct dir_context *); > __poll_t (*poll) (struct file *, struct poll_table_struct *); > @@ -518,12 +519,6 @@ prototypes:: > int (*fsync) (struct file *, loff_t start, loff_t end, int datasync); > int (*fasync) (int, struct file *, int); > int (*lock) (struct file *, int, struct file_lock *); > - ssize_t (*readv) (struct file *, const struct iovec *, unsigned long, > - loff_t *); > - ssize_t (*writev) (struct file *, const struct iovec *, unsigned long, > - loff_t *); > - ssize_t (*sendfile) (struct file *, loff_t *, size_t, read_actor_t, > - void __user *); > ssize_t (*sendpage) (struct file *, struct page *, int, size_t, > loff_t *, int); > unsigned long (*get_unmapped_area)(struct file *, unsigned long, > @@ -536,6 +531,14 @@ prototypes:: > size_t, unsigned int); > int (*setlease)(struct file *, long, struct file_lock **, void **); > long (*fallocate)(struct file *, int, loff_t, loff_t); > + void (*show_fdinfo)(struct seq_file *m, struct file *f); > + unsigned (*mmap_capabilities)(struct file *); > + ssize_t (*copy_file_range)(struct file *, loff_t, struct file *, > + loff_t, size_t, unsigned int); > + loff_t (*remap_file_range)(struct file *file_in, loff_t pos_in, > + struct file *file_out, loff_t pos_out, > + loff_t len, unsigned int remap_flags); Acked-by: Darrick J. Wong <djwong@kernel.org> The remap_file_range part looks correct to me. At a glance the others seem fine too, but I'm not as familiar with them... --D > + int (*fadvise)(struct file *, loff_t, loff_t, int); > > locking rules: > All may block. > -- > 2.26.2 >
next prev parent reply other threads:[~2021-05-25 20:43 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-25 13:50 [PATCH 0/13 v6] fs: Hole punch vs page cache filling races Jan Kara 2021-05-25 13:50 ` [PATCH 01/13] mm: Fix comments mentioning i_mutex Jan Kara 2021-05-25 13:50 ` [PATCH 02/13] documentation: Sync file_operations members with reality Jan Kara 2021-05-25 20:43 ` Darrick J. Wong [this message] 2021-05-25 13:50 ` [PATCH 03/13] mm: Protect operations adding pages to page cache with invalidate_lock Jan Kara 2021-05-25 21:01 ` Darrick J. Wong 2021-05-26 10:00 ` Jan Kara 2021-05-25 13:50 ` [PATCH 04/13] mm: Add functions to lock invalidate_lock for two mappings Jan Kara 2021-05-25 20:48 ` Darrick J. Wong 2021-05-26 10:07 ` Jan Kara 2021-05-26 12:11 ` Damien Le Moal 2021-05-26 13:45 ` Jan Kara 2021-05-26 15:25 ` Darrick J. Wong 2021-05-25 13:50 ` [PATCH 05/13] ext4: Convert to use mapping->invalidate_lock Jan Kara 2021-05-25 13:50 ` [PATCH 06/13] ext2: Convert to using invalidate_lock Jan Kara 2021-05-25 13:50 ` [PATCH 07/13] xfs: Convert to use invalidate_lock Jan Kara 2021-05-25 21:37 ` Darrick J. Wong 2021-05-26 10:18 ` Jan Kara 2021-05-26 15:32 ` Darrick J. Wong 2021-05-27 12:01 ` Jan Kara 2021-05-25 21:40 ` Dave Chinner 2021-05-26 10:20 ` Jan Kara 2021-05-26 13:42 ` Jan Kara 2021-05-25 13:50 ` [PATCH 08/13] xfs: Convert double locking of MMAPLOCK to use VFS helpers Jan Kara 2021-05-25 21:41 ` Darrick J. Wong 2021-05-25 13:50 ` [PATCH 09/13] zonefs: Convert to using invalidate_lock Jan Kara 2021-05-25 13:50 ` [PATCH 10/13] f2fs: " Jan Kara 2021-05-26 9:55 ` Chao Yu 2021-05-25 13:50 ` [PATCH 11/13] fuse: " Jan Kara 2021-05-25 13:50 ` [PATCH 12/13] ceph: Fix race between hole punch and page fault Jan Kara 2021-05-25 13:50 ` [PATCH 13/13] cifs: " Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210525204313.GL202121@locust \ --to=djwong@kernel.org \ --cc=ceph-devel@vger.kernel.org \ --cc=damien.lemoal@wdc.com \ --cc=darrick.wong@oracle.com \ --cc=david@fromorbit.com \ --cc=hch@infradead.org \ --cc=jack@suse.cz \ --cc=jaegeuk@kernel.org \ --cc=jlayton@kernel.org \ --cc=jth@kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-xfs@vger.kernel.org \ --cc=miklos@szeredi.hu \ --cc=sfrench@samba.org \ --cc=tytso@mit.edu \ --cc=willy@infradead.org \ --cc=yuchao0@huawei.com \ --subject='Re: [PATCH 02/13] documentation: Sync file_operations members with reality' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).