linux-next: build failure after merge of the cifs tree

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
allyesconfig) failed like this:

ld: fs/cifsd/spnego_negtokeninit.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): multiple definition of `spnego_negtokeninit_decoder'; fs/cifs/spnego_negtoken
init.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): first defined here
ld: fs/cifsd/asn1.o:(.opd+0xa8): multiple definition of `gssapi_this_mech'; fs/cifs/asn1.o:(.opd+0x18): first defined here
ld: fs/cifsd/asn1.o: in function `.gssapi_this_mech':
asn1.c:(.text.gssapi_this_mech+0x0): multiple definition of `.gssapi_this_mech'; fs/cifs/asn1.o:asn1.c:(.text.gssapi_this_mech+0x0): first defined here
ld: fs/cifsd/asn1.o:(.opd+0xc0): multiple definition of `neg_token_init_mech_type'; fs/cifs/asn1.o:(.opd+0x30): first defined here
ld: fs/cifsd/asn1.o: in function `.neg_token_init_mech_type':
asn1.c:(.text.neg_token_init_mech_type+0x0): multiple definition of `.neg_token_init_mech_type'; fs/cifs/asn1.o:asn1.c:(.text.neg_token_init_mech_type+0x0): first defined here

Caused by commit

  4a957ba6daf6 ("cifs: decoding negTokenInit with generic ASN1 decoder")

interacting with commit

  fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")

from the cifsd tree.

I have reverted that cifs tree commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Hyunchul Lee]

Hello,

2021년 6월 8일 (화) 오후 7:27, Stephen Rothwell <sfr@canb.auug.org.au>님이 작성:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> ld: fs/cifsd/spnego_negtokeninit.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): multiple definition of `spnego_negtokeninit_decoder'; fs/cifs/spnego_negtoken
> init.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): first defined here
> ld: fs/cifsd/asn1.o:(.opd+0xa8): multiple definition of `gssapi_this_mech'; fs/cifs/asn1.o:(.opd+0x18): first defined here
> ld: fs/cifsd/asn1.o: in function `.gssapi_this_mech':
> asn1.c:(.text.gssapi_this_mech+0x0): multiple definition of `.gssapi_this_mech'; fs/cifs/asn1.o:asn1.c:(.text.gssapi_this_mech+0x0): first defined here
> ld: fs/cifsd/asn1.o:(.opd+0xc0): multiple definition of `neg_token_init_mech_type'; fs/cifs/asn1.o:(.opd+0x30): first defined here
> ld: fs/cifsd/asn1.o: in function `.neg_token_init_mech_type':
> asn1.c:(.text.neg_token_init_mech_type+0x0): multiple definition of `.neg_token_init_mech_type'; fs/cifs/asn1.o:asn1.c:(.text.neg_token_init_mech_type+0x0): first defined here
>
> Caused by commit
>
>   4a957ba6daf6 ("cifs: decoding negTokenInit with generic ASN1 decoder")

I missed functions and structures generated from the ASN1 compiler
aren't static.

Steve, and Namjae,
We need to rename *.asn1 files and decoder's callback functions. Is it better
to change cifs's code?

Thanks,
Hyunchul

>
> interacting with commit
>
>   fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
>
> from the cifsd tree.
>
> I have reverted that cifs tree commit for today.
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

I will back out your patch to cifs.ko

On Tue, Jun 8, 2021 at 5:53 AM Hyunchul Lee <hyc.lee@gmail.com> wrote:
>
> Hello,
>
> 2021년 6월 8일 (화) 오후 7:27, Stephen Rothwell <sfr@canb.auug.org.au>님이 작성:
> >
> > Hi all,
> >
> > After merging the cifs tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > ld: fs/cifsd/spnego_negtokeninit.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): multiple definition of `spnego_negtokeninit_decoder'; fs/cifs/spnego_negtoken
> > init.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): first defined here
> > ld: fs/cifsd/asn1.o:(.opd+0xa8): multiple definition of `gssapi_this_mech'; fs/cifs/asn1.o:(.opd+0x18): first defined here
> > ld: fs/cifsd/asn1.o: in function `.gssapi_this_mech':
> > asn1.c:(.text.gssapi_this_mech+0x0): multiple definition of `.gssapi_this_mech'; fs/cifs/asn1.o:asn1.c:(.text.gssapi_this_mech+0x0): first defined here
> > ld: fs/cifsd/asn1.o:(.opd+0xc0): multiple definition of `neg_token_init_mech_type'; fs/cifs/asn1.o:(.opd+0x30): first defined here
> > ld: fs/cifsd/asn1.o: in function `.neg_token_init_mech_type':
> > asn1.c:(.text.neg_token_init_mech_type+0x0): multiple definition of `.neg_token_init_mech_type'; fs/cifs/asn1.o:asn1.c:(.text.neg_token_init_mech_type+0x0): first defined here
> >
> > Caused by commit
> >
> >   4a957ba6daf6 ("cifs: decoding negTokenInit with generic ASN1 decoder")
>
> I missed functions and structures generated from the ASN1 compiler
> aren't static.
>
> Steve, and Namjae,
> We need to rename *.asn1 files and decoder's callback functions. Is it better
> to change cifs's code?
>
> Thanks,
> Hyunchul
>
> >
> > interacting with commit
> >
> >   fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
> >
> > from the cifsd tree.
> >
> > I have reverted that cifs tree commit for today.
> >
> > --
> > Cheers,
> > Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from fs/smb/client/cifsglob.h:27,
                 from fs/smb/client/cifsfs.c:36:
fs/smb/client/../common/smb2pdu.h:291:9: error: unknown type name '_u8'
  291 |         _u8 BlobData[];
      |         ^~~

Caused by commit

  354c620afff2 ("smb311: additional compression flag defined in updated protocol spec")

I have used the cifs tree from next-20240319 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

Typo fixed - updated the patch in cifs-2.6.git for-next

On Tue, Mar 19, 2024 at 6:00 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from fs/smb/client/cifsglob.h:27,
>                  from fs/smb/client/cifsfs.c:36:
> fs/smb/client/../common/smb2pdu.h:291:9: error: unknown type name '_u8'
>   291 |         _u8 BlobData[];
>       |         ^~~
>
> Caused by commit
>
>   354c620afff2 ("smb311: additional compression flag defined in updated protocol spec")
>
> I have used the cifs tree from next-20240319 for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (x86_64
allmodconfig) failed like this:

fs/smb/client/connect.c: In function 'cifs_get_smb_ses':
fs/smb/client/connect.c:2293:49: error: passing argument 1 of 'load_nls' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
 2293 |         ses->local_nls = load_nls(ctx->local_nls->charset);
      |                                   ~~~~~~~~~~~~~~^~~~~~~~~
In file included from fs/smb/client/cifsproto.h:10,
                 from fs/smb/client/connect.c:37:
include/linux/nls.h:50:35: note: expected 'char *' but argument is of type 'const char *'
   50 | extern struct nls_table *load_nls(char *);
      |                                   ^~~~~~

Caused by commit

  46055407cd4a ("cifs: fix charset issue in reconnection")

I have used the cifs tree from next-20230719 for today.

It looks as though the parameter to load_nls could be made const safely
as it is just passed to try_then_request_module() passes it to
__request_module() which just passes it to vsnprintf() to construct the
module name.  There does not appear to be any maintainer for fs/nls ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

Winston had an updated version of the patch - just replaced it with
his updated one which does a cast to (char *)

          ses->local_nls = load_nls((char *)ctx->local_nls->charset);

But as he noted in an earlier email thread:
> Perhaps I should make a change to load_nls() to take a const char *
> instead of char *? If this make sense, I'll do it soon.

which is probably cleaner

On Wed, Jul 19, 2023 at 7:35 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> fs/smb/client/connect.c: In function 'cifs_get_smb_ses':
> fs/smb/client/connect.c:2293:49: error: passing argument 1 of 'load_nls' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
>  2293 |         ses->local_nls = load_nls(ctx->local_nls->charset);
>       |                                   ~~~~~~~~~~~~~~^~~~~~~~~
> In file included from fs/smb/client/cifsproto.h:10,
>                  from fs/smb/client/connect.c:37:
> include/linux/nls.h:50:35: note: expected 'char *' but argument is of type 'const char *'
>    50 | extern struct nls_table *load_nls(char *);
>       |                                   ^~~~~~
>
> Caused by commit
>
>   46055407cd4a ("cifs: fix charset issue in reconnection")
>
> I have used the cifs tree from next-20230719 for today.
>
> It looks as though the parameter to load_nls could be made const safely
> as it is just passed to try_then_request_module() passes it to
> __request_module() which just passes it to vsnprintf() to construct the
> module name.  There does not appear to be any maintainer for fs/nls ...
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

Re: linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Hi all,

On Wed, 19 Jul 2023 19:47:42 -0500 Steve French <smfrench@gmail.com> wrote:
>
> Winston had an updated version of the patch - just replaced it with
> his updated one which does a cast to (char *)
> 
>           ses->local_nls = load_nls((char *)ctx->local_nls->charset);
> 
> But as he noted in an earlier email thread:
> > Perhaps I should make a change to load_nls() to take a const char *
> > instead of char *? If this make sense, I'll do it soon.  
> 
> which is probably cleaner

s/probably/definitely/  ;-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Winston Wen]

On Thu, 20 Jul 2023 11:00:21 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> On Wed, 19 Jul 2023 19:47:42 -0500 Steve French <smfrench@gmail.com>
> wrote:
> >
> > Winston had an updated version of the patch - just replaced it with
> > his updated one which does a cast to (char *)
> > 
> >           ses->local_nls = load_nls((char
> > *)ctx->local_nls->charset);
> > 
> > But as he noted in an earlier email thread:
> > > Perhaps I should make a change to load_nls() to take a const char
> > > * instead of char *? If this make sense, I'll do it soon.  
> > 
> > which is probably cleaner
> 
> s/probably/definitely/  ;-)
> 

haha yes!

I'll make a small patch for this in the next cycle.

-- 
Thanks,
Winston

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from fs/cifs/dns_resolve.c:18:
fs/cifs/cifsglob.h: In function 'cifs_get_tlink':
fs/cifs/cifsglob.h:1169:14: error: passing argument 1 of 'atomic_inc' from incompatible pointer type [-Werror=incompatible-pointer-types]
 1169 |   atomic_inc(&tlink->tl_count);
      |              ^~~~~~~~~~~~~~~~
      |              |
      |              refcount_t * {aka struct refcount_struct *}
In file included from include/linux/atomic.h:82,
                 from include/linux/cpumask.h:13,
                 from include/linux/smp.h:13,
                 from include/linux/lockdep.h:14,
                 from include/linux/spinlock.h:62,
                 from include/linux/mmzone.h:8,
                 from include/linux/gfp.h:6,
                 from include/linux/slab.h:15,
                 from fs/cifs/dns_resolve.c:15:
include/linux/atomic/atomic-instrumented.h:179:22: note: expected 'atomic_t *' but argument is of type 'refcount_t *' {aka 'struct refcount_struct *'}
  179 | atomic_inc(atomic_t *v)
      |            ~~~~~~~~~~^

and lots more similar ...

Caused by commit

  ef242296e441 ("fs:cifs: convert from atomic_t to refcount_t on tlink->tl_count")

Please write, review, test (repeat) and, only then, publish. :-(

I have used the cifs tree from next-20211115 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

patch removed pending author fix

On Mon, Nov 15, 2021 at 4:17 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from fs/cifs/dns_resolve.c:18:
> fs/cifs/cifsglob.h: In function 'cifs_get_tlink':
> fs/cifs/cifsglob.h:1169:14: error: passing argument 1 of 'atomic_inc' from incompatible pointer type [-Werror=incompatible-pointer-types]
>  1169 |   atomic_inc(&tlink->tl_count);
>       |              ^~~~~~~~~~~~~~~~
>       |              |
>       |              refcount_t * {aka struct refcount_struct *}
> In file included from include/linux/atomic.h:82,
>                  from include/linux/cpumask.h:13,
>                  from include/linux/smp.h:13,
>                  from include/linux/lockdep.h:14,
>                  from include/linux/spinlock.h:62,
>                  from include/linux/mmzone.h:8,
>                  from include/linux/gfp.h:6,
>                  from include/linux/slab.h:15,
>                  from fs/cifs/dns_resolve.c:15:
> include/linux/atomic/atomic-instrumented.h:179:22: note: expected 'atomic_t *' but argument is of type 'refcount_t *' {aka 'struct refcount_struct *'}
>   179 | atomic_inc(atomic_t *v)
>       |            ~~~~~~~~~~^
>
> and lots more similar ...
>
> Caused by commit
>
>   ef242296e441 ("fs:cifs: convert from atomic_t to refcount_t on tlink->tl_count")
>
> Please write, review, test (repeat) and, only then, publish. :-(
>
> I have used the cifs tree from next-20211115 for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

<stdin>:1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp]
fs/cifs/connect.c: In function 'clean_demultiplex_info':
fs/cifs/connect.c:841:2: error: stray '#' in program
  841 | +#ifdef CONFIG_CIFS_DFS_UPCALL
      |  ^
fs/cifs/connect.c:841:3: error: 'ifdef' undeclared (first use in this function)
  841 | +#ifdef CONFIG_CIFS_DFS_UPCALL
      |   ^~~~~
fs/cifs/connect.c:841:3: note: each undeclared identifier is reported only once for each function it appears in
fs/cifs/connect.c:841:8: error: expected ';' before 'CONFIG_CIFS_DFS_UPCALL'
  841 | +#ifdef CONFIG_CIFS_DFS_UPCALL
      |        ^~~~~~~~~~~~~~~~~~~~~~~
      |        ;
fs/cifs/connect.c:843:15: error: 'struct TCP_Server_Info' has no member named 'leaf_fullpath'
  843 | + kfree(server->leaf_fullpath);
      |               ^~
fs/cifs/connect.c:844:2: error: stray '#' in program
  844 | +#endif
      |  ^
fs/cifs/connect.c:844:3: error: 'endif' undeclared (first use in this function); did you mean 'gendisk'?
  844 | +#endif
      |   ^~~~~
      |   gendisk
fs/cifs/connect.c:844:8: error: expected ';' before 'kfree'
  844 | +#endif
      |        ^
      |        ;
  845 |  kfree(server);
      |  ~~~~~  

Caused by commit

  58b90aa95977 ("cifs: support nested dfs links over reconnect")

I have used the cifs tree from next-20211110 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

I had a cut-n-paste error in updating one of Paulo's patches this
morning.  Fixed now in cifs-2.6.git for-next

On Wed, Nov 10, 2021 at 3:57 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> <stdin>:1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp]
> fs/cifs/connect.c: In function 'clean_demultiplex_info':
> fs/cifs/connect.c:841:2: error: stray '#' in program
>   841 | +#ifdef CONFIG_CIFS_DFS_UPCALL
>       |  ^
> fs/cifs/connect.c:841:3: error: 'ifdef' undeclared (first use in this function)
>   841 | +#ifdef CONFIG_CIFS_DFS_UPCALL
>       |   ^~~~~
> fs/cifs/connect.c:841:3: note: each undeclared identifier is reported only once for each function it appears in
> fs/cifs/connect.c:841:8: error: expected ';' before 'CONFIG_CIFS_DFS_UPCALL'
>   841 | +#ifdef CONFIG_CIFS_DFS_UPCALL
>       |        ^~~~~~~~~~~~~~~~~~~~~~~
>       |        ;
> fs/cifs/connect.c:843:15: error: 'struct TCP_Server_Info' has no member named 'leaf_fullpath'
>   843 | + kfree(server->leaf_fullpath);
>       |               ^~
> fs/cifs/connect.c:844:2: error: stray '#' in program
>   844 | +#endif
>       |  ^
> fs/cifs/connect.c:844:3: error: 'endif' undeclared (first use in this function); did you mean 'gendisk'?
>   844 | +#endif
>       |   ^~~~~
>       |   gendisk
> fs/cifs/connect.c:844:8: error: expected ';' before 'kfree'
>   844 | +#endif
>       |        ^
>       |        ;
>   845 |  kfree(server);
>       |  ~~~~~
>
> Caused by commit
>
>   58b90aa95977 ("cifs: support nested dfs links over reconnect")
>
> I have used the cifs tree from next-20211110 for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/cifs/connect.c: In function 'cifs_find_tcon':
fs/cifs/connect.c:3378:45: error: 'struct cifs_tcon' has no member named 'dfs_path'
 3378 |   if (!match_tcon(tcon, volume_info) || tcon->dfs_path)
      |                                             ^~

Caused by commit

  f73409e5babd ("cifs: do not share tcons with DFS")

# CONFIG_CIFS_DFS_UPCALL is not set

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

Fixed.  updated cifs-2.6.git for-next with Paulo's respun version of
two patches to address the missing #ifdef

Should be ok now.

On Wed, Apr 22, 2020 at 7:31 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/cifs/connect.c: In function 'cifs_find_tcon':
> fs/cifs/connect.c:3378:45: error: 'struct cifs_tcon' has no member named 'dfs_path'
>  3378 |   if (!match_tcon(tcon, volume_info) || tcon->dfs_path)
>       |                                             ^~
>
> Caused by commit
>
>   f73409e5babd ("cifs: do not share tcons with DFS")
>
> # CONFIG_CIFS_DFS_UPCALL is not set
>
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/cifs/smb2ops.c: In function 'smb311_queryfs':
fs/cifs/smb2ops.c:1543:11: error: 'struct cifs_tcon' has no member named 'posix_extensions'
  if (!tcon->posix_extensions)
           ^~
At top level:
fs/cifs/smb2ops.c:1534:1: warning: 'smb311_queryfs' defined but not used [-Wunused-function]
 smb311_queryfs(const unsigned int xid, struct cifs_tcon *tcon,
 ^~~~~~~~~~~~~~

Caused by commit

   ("smb3: add support for statfs for smb3.1.1 posix extensions")

# CONFIG_CIFS_SMB311 is not set

I have used the cifs tree from next-20180622 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

Should be ok now - It was missing an update that Aurelien and I worked
on for that patch - so I backed that patch out.   It was also
suggested that that Kconfig parm and #ifdef be removed since SMB3.11
is strongly recommended to be set (which would have avoided this as
well) and will be added to the default list of dialects in the future.
On Sun, Jun 24, 2018 at 6:15 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/cifs/smb2ops.c: In function 'smb311_queryfs':
> fs/cifs/smb2ops.c:1543:11: error: 'struct cifs_tcon' has no member named 'posix_extensions'
>   if (!tcon->posix_extensions)
>            ^~
> At top level:
> fs/cifs/smb2ops.c:1534:1: warning: 'smb311_queryfs' defined but not used [-Wunused-function]
>  smb311_queryfs(const unsigned int xid, struct cifs_tcon *tcon,
>  ^~~~~~~~~~~~~~
>
> Caused by commit
>
>    ("smb3: add support for statfs for smb3.1.1 posix extensions")
>
> # CONFIG_CIFS_SMB311 is not set
>
> I have used the cifs tree from next-20180622 for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/cifs/connect.c: In function 'cifs_mount':
fs/cifs/connect.c:3967:10: error: 'struct cifs_tcon' has no member named 'posix_extensions'
  if (tcon->posix_extensions)
          ^~

Caused by commit

  12a778233fc4 ("smb3: Add posix create context for smb3.11 posix mounts")

# CONFIG_CIFS_SMB311 is not set

I have used the cifs tree from next-20180531 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

sorry about that - missing

#ifdef CONFIG_CIFS_SMB311
#endif

around that.  It is fixed now and repushed to cifs-2.6.git for-next

otherwise requires SMB311 to be enabled in the build

On Thu, May 31, 2018 at 7:09 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/cifs/connect.c: In function 'cifs_mount':
> fs/cifs/connect.c:3967:10: error: 'struct cifs_tcon' has no member named 'posix_extensions'
>   if (tcon->posix_extensions)
>           ^~
>
> Caused by commit
>
>   12a778233fc4 ("smb3: Add posix create context for smb3.11 posix mounts")
>
> # CONFIG_CIFS_SMB311 is not set
>
> I have used the cifs tree from next-20180531 for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/cifs/smb2transport.c: In function 'generate_smb311signingkey':
fs/cifs/smb2transport.c:403:27: error: 'struct cifs_ses' has no member named 'preauth_sha_hash'
  d->context.iov_base = ses->preauth_sha_hash;
                           ^
fs/cifs/smb2transport.c:409:27: error: 'struct cifs_ses' has no member named 'preauth_sha_hash' 
  d->context.iov_base = ses->preauth_sha_hash;
                           ^
fs/cifs/smb2transport.c:415:27: error: 'struct cifs_ses' has no member named 'preauth_sha_hash' 
  d->context.iov_base = ses->preauth_sha_hash;
                           ^

Caused by commit

  a679c0e328c9 ("Fix encryption labels and lengths for SMB3.1.1")

This build has

# CONFIG_CIFS_SMB311 is not set

I have used the version of the cifs tree from next-20170922 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

fixed - repushed to cifs-2.6.git for-next

On Mon, Sep 25, 2017 at 7:51 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/cifs/smb2transport.c: In function 'generate_smb311signingkey':
> fs/cifs/smb2transport.c:403:27: error: 'struct cifs_ses' has no member named 'preauth_sha_hash'
>   d->context.iov_base = ses->preauth_sha_hash;
>                            ^
> fs/cifs/smb2transport.c:409:27: error: 'struct cifs_ses' has no member named 'preauth_sha_hash'
>   d->context.iov_base = ses->preauth_sha_hash;
>                            ^
> fs/cifs/smb2transport.c:415:27: error: 'struct cifs_ses' has no member named 'preauth_sha_hash'
>   d->context.iov_base = ses->preauth_sha_hash;
>                            ^
>
> Caused by commit
>
>   a679c0e328c9 ("Fix encryption labels and lengths for SMB3.1.1")
>
> This build has
>
> # CONFIG_CIFS_SMB311 is not set
>
> I have used the version of the cifs tree from next-20170922 for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/cifs/connect.c: In function 'cifs_find_tcon':
fs/cifs/connect.c:2610:11: error: 'struct cifs_tcon' has no member named 'snapshot_time'
   if (tcon->snapshot_time != volume_info->snapshot_time)
           ^
fs/cifs/connect.c: In function 'cifs_get_tcon':
fs/cifs/connect.c:2681:8: error: 'struct cifs_tcon' has no member named 'snapshot_time'
    tcon->snapshot_time = volume_info->snapshot_time;
        ^

Caused by commit

  36c659cf9241 ("SMB3: parsing for new snapshot timestamp mount parm")

CONFIG_CIFS_SMB2 is not set for this build ...

I have used the cifs tree from next-20161129 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

Commit fixed to handle the ifdef CONFIG_CIFS_SMB2 disabled problem you
noted, and repushed to my for-next branch. Thx for pointing this out.

On Tue, Nov 29, 2016 at 4:27 PM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/cifs/connect.c: In function 'cifs_find_tcon':
> fs/cifs/connect.c:2610:11: error: 'struct cifs_tcon' has no member named 'snapshot_time'
>    if (tcon->snapshot_time != volume_info->snapshot_time)
>            ^
> fs/cifs/connect.c: In function 'cifs_get_tcon':
> fs/cifs/connect.c:2681:8: error: 'struct cifs_tcon' has no member named 'snapshot_time'
>     tcon->snapshot_time = volume_info->snapshot_time;
>         ^
>
> Caused by commit
>
>   36c659cf9241 ("SMB3: parsing for new snapshot timestamp mount parm")
>
> CONFIG_CIFS_SMB2 is not set for this build ...
>
> I have used the cifs tree from next-20161129 for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/cifs/Kconfig:3: syntax error
fs/Kconfig:244: missing end statement for this entry
fs/Kconfig:5: missing end statement for this entry
fs/cifs/Kconfig:2: invalid statement
fs/cifs/Kconfig:3: unexpected option "depends"
fs/cifs/Kconfig:4: unexpected option "select"
fs/cifs/Kconfig:5: unexpected option "select"
fs/cifs/Kconfig:6: unexpected option "select"
fs/cifs/Kconfig:7: unexpected option "select"
fs/cifs/Kconfig:8: unexpected option "select"
fs/cifs/Kconfig:9: unexpected option "select"
fs/cifs/Kconfig:10: unexpected option "select"
fs/cifs/Kconfig:11: unexpected option "select"
fs/cifs/Kconfig:12: unexpected option "select"
fs/cifs/Kconfig:13: invalid statement
fs/cifs/Kconfig:14: unknown statement "This"
fs/cifs/Kconfig:15: unknown statement "CIFS"
fs/cifs/Kconfig:16: unknown statement "SMB"
fs/cifs/Kconfig:17: unknown statement "PC"
fs/cifs/Kconfig:18: unknown statement "file"
fs/cifs/Kconfig:19: unknown statement "and"
fs/cifs/Kconfig:20: unknown statement "server"
fs/cifs/Kconfig:21: unknown statement "support"
fs/cifs/Kconfig:22: unknown statement "well"
fs/cifs/Kconfig:25: syntax error
fs/cifs/Kconfig:24: unknown statement "The"
fs/cifs/Kconfig:25: unknown statement "client"
fs/cifs/Kconfig:26: unknown statement "support"
fs/cifs/Kconfig:27: unknown statement "session"
fs/cifs/Kconfig:28: unknown statement "safe"
fs/cifs/Kconfig:29: unknown statement "signing"
fs/cifs/Kconfig:30: unknown statement "If"
fs/Kconfig:274: unexpected end statement
fs/Kconfig:279: unexpected end statement

Caused by commit 12f3f9b7c80c ("Remove sparse warning in cifsfs.c").
Please, please build test after doing updates and before publishing your
tree.

I have used the cifs tree from next-20120803 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

On Sun, Aug 5, 2012 at 7:48 PM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/cifs/Kconfig:3: syntax error
> fs/Kconfig:244: missing end statement for this entry
<snip>
>
> Caused by commit 12f3f9b7c80c ("Remove sparse warning in cifsfs.c").
> Please, please build test after doing updates and before publishing your
> tree.
>
> I have used the cifs tree from next-20120803 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org

Fixed.  The corrupted commit came after a build test caught a few
sparse warnings - forgot to rerun the build test though after fixing
the warning (I had multiple
Kconfigs I build test - fs/cifs/Kconfig obviously should not have changed)



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/cifs/connect.c: In function 'cifs_set_vol_auth':
fs/cifs/connect.c:3843:17: error: 'CIFSSEC_MUST_LANMAN' undeclared (first use in this function)
fs/cifs/connect.c:3843:17: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit 8a8798a5ff90 ("cifs: fetch credentials out of keyring
for non-krb5 auth multiuser mounts").

I have used the cifs tree from next-20120118 for today.
-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

I already fixed that and merged it into cifs-2.6.git.   If you repull
you will get the fix for that.

On Wed, Jan 18, 2012 at 6:01 PM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/cifs/connect.c: In function 'cifs_set_vol_auth':
> fs/cifs/connect.c:3843:17: error: 'CIFSSEC_MUST_LANMAN' undeclared (first use in this function)
> fs/cifs/connect.c:3843:17: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit 8a8798a5ff90 ("cifs: fetch credentials out of keyring
> for non-krb5 auth multiuser mounts").
>
> I have used the cifs tree from next-20120118 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr-3FnU+UHB4dPYtjvyW6yDsg@public.gmane.org.org.au
> http://www.canb.auug.org.au/~sfr/



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
iseries_defconfig) failed like this:

fs/cifs/transport.c: In function 'wait_for_response':
fs/cifs/transport.c:328: error: implicit declaration of function 'wait_event_freezekillable'

Caused by commit f06ac72e9291 ("cifs, freezer: add
wait_event_freezekillable and have cifs use it").  In this config,
CONFIG_FREEZER is not set.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

Am fixing it now.  Jeff missed a stub for the non-freezer case.

diff --git a/include/linux/freezer.h b/include/linux/freezer.h
index a155561..cd2d55b 100644
--- a/include/linux/freezer.h
+++ b/include/linux/freezer.h
@@ -202,6 +202,8 @@ static inline void set_freezable_with_signal(void) {}

 #define wait_event_freezable_timeout(wq, condition, timeout)		\
 		wait_event_interruptible_timeout(wq, condition, timeout)
+#define #define wait_event_freezekillable(wq, condition)		\
+		wait_event_killable(wq, condition)


On Tue, Oct 25, 2011 at 8:59 AM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> iseries_defconfig) failed like this:
>
> fs/cifs/transport.c: In function 'wait_for_response':
> fs/cifs/transport.c:328: error: implicit declaration of function 'wait_event_freezekillable'
>
> Caused by commit f06ac72e9291 ("cifs, freezer: add
> wait_event_freezekillable and have cifs use it").  In this config,
> CONFIG_FREEZER is not set.
> --
> Cheers,
> Stephen Rothwell                    sfr-3FnU+UHB4dPYtjvyW6yDsg@public.gmane.org.org.au
> http://www.canb.auug.org.au/~sfr/
>



-- 
Thanks,

Steve

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

Corrected typo in proposed patch and merged to cifs-2.6.git

On Tue, Oct 25, 2011 at 9:51 AM, Steve French <smfrench@gmail.com> wrote:
> Am fixing it now.  Jeff missed a stub for the non-freezer case.
>
> diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> index a155561..cd2d55b 100644
> --- a/include/linux/freezer.h
> +++ b/include/linux/freezer.h
> @@ -202,6 +202,8 @@ static inline void set_freezable_with_signal(void) {}
>
>  #define wait_event_freezable_timeout(wq, condition, timeout)           \
>                wait_event_interruptible_timeout(wq, condition, timeout)
> +#define #define wait_event_freezekillable(wq, condition)               \
> +               wait_event_killable(wq, condition)
>
>
> On Tue, Oct 25, 2011 at 8:59 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi all,
>>
>> After merging the cifs tree, today's linux-next build (powerpc
>> iseries_defconfig) failed like this:
>>
>> fs/cifs/transport.c: In function 'wait_for_response':
>> fs/cifs/transport.c:328: error: implicit declaration of function 'wait_event_freezekillable'
>>
>> Caused by commit f06ac72e9291 ("cifs, freezer: add
>> wait_event_freezekillable and have cifs use it").  In this config,
>> CONFIG_FREEZER is not set.
>> --
>> Cheers,
>> Stephen Rothwell                    sfr@canb.auug.org.au
>> http://www.canb.auug.org.au/~sfr/
>>
>
>
>
> --
> Thanks,
>
> Steve
>



-- 
Thanks,

Steve

Re: linux-next: build failure after merge of the cifs tree

[Jeff Layton]

On Tue, 25 Oct 2011 10:05:52 -0500
Steve French <smfrench@gmail.com> wrote:

> Corrected typo in proposed patch and merged to cifs-2.6.git
> 

Patch looks fine. Thanks for fixing it...

Reviewed-by: Jeff Layton <jlayton@redhat.com>

Re: linux-next: build failure after merge of the cifs tree

[Jeff Layton]

On Tue, 25 Oct 2011 09:51:37 -0500
Steve French <smfrench@gmail.com> wrote:

> Am fixing it now.  Jeff missed a stub for the non-freezer case.
> 
> diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> index a155561..cd2d55b 100644
> --- a/include/linux/freezer.h
> +++ b/include/linux/freezer.h
> @@ -202,6 +202,8 @@ static inline void set_freezable_with_signal(void) {}
> 
>  #define wait_event_freezable_timeout(wq, condition, timeout)		\
>  		wait_event_interruptible_timeout(wq, condition, timeout)
> +#define #define wait_event_freezekillable(wq, condition)		\
> +		wait_event_killable(wq, condition)
> 
> 

Yep, silly oversight on my part -- sorry about that. That's exactly
what I was planning to do, so you can add my acked-by on that patch...

Thanks,
Jeff


> On Tue, Oct 25, 2011 at 8:59 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > After merging the cifs tree, today's linux-next build (powerpc
> > iseries_defconfig) failed like this:
> >
> > fs/cifs/transport.c: In function 'wait_for_response':
> > fs/cifs/transport.c:328: error: implicit declaration of function 'wait_event_freezekillable'
> >
> > Caused by commit f06ac72e9291 ("cifs, freezer: add
> > wait_event_freezekillable and have cifs use it").  In this config,
> > CONFIG_FREEZER is not set.
> > --
> > Cheers,
> > Stephen Rothwell                    sfr@canb.auug.org.au
> > http://www.canb.auug.org.au/~sfr/
> >
> 
> 
> 


-- 
Jeff Layton <jlayton@redhat.com>

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: ".set_cifs_acl" [fs/cifs/cifs.ko] undefined!

Caused by commit 30091b5571eb ("cifs: Allow to set extended attribute
cifs_acl (try #2)").

I have used the cifs tree from next-20110309 for today.
-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

Fixed in cifs-2.6.git now. Trivial.   Shirish missed an ifdef.


On Wed, Mar 9, 2011 at 6:43 PM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ERROR: ".set_cifs_acl" [fs/cifs/cifs.ko] undefined!
>
> Caused by commit 30091b5571eb ("cifs: Allow to set extended attribute
> cifs_acl (try #2)").
>
> I have used the cifs tree from next-20110309 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr-3FnU+UHB4dPYtjvyW6yDsg@public.gmane.org.org.au
> http://www.canb.auug.org.au/~sfr/
>



-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/cifs/file.c: In function 'cifs_writepages':
fs/cifs/file.c:1365: error: 'struct cifs_sb_info' has no member named 'tcon'
fs/cifs/file.c:1365: error: 'struct cifs_sb_info' has no member named 'tcon'
fs/cifs/file.c:1366: error: 'struct cifs_sb_info' has no member named 'tcon'

Caused by commit 2eff6be391f00d606b43e60d9727b70c44917b7e ("cifs:
temporarily rename cifs_sb->tcon to ptcon to catch stragglers").

Really, such testing code should not be in linux-next ...

I have used the cifs tree fomr next-20100921 for today.
-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

Sorry about that - we merged one of Jeff's patches (in a series) out
of order by three hours due to review comments.  Should be ok now -
verifying.

On Wed, Sep 22, 2010 at 8:20 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/cifs/file.c: In function 'cifs_writepages':
> fs/cifs/file.c:1365: error: 'struct cifs_sb_info' has no member named 'tcon'
> fs/cifs/file.c:1365: error: 'struct cifs_sb_info' has no member named 'tcon'
> fs/cifs/file.c:1366: error: 'struct cifs_sb_info' has no member named 'tcon'
>
> Caused by commit 2eff6be391f00d606b43e60d9727b70c44917b7e ("cifs:
> temporarily rename cifs_sb->tcon to ptcon to catch stragglers").
>
> Really, such testing code should not be in linux-next ...
>
> I have used the cifs tree fomr next-20100921 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>



-- 
Thanks,

Steve

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

On Wed, Sep 22, 2010 at 8:32 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Sorry about that - we merged one of Jeff's patches (in a series) out
> of order by three hours due to review comments.  Should be ok now -
> verifying.

Built fine.   Will try to merge the rest in order.


-- 
Thanks,

Steve

linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 6527 bytes --]

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/dns_resolver/dns_key.c: In function 'dns_resolver_instantiate':
net/dns_resolver/dns_key.c:70: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c:70: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c:99: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c:128: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c:136: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c:143: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c:144: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c:149: error: implicit declaration of function 'key_payload_reserve'
net/dns_resolver/dns_key.c:162: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c: In function 'dns_resolver_match':
net/dns_resolver/dns_key.c:178: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c: In function 'dns_resolver_describe':
net/dns_resolver/dns_key.c:211: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c:213: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c:217: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_key.c: At top level:
net/dns_resolver/dns_key.c:220: error: variable 'key_type_dns_resolver' has initializer but incomplete type
net/dns_resolver/dns_key.c:221: error: unknown field 'name' specified in initializer
net/dns_resolver/dns_key.c:221: warning: excess elements in struct initializer
net/dns_resolver/dns_key.c:221: warning: (near initialization for 'key_type_dns_resolver')
net/dns_resolver/dns_key.c:222: error: unknown field 'instantiate' specified in initializer
net/dns_resolver/dns_key.c:222: warning: excess elements in struct initializer
net/dns_resolver/dns_key.c:222: warning: (near initialization for 'key_type_dns_resolver')
net/dns_resolver/dns_key.c:223: error: unknown field 'match' specified in initializer
net/dns_resolver/dns_key.c:223: warning: excess elements in struct initializer
net/dns_resolver/dns_key.c:223: warning: (near initialization for 'key_type_dns_resolver')
net/dns_resolver/dns_key.c:224: error: unknown field 'revoke' specified in initializer
net/dns_resolver/dns_key.c:224: warning: excess elements in struct initializer
net/dns_resolver/dns_key.c:224: warning: (near initialization for 'key_type_dns_resolver')
net/dns_resolver/dns_key.c:225: error: unknown field 'destroy' specified in initializer
net/dns_resolver/dns_key.c:225: warning: excess elements in struct initializer
net/dns_resolver/dns_key.c:225: warning: (near initialization for 'key_type_dns_resolver')
net/dns_resolver/dns_key.c:226: error: unknown field 'describe' specified in initializer
net/dns_resolver/dns_key.c:226: warning: excess elements in struct initializer
net/dns_resolver/dns_key.c:226: warning: (near initialization for 'key_type_dns_resolver')
net/dns_resolver/dns_key.c:227: error: unknown field 'read' specified in initializer
net/dns_resolver/dns_key.c:227: warning: excess elements in struct initializer
net/dns_resolver/dns_key.c:227: warning: (near initialization for 'key_type_dns_resolver')
net/dns_resolver/dns_key.c: In function 'init_dns_resolver':
net/dns_resolver/dns_key.c:237: error: invalid use of undefined type 'struct key_type'
net/dns_resolver/dns_key.c:249: error: implicit declaration of function 'key_alloc'
net/dns_resolver/dns_key.c:249: error: 'key_type_keyring' undeclared (first use in this function)
net/dns_resolver/dns_key.c:249: error: (Each undeclared identifier is reported only once
net/dns_resolver/dns_key.c:249: error: for each function it appears in.)
net/dns_resolver/dns_key.c:250: error: 'KEY_POS_ALL' undeclared (first use in this function)
net/dns_resolver/dns_key.c:250: error: 'KEY_POS_SETATTR' undeclared (first use in this function)
net/dns_resolver/dns_key.c:251: error: 'KEY_USR_VIEW' undeclared (first use in this function)
net/dns_resolver/dns_key.c:251: error: 'KEY_USR_READ' undeclared (first use in this function)
net/dns_resolver/dns_key.c:252: error: 'KEY_ALLOC_NOT_IN_QUOTA' undeclared (first use in this function)
net/dns_resolver/dns_key.c:258: error: implicit declaration of function 'key_instantiate_and_link'
net/dns_resolver/dns_key.c:262: error: implicit declaration of function 'register_key_type'
net/dns_resolver/dns_key.c:268: error: 'struct cred' has no member named 'thread_keyring'
net/dns_resolver/dns_key.c:269: error: 'struct cred' has no member named 'jit_keyring'
net/dns_resolver/dns_key.c: In function 'exit_dns_resolver':
net/dns_resolver/dns_key.c:285: error: implicit declaration of function 'unregister_key_type'
net/dns_resolver/dns_key.c:288: error: invalid use of undefined type 'struct key_type'
net/dns_resolver/dns_query.c: In function 'dns_query':
net/dns_resolver/dns_query.c:124: error: implicit declaration of function 'request_key'
net/dns_resolver/dns_query.c:124: warning: assignment makes pointer from integer without a cast
net/dns_resolver/dns_query.c:132: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_query.c:133: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_query.c:133: error: 'KEY_USR_VIEW' undeclared (first use in this function)
net/dns_resolver/dns_query.c:133: error: (Each undeclared identifier is reported only once
net/dns_resolver/dns_query.c:133: error: for each function it appears in.)
net/dns_resolver/dns_query.c:140: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_query.c:144: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_query.c:155: error: dereferencing pointer to incomplete type
net/dns_resolver/dns_query.c:159: error: dereferencing pointer to incomplete type

Presumably this code has not been built on powerpc before.  Casued by
commit 1a4240f4764ac78adbf4b0ebb49b3bd8c72ffa11 ("DNS: Separate out CIFS
DNS Resolver code") (and the build was probably enabled by commit
c2e8139c9f797baa46515af6d350c51823736cbb ("NFS: Use kernel DNS resolver
[ver #2]").

I can only imagine that linux/key.h is included indirectly on x86.

I have used the version of cifs tree from next-20100811 for today.
-- 
Cheers,
Stephen Rothwell                    sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

On Wed, Aug 11, 2010 at 10:17 PM, Stephen Rothwell <sfr-3FnU+UHB4dM8huWDy8Hlbg@public.gmane.orgu> wrote:
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> net/dns_resolver/dns_key.c: In function 'dns_resolver_instantiate':
> net/dns_resolver/dns_key.c:70: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c:70: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c:99: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c:128: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c:136: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c:143: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c:144: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c:149: error: implicit declaration of function 'key_payload_reserve'
> net/dns_resolver/dns_key.c:162: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c: In function 'dns_resolver_match':
> net/dns_resolver/dns_key.c:178: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c: In function 'dns_resolver_describe':
> net/dns_resolver/dns_key.c:211: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c:213: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c:217: error: dereferencing pointer to incomplete type
> net/dns_resolver/dns_key.c: At top level:
> net/dns_resolver/dns_key.c:220: error: variable 'key_type_dns_resolver' has initializer but incomplete type
> net/dns_resolver/dns_key.c:221: error: unknown field 'name' specified in initializer
> net/dns_resolver/dns_key.c:221: warning: excess elements in struct initializer
> net/dns_resolver/dns_key.c:221: warning: (near initialization for 'key_type_dns_resolver')
> net/dns_resolver/dns_key.c:222: error: unknown field 'instantiate' specified in initializer
> net/dns_resolver/dns_key.c:222: warning: excess elements in struct initializer
> net/dns_resolver/dns_key.c:222: warning: (near initialization for 'key_type_dns_resolver')
> net/dns_resolver/dns_key.c:223: error: unknown field 'match' specified in initializer
> net/dns_resolver/dns_key.c:223: warning: excess elements in struct initializer
> net/dns_resolver/dns_key.c:223: warning: (near initialization for 'key_type_dns_resolver')
> net/dns_resolver/dns_key.c:224: error: unknown field 'revoke' specified in initializer
> net/dns_resolver/dns_key.c:224: warning: excess elements in struct initializer
> net/dns_resolver/dns_key.c:224: warning: (near initialization for 'key_type_dns_resolver')
> net/dns_resolver/dns_key.c:225: error: unknown field 'destroy' specified in initializer
> net/dns_resolver/dns_key.c:225: warning: excess elements in struct initializer
> net/dns_resolver/dns_key.c:225: warning: (near initialization for 'key_type_dns_resolver')
> net/dns_resolver/dns_key.c:226: error: unknown field 'describe' specified in initializer
> net/dns_resolver/dns_key.c:226: warning: excess elements in struct initializer
> net/dns_resolver/dns_key.c:226: warning: (near initialization for 'key_type_dns_resolver')
> net/dns_resolver/dns_key.c:227: error: unknown field 'read' specified in initializer
> net/dns_resolver/dns_key.c:227: warning: excess elements in struct initializer
> net/dns_resolver/dns_key.c:227: warning: (near initialization for 'key_type_dns_resolver')
> net/dns_resolver/dns_key.c: In function 'init_dns_resolver':
> net/dns_resolver/dns_key.c:237: error: invalid use of undefined type 'struct key_type'
> net/dns_resolver/dns_key.c:249: error: implicit declaration of function 'key_alloc'
> net/dns_resolver/dns_key.c:249: error: 'key_type_keyring' undeclared (first use in this function)
> net/dns_resolver/dns_key.c:249: error: (Each undeclared identifier is reported only once
> net/dns_resolver/dns_key.c:249: error: for each function it appears in.)
> net/dns_resolver/dns_key.c:250: error: 'KEY_POS_ALL' undeclared (first use in this function)
> net/dns_resolver/dns_key.c:250: error: 'KEY_POS_SETATTR' undeclared (first use in this function)
> net/dns_resolver/dns_key.c:251: error: 'KEY_USR_VIEW' undeclared (first use in this function)
> net/dns_resolver/dns_key.c:251: error: 'KEY_USR_READ' undeclared (first use in this function)
> net/dns_resolver/dns_key.c:252: error: 'KEY_ALLOC_NOT_IN_QUOTA' undeclared (first use in this function)
> net/dns_resolver/dns_key.c:258: error: implicit declaration of function 'key_instantiate_and_link'
> net/dns_resolver/dns_key.c:262: error: implicit declaration of function 'register_key_type'
> net/dns_resolver/dns_key.c:268: error: 'struct cred' has no member named 'thread_keyring'
> net/dns_resolver/dns_key.c:269: error: 'struct cred' has no member named 'jit_keyring'
> net/dns_resolver/dns_key.c: In function 'exit_dns_resolver':
> net/dns_resolver/dns_key.c:285: error: implicit declaration of function 'unregister_key_type'
> net/dns_resolver/dns_key.c:288: error: invalid use of undefined type 'struct key_type'

> Presumably this code has not been built on powerpc before.  Casued by
> commit 1a4240f4764ac78adbf4b0ebb49b3bd8c72ffa11 ("DNS: Separate out CIFS
> DNS Resolver code") (and the build was probably enabled by commit
> c2e8139c9f797baa46515af6d350c51823736cbb ("NFS: Use kernel DNS resolver
> [ver #2]").
>
> I can only imagine that linux/key.h is included indirectly on x86.
Are you sure that this is a valid config file?  CONFIG_KEYS should be
set if CONFIG_DNS_RESOLVER is set?

key.h looks like it is included in all arch in this path

net/dns_resolver/dns_key.c includes
include/keys/dns_resolver-type.h which includes
include/linux/key-type.h which includes
include/linux/key.h

the line 258 "key_instantiate_and_link" error could occur if
"CONFIG_KEYS" is not set in .config
net/dns_resolver/Kconfig config DNS_RESOLVER "depends on NET && KEYS"
so ... CONFIG_KEYS should be set ....







-- 
Thanks,

Steve

Re: linux-next: build failure after merge of the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Hi Steve,

On Wed, 11 Aug 2010 23:04:36 -0500 Steve French <smfrench@gmail.com> wrote:
>
> Are you sure that this is a valid config file?  CONFIG_KEYS should be
> set if CONFIG_DNS_RESOLVER is set?

It is a ppc64_defconfig.  It has:

# CONFIG_KEYS is not set
CONFIG_DNS_RESOLVER=y

CONFIG_NFS_USE_KERNEL_DNS just selects CONFIG_DNS_RESOLVER but there is
no dependency on CONFIG_KEYS (select does not care about the
dependencies of the selected config option).

> key.h looks like it is included in all arch in this path
> 
> net/dns_resolver/dns_key.c includes
> include/keys/dns_resolver-type.h which includes
> include/linux/key-type.h which includes
> include/linux/key.h
> 
> the line 258 "key_instantiate_and_link" error could occur if
> "CONFIG_KEYS" is not set in .config

Which t isn't.

> net/dns_resolver/Kconfig config DNS_RESOLVER "depends on NET && KEYS"
> so ... CONFIG_KEYS should be set ....

See above.  You need CONFIG_NFS_USE_KERNEL_DNS to also depend on
CONFIG_KEYS ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the cifs tree

[Bryan Schumaker]

Hi

I updated my NFS DNS patch.  The new version will set CONFIG_KEYS when CONFIG_NFS_USE_KERNEL_DNS is set.

Thanks for letting me know about this!

Bryan Schumaker



Use the kernel DNS resolver to translate hostnames to IP addresses.  Create a
new config option to choose between the legacy DNS resolver and the new
resolver.

Signed-off-by: Bryan Schumaker <bjschuma-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Acked-by: Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
---
Fix for KEYS dependency

 fs/nfs/Kconfig       |   16 ++++++++++++++++
 fs/nfs/dns_resolve.c |   24 ++++++++++++++++++++++++
 fs/nfs/dns_resolve.h |   12 ++++++++++++
 3 files changed, 52 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index cc1bb33..c5bbdca 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -100,3 +100,19 @@ config NFS_FSCACHE
 	help
 	  Say Y here if you want NFS data to be cached locally on disc through
 	  the general filesystem cache manager
+
+config NFS_USE_LEGACY_DNS
+	bool "Use the legacy NFS DNS resolver"
+	depends on NFS_V4
+	help
+	  The kernel now provides a method for translating a host name into an
+	  IP address.  Select Y here if you would rather use your own DNS
+	  resolver script.
+
+	  If unsure, say N
+
+config NFS_USE_KERNEL_DNS
+	bool
+	depends on NFS_V4 && !NFS_USE_LEGACY_DNS
+	select DNS_RESOLVER
+	select KEYS
+	default y
diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c
index 76fd235..dba50a5 100644
--- a/fs/nfs/dns_resolve.c
+++ b/fs/nfs/dns_resolve.c
@@ -6,6 +6,29 @@
  * Resolves DNS hostnames into valid ip addresses
  */

+#ifdef CONFIG_NFS_USE_KERNEL_DNS
+
+#include <linux/sunrpc/clnt.h>
+#include <linux/dns_resolver.h>
+
+ssize_t nfs_dns_resolve_name(char *name, size_t namelen,
+		struct sockaddr *sa, size_t salen)
+{
+	ssize_t ret;
+	char *ip_addr = NULL;
+	int ip_len;
+
+	ip_len = dns_query(NULL, name, namelen, NULL, &ip_addr, NULL);
+	if (ip_len > 0)
+		ret = rpc_pton(ip_addr, ip_len, sa, salen);
+	else
+		ret = -ESRCH;
+	kfree(ip_addr);
+	return ret;
+}
+
+#else
+
 #include <linux/hash.h>
 #include <linux/string.h>
 #include <linux/kmod.h>
@@ -346,3 +369,4 @@ void nfs_dns_resolver_destroy(void)
 	nfs_cache_unregister(&nfs_dns_resolve);
 }

+#endif
diff --git a/fs/nfs/dns_resolve.h b/fs/nfs/dns_resolve.h
index a3f0938..199bb55 100644
--- a/fs/nfs/dns_resolve.h
+++ b/fs/nfs/dns_resolve.h
@@ -6,8 +6,20 @@

 #define NFS_DNS_HOSTNAME_MAXLEN	(128)

+
+#ifdef CONFIG_NFS_USE_KERNEL_DNS
+static inline int nfs_dns_resolver_init(void)
+{
+	return 0;
+}
+
+static inline void nfs_dns_resolver_destroy(void)
+{}
+#else
 extern int nfs_dns_resolver_init(void);
 extern void nfs_dns_resolver_destroy(void);
+#endif
+
 extern ssize_t nfs_dns_resolve_name(char *name, size_t namelen,
 		struct sockaddr *sa, size_t salen);




On 08/12/2010 03:46 AM, Stephen Rothwell wrote:
> Hi Steve,
> 
> On Wed, 11 Aug 2010 23:04:36 -0500 Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>
>> Are you sure that this is a valid config file?  CONFIG_KEYS should be
>> set if CONFIG_DNS_RESOLVER is set?
> 
> It is a ppc64_defconfig.  It has:
> 
> # CONFIG_KEYS is not set
> CONFIG_DNS_RESOLVER=y
> 
> CONFIG_NFS_USE_KERNEL_DNS just selects CONFIG_DNS_RESOLVER but there is
> no dependency on CONFIG_KEYS (select does not care about the
> dependencies of the selected config option).
> 
>> key.h looks like it is included in all arch in this path
>>
>> net/dns_resolver/dns_key.c includes
>> include/keys/dns_resolver-type.h which includes
>> include/linux/key-type.h which includes
>> include/linux/key.h
>>
>> the line 258 "key_instantiate_and_link" error could occur if
>> "CONFIG_KEYS" is not set in .config
> 
> Which t isn't.
> 
>> net/dns_resolver/Kconfig config DNS_RESOLVER "depends on NET && KEYS"
>> so ... CONFIG_KEYS should be set ....
> 
> See above.  You need CONFIG_NFS_USE_KERNEL_DNS to also depend on
> CONFIG_KEYS ...
> 

Re: linux-next: build failure after merge of the cifs tree

[Steve French]

On Thu, Aug 12, 2010 at 2:46 AM, Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
> See above.  You need CONFIG_NFS_USE_KERNEL_DNS to also depend on
> CONFIG_KEYS ...

Fixed in cifs-2.6.git


-- 
Thanks,

Steve

Re: linux-next: build failure after merge of the cifs tree

[David Howells]

Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> net/dns_resolver/Kconfig config DNS_RESOLVER "depends on NET && KEYS"
> so ... CONFIG_KEYS should be set ....

Perhaps it needs to select CONFIG_KEYS instead?

David