From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB81C11F66 for ; Tue, 13 Jul 2021 01:02:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0991D611F1 for ; Tue, 13 Jul 2021 01:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230158AbhGMBFQ (ORCPT ); Mon, 12 Jul 2021 21:05:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:48300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbhGMBFQ (ORCPT ); Mon, 12 Jul 2021 21:05:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5EC2A611CC; Tue, 13 Jul 2021 01:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626138147; bh=wmsUL1R2xXv/lc0kVW0n4SuQ1K4WRdLz0Vs5Mq0sQQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z7msqr9I4jFcGyIIVaVeeFiSdV1KAox118ZjCxQe4nvCayB4615onakJ7fWb8kiPe qFIm9jMVYNQT64+ZKSOez774UGtAozFQQEXZqUGWWPyrwWgcmP2GDGf0DQ94Vp5eaP 59t8ZA7xm3usHNzAJBRwuST9unrJqNcRg+t2i77q5vNp7kMsSg++9Zp1F+KLYk91y2 KeczINZZCSvp3INrsc6INpR0LSm/k5pAAISF2N4jx6aoDcee8WJHXESX2qMlEbtTSi 7vS9s3efb3T1OPcbLvjQZMSCaZlgdDiSd/bAgMC/v938DAqkvuzHctHnl5/KnQRbR+ BY6L9JH1OP4CA== Date: Mon, 12 Jul 2021 18:02:27 -0700 From: "Darrick J. Wong" To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig , Ted Tso , Dave Chinner , Matthew Wilcox , linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 02/14] documentation: Sync file_operations members with reality Message-ID: <20210713010227.GC23236@magnolia> References: <20210712163901.29514-1-jack@suse.cz> <20210712165609.13215-2-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712165609.13215-2-jack@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Mon, Jul 12, 2021 at 06:55:53PM +0200, Jan Kara wrote: > Sync listing of struct file_operations members with the real one in > fs.h. > > Acked-by: Darrick J. Wong Might as well upgrade this to: Reviewed-by: Darrick J. Wong --D > Reviewed-by: Christoph Hellwig > Signed-off-by: Jan Kara > --- > Documentation/filesystems/locking.rst | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst > index 2183fd8cc350..cdf15492c699 100644 > --- a/Documentation/filesystems/locking.rst > +++ b/Documentation/filesystems/locking.rst > @@ -506,6 +506,7 @@ prototypes:: > ssize_t (*write) (struct file *, const char __user *, size_t, loff_t *); > ssize_t (*read_iter) (struct kiocb *, struct iov_iter *); > ssize_t (*write_iter) (struct kiocb *, struct iov_iter *); > + int (*iopoll) (struct kiocb *kiocb, bool spin); > int (*iterate) (struct file *, struct dir_context *); > int (*iterate_shared) (struct file *, struct dir_context *); > __poll_t (*poll) (struct file *, struct poll_table_struct *); > @@ -518,12 +519,6 @@ prototypes:: > int (*fsync) (struct file *, loff_t start, loff_t end, int datasync); > int (*fasync) (int, struct file *, int); > int (*lock) (struct file *, int, struct file_lock *); > - ssize_t (*readv) (struct file *, const struct iovec *, unsigned long, > - loff_t *); > - ssize_t (*writev) (struct file *, const struct iovec *, unsigned long, > - loff_t *); > - ssize_t (*sendfile) (struct file *, loff_t *, size_t, read_actor_t, > - void __user *); > ssize_t (*sendpage) (struct file *, struct page *, int, size_t, > loff_t *, int); > unsigned long (*get_unmapped_area)(struct file *, unsigned long, > @@ -536,6 +531,14 @@ prototypes:: > size_t, unsigned int); > int (*setlease)(struct file *, long, struct file_lock **, void **); > long (*fallocate)(struct file *, int, loff_t, loff_t); > + void (*show_fdinfo)(struct seq_file *m, struct file *f); > + unsigned (*mmap_capabilities)(struct file *); > + ssize_t (*copy_file_range)(struct file *, loff_t, struct file *, > + loff_t, size_t, unsigned int); > + loff_t (*remap_file_range)(struct file *file_in, loff_t pos_in, > + struct file *file_out, loff_t pos_out, > + loff_t len, unsigned int remap_flags); > + int (*fadvise)(struct file *, loff_t, loff_t, int); > > locking rules: > All may block. > -- > 2.26.2 >