From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E6BC12002 for ; Fri, 16 Jul 2021 16:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D07A8613EE for ; Fri, 16 Jul 2021 16:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230191AbhGPQqL (ORCPT ); Fri, 16 Jul 2021 12:46:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:47086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbhGPQqI (ORCPT ); Fri, 16 Jul 2021 12:46:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 35961613D0; Fri, 16 Jul 2021 16:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626453793; bh=4cf1AnF6M65jEKCZ4DUvlF+jXCvIQBpF34YgrerdDE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ER33OScu5jXxJL4bBbchkSb43icKDsitlTLzz/ULEuCKhDyvzfruACZnB7KEth/Ea CrHL2LSiOdJ48FNoGdUcRJPztvvlN2R9q/wJJKcgnB4F1BFPAddcRBz30NPyaVNVA/ c13g+u1kfK1sYm4jZTlXTgZiWA4uk6IRkbh//2Bk3gR4M1niUW7g70cN+zj01sKUw5 w11NLDR1ohyuzzNvoiRCItpM7Kwmua6Mzwh8IqK6FDO3uAqgbL4KU/TlVuM6lEEHgQ owdro4sa6g8ZVQZprvohZ8U0qKtbPZRfpQ+EtiAyzSrv0hMzf/nWGpv1wM1Qur2p+u KJcRDYSgBrojg== Date: Fri, 16 Jul 2021 09:43:11 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Ted Tso , Dave Chinner , Matthew Wilcox , linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org Subject: Re: [PATCH 0/14 v10] fs: Hole punch vs page cache filling races Message-ID: <20210716164311.GA22357@magnolia> References: <20210715133202.5975-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Fri, Jul 16, 2021 at 07:02:19AM +0100, Christoph Hellwig wrote: > On Thu, Jul 15, 2021 at 03:40:10PM +0200, Jan Kara wrote: > > Hello, > > > > here is another version of my patches to address races between hole punching > > and page cache filling functions for ext4 and other filesystems. The only > > change since the last time is a small cleanup applied to changes of > > filemap_fault() in patch 3/14 based on Christoph's & Darrick's feedback (thanks > > guys!). Darrick, Christoph, is the patch fine now? > > Looks fine to me. Me too. --D