linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cifs: add missing parsing of backupuid
@ 2021-07-28  6:38 Ronnie Sahlberg
  2021-07-28 15:28 ` Shyam Prasad N
  0 siblings, 1 reply; 3+ messages in thread
From: Ronnie Sahlberg @ 2021-07-28  6:38 UTC (permalink / raw)
  To: linux-cifs; +Cc: Steve French

We lost parsing of backupuid in the switch to new mount API.
Add it back.

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
---
 fs/cifs/fs_context.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/cifs/fs_context.c b/fs/cifs/fs_context.c
index 9a59d7ff9a11..eed59bc1d913 100644
--- a/fs/cifs/fs_context.c
+++ b/fs/cifs/fs_context.c
@@ -925,6 +925,13 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,
 		ctx->cred_uid = uid;
 		ctx->cruid_specified = true;
 		break;
+	case Opt_backupuid:
+		uid = make_kuid(current_user_ns(), result.uint_32);
+		if (!uid_valid(uid))
+			goto cifs_parse_mount_err;
+		ctx->backupuid = uid;
+		ctx->backupuid_specified = true;
+		break;
 	case Opt_backupgid:
 		gid = make_kgid(current_user_ns(), result.uint_32);
 		if (!gid_valid(gid))
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cifs: add missing parsing of backupuid
  2021-07-28  6:38 [PATCH] cifs: add missing parsing of backupuid Ronnie Sahlberg
@ 2021-07-28 15:28 ` Shyam Prasad N
  0 siblings, 0 replies; 3+ messages in thread
From: Shyam Prasad N @ 2021-07-28 15:28 UTC (permalink / raw)
  To: Ronnie Sahlberg; +Cc: linux-cifs, Steve French

On Wed, Jul 28, 2021 at 12:08 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
>
> We lost parsing of backupuid in the switch to new mount API.
> Add it back.
>
> Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> ---
>  fs/cifs/fs_context.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/fs/cifs/fs_context.c b/fs/cifs/fs_context.c
> index 9a59d7ff9a11..eed59bc1d913 100644
> --- a/fs/cifs/fs_context.c
> +++ b/fs/cifs/fs_context.c
> @@ -925,6 +925,13 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,
>                 ctx->cred_uid = uid;
>                 ctx->cruid_specified = true;
>                 break;
> +       case Opt_backupuid:
> +               uid = make_kuid(current_user_ns(), result.uint_32);
> +               if (!uid_valid(uid))
> +                       goto cifs_parse_mount_err;
> +               ctx->backupuid = uid;
> +               ctx->backupuid_specified = true;
> +               break;
>         case Opt_backupgid:
>                 gid = make_kgid(current_user_ns(), result.uint_32);
>                 if (!gid_valid(gid))
> --
> 2.30.2
>

Looks good to me.
Might also be worthwhile to check if we missed any other mount option?

-- 
Regards,
Shyam

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] cifs: add missing parsing of backupuid
@ 2021-07-28 20:59 Ronnie Sahlberg
  0 siblings, 0 replies; 3+ messages in thread
From: Ronnie Sahlberg @ 2021-07-28 20:59 UTC (permalink / raw)
  To: linux-cifs; +Cc: Steve French

We lost parsing of backupuid in the switch to new mount API.
Add it back.

Reported-by: Xiaoli Feng <xifeng@redhat.com>
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
---
 fs/cifs/fs_context.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/cifs/fs_context.c b/fs/cifs/fs_context.c
index 9a59d7ff9a11..eed59bc1d913 100644
--- a/fs/cifs/fs_context.c
+++ b/fs/cifs/fs_context.c
@@ -925,6 +925,13 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,
 		ctx->cred_uid = uid;
 		ctx->cruid_specified = true;
 		break;
+	case Opt_backupuid:
+		uid = make_kuid(current_user_ns(), result.uint_32);
+		if (!uid_valid(uid))
+			goto cifs_parse_mount_err;
+		ctx->backupuid = uid;
+		ctx->backupuid_specified = true;
+		break;
 	case Opt_backupgid:
 		gid = make_kgid(current_user_ns(), result.uint_32);
 		if (!gid_valid(gid))
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-28 20:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28  6:38 [PATCH] cifs: add missing parsing of backupuid Ronnie Sahlberg
2021-07-28 15:28 ` Shyam Prasad N
2021-07-28 20:59 Ronnie Sahlberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).