linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [regression] lock test hang since 5.13-rc-smb3-part2
@ 2021-09-06 11:45 Murphy Zhou
  2021-09-06 15:47 ` Rohith Surabattula
  0 siblings, 1 reply; 3+ messages in thread
From: Murphy Zhou @ 2021-09-06 11:45 UTC (permalink / raw)
  To: linux-cifs; +Cc: Rohith Surabattula

Hi,

Since this commit:

commit c3f207ab29f793b8c942ce8067ed123f18d5b81b
Author: Rohith Surabattula <rohiths@microsoft.com>
Date:   Tue Apr 13 00:26:42 2021 -0500

    cifs: Deferred close for files

Xfstests generic/478 on CIFS can't finish like before. The test programme
never returns but killable. The kernel does not warn about soft or hard
lockups. So it looks like looping forever at some point.

It's always reproducible. Without this commit, generic/478 fails the test
because of different lock schema but complete very fast. With this commit,
test hang like forever.

Sorry that I do not look further here, because I have another bisecting to
do to hunting another regression.

Thanks,
Murphy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [regression] lock test hang since 5.13-rc-smb3-part2
  2021-09-06 11:45 [regression] lock test hang since 5.13-rc-smb3-part2 Murphy Zhou
@ 2021-09-06 15:47 ` Rohith Surabattula
  2021-09-07  3:18   ` Murphy Zhou
  0 siblings, 1 reply; 3+ messages in thread
From: Rohith Surabattula @ 2021-09-06 15:47 UTC (permalink / raw)
  To: Murphy Zhou; +Cc: linux-cifs, Rohith Surabattula

Can you please share the mount options.

Did you observe the same failure with 5.14-rc5-smb3-fixes ?
I ran the generic/478 test on 5.14 and didn't see any hang. But, test
fails with below

generic/478     - output mismatch (see
/home/lxsmbadmin/xfstests-dev/results//sm
                                               b3/generic/478.out.bad)
    --- tests/generic/478.out   2021-05-03 19:01:04.767577557 +0000
    +++ /home/lxsmbadmin/xfstests-dev/results//smb3/generic/478.out.bad
2021-09-
              06 15:39:39.625248615 +0000
    @@ -1,13 +1,13 @@
     QA output created by 478
     get wrlck
     lock could be placed
    -get wrlck
    -get wrlck
     lock could be placed
     get wrlck
    ...
    (Run 'diff -u /home/lxsmbadmin/xfstests-dev/tests/generic/478.out
/home/lxsm
                badmin/xfstests-dev/results//smb3/generic/478.out.bad'
 to see the entire diff)
Ran: generic/478
Failures: generic/478
Failed 1 of 1 tests

Regards,
Rohith

On Mon, Sep 6, 2021 at 5:16 PM Murphy Zhou <jencce.kernel@gmail.com> wrote:
>
> Hi,
>
> Since this commit:
>
> commit c3f207ab29f793b8c942ce8067ed123f18d5b81b
> Author: Rohith Surabattula <rohiths@microsoft.com>
> Date:   Tue Apr 13 00:26:42 2021 -0500
>
>     cifs: Deferred close for files
>
> Xfstests generic/478 on CIFS can't finish like before. The test programme
> never returns but killable. The kernel does not warn about soft or hard
> lockups. So it looks like looping forever at some point.
>
> It's always reproducible. Without this commit, generic/478 fails the test
> because of different lock schema but complete very fast. With this commit,
> test hang like forever.
>
> Sorry that I do not look further here, because I have another bisecting to
> do to hunting another regression.
>
> Thanks,
> Murphy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [regression] lock test hang since 5.13-rc-smb3-part2
  2021-09-06 15:47 ` Rohith Surabattula
@ 2021-09-07  3:18   ` Murphy Zhou
  0 siblings, 0 replies; 3+ messages in thread
From: Murphy Zhou @ 2021-09-07  3:18 UTC (permalink / raw)
  To: Rohith Surabattula; +Cc: Murphy Zhou, linux-cifs, Rohith Surabattula

On Mon, Sep 06, 2021 at 09:17:31PM +0530, Rohith Surabattula wrote:
> Can you please share the mount options.

 vers=3.11,mfsymlinks,username=root,password=xx

> 
> Did you observe the same failure with 5.14-rc5-smb3-fixes ?
> I ran the generic/478 test on 5.14 and didn't see any hang. But, test
> fails with below
> 
> generic/478     - output mismatch (see
> /home/lxsmbadmin/xfstests-dev/results//sm
>                                                b3/generic/478.out.bad)
>     --- tests/generic/478.out   2021-05-03 19:01:04.767577557 +0000
>     +++ /home/lxsmbadmin/xfstests-dev/results//smb3/generic/478.out.bad
> 2021-09-
>               06 15:39:39.625248615 +0000
>     @@ -1,13 +1,13 @@
>      QA output created by 478
>      get wrlck
>      lock could be placed
>     -get wrlck
>     -get wrlck
>      lock could be placed
>      get wrlck
>     ...
>     (Run 'diff -u /home/lxsmbadmin/xfstests-dev/tests/generic/478.out
> /home/lxsm
>                 badmin/xfstests-dev/results//smb3/generic/478.out.bad'
>  to see the entire diff)
> Ran: generic/478
> Failures: generic/478
> Failed 1 of 1 tests
> 
> Regards,
> Rohith
> 
> On Mon, Sep 6, 2021 at 5:16 PM Murphy Zhou <jencce.kernel@gmail.com> wrote:
> >
> > Hi,
> >
> > Since this commit:
> >
> > commit c3f207ab29f793b8c942ce8067ed123f18d5b81b
> > Author: Rohith Surabattula <rohiths@microsoft.com>
> > Date:   Tue Apr 13 00:26:42 2021 -0500
> >
> >     cifs: Deferred close for files
> >
> > Xfstests generic/478 on CIFS can't finish like before. The test programme
> > never returns but killable. The kernel does not warn about soft or hard
> > lockups. So it looks like looping forever at some point.
> >
> > It's always reproducible. Without this commit, generic/478 fails the test
> > because of different lock schema but complete very fast. With this commit,
> > test hang like forever.
> >
> > Sorry that I do not look further here, because I have another bisecting to
> > do to hunting another regression.
> >
> > Thanks,
> > Murphy

-- 
Murphy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-07  3:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06 11:45 [regression] lock test hang since 5.13-rc-smb3-part2 Murphy Zhou
2021-09-06 15:47 ` Rohith Surabattula
2021-09-07  3:18   ` Murphy Zhou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).