linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
	Christian Brauner <christian.brauner@ubuntu.com>,
	Steve French <sfrench@samba.org>,
	Hyunchul Lee <hyc.lee@gmail.com>,
	linux-cifs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ksmbd: potential uninitialized error code in set_file_basic_info()
Date: Tue, 7 Sep 2021 11:48:51 +0300	[thread overview]
Message-ID: <20210907084851.GL1957@kadam> (raw)
In-Reply-To: <YTccRzi/j+7t2eB9@google.com>

On Tue, Sep 07, 2021 at 05:01:11PM +0900, Sergey Senozhatsky wrote:
> 
>                rc = setattr_prepare(user_ns, dentry, &attrs);
>                if (rc)
>                         return -EINVAL;
> 
> Either it should be used more, and probably be a return value, or we can
> just remove it.

You are looking at old code from before the bug was introduced.

regards,
dan carpenter



  parent reply	other threads:[~2021-09-07  8:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07  7:33 Dan Carpenter
2021-09-07  8:01 ` Sergey Senozhatsky
2021-09-07  8:09   ` Namjae Jeon
2021-09-07  8:38     ` Sergey Senozhatsky
2021-09-13  9:47     ` Christian Brauner
2021-09-07  8:48   ` Dan Carpenter [this message]
2021-09-07  9:04     ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907084851.GL1957@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=hyc.lee@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=sfrench@samba.org \
    --subject='Re: [PATCH] ksmbd: potential uninitialized error code in set_file_basic_info()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).