Linux-CIFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] cifs: fix build errors for SMB_DIRECT
@ 2018-01-02 17:43 Randy Dunlap
  2018-01-03 17:48 ` Steve French
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2018-01-02 17:43 UTC (permalink / raw)
  To: LKML, linux-cifs-u79uwXL29TY76Z2rM5mHXA
  Cc: samba-technical-w/Ol4Ecudpl8XjKLYN78aQ, Steve French

From: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

Prevent build errors when CIFS=y and INFINIBAND=m.

fs/cifs/smbdirect.o: In function `smbd_qp_async_error_upcall':
smbdirect.c:(.text+0x28c): undefined reference to `ib_event_msg'
fs/cifs/smbdirect.o: In function `smbd_destroy_rdma_work':
smbdirect.c:(.text+0xfde): undefined reference to `ib_drain_qp'
smbdirect.c:(.text+0xfea): undefined reference to `rdma_destroy_qp'
smbdirect.c:(.text+0x12a0): undefined reference to `ib_free_cq'
smbdirect.c:(.text+0x12ac): undefined reference to `ib_free_cq'
smbdirect.c:(.text+0x12b8): undefined reference to `ib_dealloc_pd'
smbdirect.c:(.text+0x12c4): undefined reference to `rdma_destroy_id'
fs/cifs/smbdirect.o: In function `_smbd_get_connection':
smbdirect.c:(.text+0x168c): undefined reference to `rdma_create_id'
smbdirect.c:(.text+0x1713): undefined reference to `rdma_resolve_addr'
smbdirect.c:(.text+0x1780): undefined reference to `rdma_resolve_route'
smbdirect.c:(.text+0x17e3): undefined reference to `rdma_destroy_id'
smbdirect.c:(.text+0x183d): undefined reference to `rdma_destroy_id'
smbdirect.c:(.text+0x199d): undefined reference to `ib_alloc_cq'
smbdirect.c:(.text+0x19d9): undefined reference to `ib_alloc_cq'
smbdirect.c:(.text+0x1a89): undefined reference to `rdma_create_qp'
smbdirect.c:(.text+0x1b3c): undefined reference to `rdma_connect'
smbdirect.c:(.text+0x2538): undefined reference to `rdma_destroy_qp'
smbdirect.c:(.text+0x2549): undefined reference to `ib_free_cq'
smbdirect.c:(.text+0x255a): undefined reference to `ib_free_cq'
smbdirect.c:(.text+0x2563): undefined reference to `ib_dealloc_pd'
smbdirect.c:(.text+0x256c): undefined reference to `rdma_destroy_id'
smbdirect.c:(.text+0x25f0): undefined reference to `__ib_alloc_pd'
smbdirect.c:(.text+0x26bb): undefined reference to `rdma_disconnect'
fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work':
smbdirect.c:(.text+0x62): undefined reference to `rdma_disconnect'

Signed-off-by: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc:	Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Cc:	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc:	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org (moderated for non-subscribers)
---
 fs/cifs/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20180102.orig/fs/cifs/Kconfig
+++ linux-next-20180102/fs/cifs/Kconfig
@@ -197,7 +197,7 @@ config CIFS_SMB311
 
 config CIFS_SMB_DIRECT
 	bool "SMB Direct support (Experimental)"
-	depends on CIFS && INFINIBAND
+	depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y
 	help
 	  Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1.
 	  SMB Direct allows transferring SMB packets over RDMA. If unsure,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] cifs: fix build errors for SMB_DIRECT
  2018-01-02 17:43 [PATCH -next] cifs: fix build errors for SMB_DIRECT Randy Dunlap
@ 2018-01-03 17:48 ` Steve French
  0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2018-01-03 17:48 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: LKML, linux-cifs, samba-technical, Steve French

merged into cifs-2.6.git for-next

On Tue, Jan 2, 2018 at 11:43 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Prevent build errors when CIFS=y and INFINIBAND=m.
>
> fs/cifs/smbdirect.o: In function `smbd_qp_async_error_upcall':
> smbdirect.c:(.text+0x28c): undefined reference to `ib_event_msg'
> fs/cifs/smbdirect.o: In function `smbd_destroy_rdma_work':
> smbdirect.c:(.text+0xfde): undefined reference to `ib_drain_qp'
> smbdirect.c:(.text+0xfea): undefined reference to `rdma_destroy_qp'
> smbdirect.c:(.text+0x12a0): undefined reference to `ib_free_cq'
> smbdirect.c:(.text+0x12ac): undefined reference to `ib_free_cq'
> smbdirect.c:(.text+0x12b8): undefined reference to `ib_dealloc_pd'
> smbdirect.c:(.text+0x12c4): undefined reference to `rdma_destroy_id'
> fs/cifs/smbdirect.o: In function `_smbd_get_connection':
> smbdirect.c:(.text+0x168c): undefined reference to `rdma_create_id'
> smbdirect.c:(.text+0x1713): undefined reference to `rdma_resolve_addr'
> smbdirect.c:(.text+0x1780): undefined reference to `rdma_resolve_route'
> smbdirect.c:(.text+0x17e3): undefined reference to `rdma_destroy_id'
> smbdirect.c:(.text+0x183d): undefined reference to `rdma_destroy_id'
> smbdirect.c:(.text+0x199d): undefined reference to `ib_alloc_cq'
> smbdirect.c:(.text+0x19d9): undefined reference to `ib_alloc_cq'
> smbdirect.c:(.text+0x1a89): undefined reference to `rdma_create_qp'
> smbdirect.c:(.text+0x1b3c): undefined reference to `rdma_connect'
> smbdirect.c:(.text+0x2538): undefined reference to `rdma_destroy_qp'
> smbdirect.c:(.text+0x2549): undefined reference to `ib_free_cq'
> smbdirect.c:(.text+0x255a): undefined reference to `ib_free_cq'
> smbdirect.c:(.text+0x2563): undefined reference to `ib_dealloc_pd'
> smbdirect.c:(.text+0x256c): undefined reference to `rdma_destroy_id'
> smbdirect.c:(.text+0x25f0): undefined reference to `__ib_alloc_pd'
> smbdirect.c:(.text+0x26bb): undefined reference to `rdma_disconnect'
> fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work':
> smbdirect.c:(.text+0x62): undefined reference to `rdma_disconnect'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc:     Steve French <sfrench@samba.org>
> Cc:     linux-cifs@vger.kernel.org
> Cc:     samba-technical@lists.samba.org (moderated for non-subscribers)
> ---
>  fs/cifs/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20180102.orig/fs/cifs/Kconfig
> +++ linux-next-20180102/fs/cifs/Kconfig
> @@ -197,7 +197,7 @@ config CIFS_SMB311
>
>  config CIFS_SMB_DIRECT
>         bool "SMB Direct support (Experimental)"
> -       depends on CIFS && INFINIBAND
> +       depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y
>         help
>           Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1.
>           SMB Direct allows transferring SMB packets over RDMA. If unsure,
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-02 17:43 [PATCH -next] cifs: fix build errors for SMB_DIRECT Randy Dunlap
2018-01-03 17:48 ` Steve French

Linux-CIFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-cifs/0 linux-cifs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-cifs linux-cifs/ https://lore.kernel.org/linux-cifs \
		linux-cifs@vger.kernel.org
	public-inbox-index linux-cifs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-cifs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git