linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Talpey <tom@talpey.com>
To: Steve French <smfrench@gmail.com>,
	samba-technical <samba-technical@lists.samba.org>,
	CIFS <linux-cifs@vger.kernel.org>
Subject: Re: new SMB3.1.1 create contexts
Date: Sun, 2 Oct 2022 14:26:59 -0400	[thread overview]
Message-ID: <2734eb6f-cc01-cb0a-433d-e97729ce2aee@talpey.com> (raw)
In-Reply-To: <CAH2r5mtoZRrCY-jDCH72DSNXPMxYiu24cuRRguLyXDx6zKUvwg@mail.gmail.com>

On 10/2/2022 12:01 AM, Steve French wrote:
> patch attached to add the four missing create context IDs to the kernel

These don't seem very important, to me. The APP_INSTANCE ones are
about clustered clients where VMs may want to migrate around the
cluster and not lose their VHDs. The OPEN_DEVICE_CONTEXT is about
MS-RSVD. Neither of these are in Linux?

The AAPL one is all about MacOS behaviors. If this is being added,
it needs additional documentation of the parameter block, no?

Tom.

> On Sat, Oct 1, 2022 at 6:50 PM Steve French <smfrench@gmail.com> wrote:
>>
>> Noticed a few SMB3.1.1 create contexts missing from the Linux kernel
>> code.  Any more beyond these four that are still missing?
>>
>> diff --git a/fs/smbfs_common/smb2pdu.h b/fs/smbfs_common/smb2pdu.h
>> index 2cab413fffee..7d605db3bb3b 100644
>> --- a/fs/smbfs_common/smb2pdu.h
>> +++ b/fs/smbfs_common/smb2pdu.h
>> @@ -1101,7 +1101,11 @@ struct smb2_change_notify_rsp {
>>   #define SMB2_CREATE_REQUEST_LEASE              "RqLs"
>>   #define SMB2_CREATE_DURABLE_HANDLE_REQUEST_V2  "DH2Q"
>>   #define SMB2_CREATE_DURABLE_HANDLE_RECONNECT_V2        "DH2C"
>> -#define SMB2_CREATE_TAG_POSIX
>> "\x93\xAD\x25\x50\x9C\xB4\x11\xE7\xB4\x23\x83\xDE\x96\x8B\xCD\x7C"
>> +#define SMB2_CREATE_TAG_POSIX
>> "\x93\xAD\x25\x50\x9C\xB4\x11\xE7\xB4\x23\x83\xDE\x96\x8B\xCD\x7C"
>> +#define SMB2_CREATE_APP_INSTANCE_ID
>> "\x45\xBC\xA6\x6A\xEF\xA7\xF7\x4A\x90\x08\xFA\x46\x2E\x14\x4D\x74"
>> +#define SMB2_CREATE_APP_INSTANCE_VERSION
>> "\xB9\x82\xD0\xB7\x3B\x56\x07\x4F\xA0\x7B\x52\x4A\x81\x16\xA0\x10"
>> +#define SVHDX_OPEN_DEVICE_CONTEXT
>> "\x9C\xCB\xCF\x9E\x04\xC1\xE6\x43\x98\x0E\x15\x8D\xA1\xF6\xEC\x83"
>> +#define SMB2_CREATE_TAG_AAPL                   "AAPL"
>>
>>
>> --
>> Thanks,
>>
>> Steve
> 
> 
> 

      reply	other threads:[~2022-10-02 18:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01 23:50 new SMB3.1.1 create contexts Steve French
2022-10-02  4:01 ` Steve French
2022-10-02 18:26   ` Tom Talpey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2734eb6f-cc01-cb0a-433d-e97729ce2aee@talpey.com \
    --to=tom@talpey.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).