From: Jeff Layton <jlayton@kernel.org>
To: Deepa Dinamani <deepa.kernel@gmail.com>,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org,
arnd@arndb.de, adilger.kernel@dilger.ca, adrian.hunter@intel.com,
aivazian.tigran@gmail.com, al@alarsen.net,
anna.schumaker@netapp.com, anton@enomsg.org,
asmadeus@codewreck.org, ccross@android.com,
ceph-devel@vger.kernel.org, coda@cs.cmu.edu,
codalist@coda.cs.cmu.edu, darrick.wong@oracle.com,
dedekind1@gmail.com, devel@lists.orangefs.org, dsterba@suse.com,
dushistov@mail.ru, dwmw2@infradead.org, ericvh@gmail.com,
gregkh@linuxfoundation.org, hch@infradead.org, hch@lst.de,
hirofumi@mail.parknet.co.jp, hubcap@omnibond.com,
idryomov@gmail.com, jack@suse.com, jaegeuk@kernel.org,
jaharkes@cs.cmu.edu, jfs-discussion@lists.sourceforge.net,
jlbec@evilplan.org, keescook@chromium.org,
linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-karma-devel@lists.sourceforge.net,
linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net, linux-xfs@vger.kernel.org,
lucho@ionkov.net, luisbg@kernel.org, martin@omnibond.com,
me@bobcopeland.com, mikulas@artax.karlin.mff.cuni.cz,
nico@fluxnic.net, phillip@squashfs.org.uk,
reiserfs-devel@vger.kernel.org, richard@nod.at, sage@redhat.com,
salah.triki@gmail.com, sfrench@samba.org, shaggy@kernel.org,
tj@kernel.org, tony.luck@intel.com,
trond.myklebust@hammerspace.com, tytso@mit.edu,
v9fs-developer@lists.sourceforge.net, yuchao0@huawei.com,
zyan@redhat.com
Subject: Re: [PATCH v8 00/20] vfs: Add support for timestamp limits
Date: Tue, 20 Aug 2019 07:05:10 -0400 [thread overview]
Message-ID: <27d1943a0027cb4f658334fad8dc880df133c22d.camel@kernel.org> (raw)
In-Reply-To: <20190818165817.32634-1-deepa.kernel@gmail.com>
On Sun, 2019-08-18 at 09:57 -0700, Deepa Dinamani wrote:
> The series is an update and a more complete version of the
> previously posted series at
> https://lore.kernel.org/linux-fsdevel/20180122020426.2988-1-deepa.kernel@gmail.com/
>
> Thanks to Arnd Bergmann for doing a few preliminary reviews.
> They helped me fix a few issues I had overlooked.
>
> The limits (sometimes granularity also) for the filesystems updated here are according to the
> following table:
>
> File system Time type Start year Expiration year Granularity
> cramfs fixed 0 0
> romfs fixed 0 0
> pstore ascii seconds (27 digit ascii) S64_MIN S64_MAX 1
> coda INT64 S64_MIN S64_MAX 1
> omfs 64-bit milliseconds 0 U64_MAX/ 1000 NSEC_PER_MSEC
> befs unsigned 48-bit seconds 0 0xffffffffffff alloc_super
> bfs unsigned 32-bit seconds 0 U32_MAX alloc_super
> efs unsigned 32-bit seconds 0 U32_MAX alloc_super
> ext2 signed 32-bit seconds S32_MIN S32_MAX alloc_super
> ext3 signed 32-bit seconds S32_MIN S32_MAX alloc_super
> ext4 (old) signed 32-bit seconds S32_MIN S32_MAX alloc_super
> ext4 (extra) 34-bit seconds, 30-bit ns S32_MIN 0x37fffffff 1
> freevxfs u32 secs/usecs 0 U32_MAX alloc_super
> jffs2 unsigned 32-bit seconds 0 U32_MAX alloc_super
> jfs unsigned 32-bit seconds/ns 0 U32_MAX 1
> minix unsigned 32-bit seconds 0 U32_MAX alloc_super
> orangefs u64 seconds 0 U64_MAX alloc_super
> qnx4 unsigned 32-bit seconds 0 U32_MAX alloc_super
> qnx6 unsigned 32-bit seconds 0 U32_MAX alloc_super
> reiserfs unsigned 32-bit seconds 0 U32_MAX alloc_super
> squashfs unsigned 32-bit seconds 0 U32_MAX alloc_super
> ufs1 signed 32-bit seconds S32_MIN S32_MAX NSEC_PER_SEC
> ufs2 signed 64-bit seconds/u32 ns S64_MIN S64_MAX 1
> xfs signed 32-bit seconds/ns S32_MIN S32_MAX 1
> ceph unsigned 32-bit second/ns 0 U32_MAX 1000
Looks reasonable, overall.
Note that the granularity changed recently for cephfs. See commit
0f7cf80ae96c2a (ceph: initialize superblock s_time_gran to 1).
In any case, you can add my Acked-by
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2019-08-20 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 16:57 [PATCH v8 00/20] vfs: Add support for timestamp limits Deepa Dinamani
2019-08-18 16:58 ` [PATCH v8 11/20] fs: cifs: Initialize filesystem timestamp ranges Deepa Dinamani
2019-08-20 11:05 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27d1943a0027cb4f658334fad8dc880df133c22d.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=aivazian.tigran@gmail.com \
--cc=al@alarsen.net \
--cc=anna.schumaker@netapp.com \
--cc=anton@enomsg.org \
--cc=arnd@arndb.de \
--cc=asmadeus@codewreck.org \
--cc=ccross@android.com \
--cc=ceph-devel@vger.kernel.org \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=darrick.wong@oracle.com \
--cc=dedekind1@gmail.com \
--cc=deepa.kernel@gmail.com \
--cc=devel@lists.orangefs.org \
--cc=dsterba@suse.com \
--cc=dushistov@mail.ru \
--cc=dwmw2@infradead.org \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=hubcap@omnibond.com \
--cc=idryomov@gmail.com \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jaharkes@cs.cmu.edu \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlbec@evilplan.org \
--cc=keescook@chromium.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-xfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=luisbg@kernel.org \
--cc=martin@omnibond.com \
--cc=me@bobcopeland.com \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=nico@fluxnic.net \
--cc=phillip@squashfs.org.uk \
--cc=reiserfs-devel@vger.kernel.org \
--cc=richard@nod.at \
--cc=sage@redhat.com \
--cc=salah.triki@gmail.com \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=trond.myklebust@hammerspace.com \
--cc=tytso@mit.edu \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
--cc=yuchao0@huawei.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).