From: David Howells <dhowells@redhat.com>
To: dsterba@suse.cz
Cc: dhowells@redhat.com
Cc: willy@infradead.org, Chris Mason <clm@fb.com>,
linux-block@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
Ilya Dryomov <idryomov@gmail.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH v3 0/9] mm: Use DIO for swap and fix NFS swapfiles
Date: Wed, 29 Sep 2021 16:45:02 +0100 [thread overview]
Message-ID: <4005662.1632930302@warthog.procyon.org.uk> (raw)
In-Reply-To: <20210927200708.GI9286@twin.jikos.cz>
David Sterba <dsterba@suse.cz> wrote:
> > There are additional patches to get rid of noop_direct_IO and replace it
> > with a feature bitmask, to make btrfs, ext4, xfs and raw blockdevs use the
> > new ->swap_rw method and thence remove the direct BIO submission paths from
> > swap.
> >
> > I kept the IOCB_SWAP flag, using it to enable REQ_SWAP. I'm not sure if
> > that's necessary, but it seems accounting related.
>
> There was probably some step missing. The file must not have holes, so
> either do 'dd' to the right size or use fallocate (which is recommended
> in manual page btrfs(5) SWAPFILE SUPPORT). There are some fstests
> exercising swapfile (grep -l _format_swapfile tests/generic/*) so you
> could try that without having to set up the swapfile manually.
Yeah. As advised elsewhere, I removed the file and recreated it, doing the
chattr before extending the file. At that point swapon worked. It didn't
work though, and various userspace programs started dying. I'm guessing my
btrfs_swap_rw() is wrong somehow.
David
prev parent reply other threads:[~2021-09-29 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 17:17 [RFC][PATCH v3 0/9] mm: Use DIO for swap and fix NFS swapfiles David Howells
2021-09-24 17:18 ` [PATCH v3 2/9] mm: Add 'supports' field to the address_space_operations to list features David Howells
2021-09-24 20:10 ` Matthew Wilcox
2021-09-25 23:42 ` [RFC][PATCH v3 0/9] mm: Use DIO for swap and fix NFS swapfiles Dave Chinner
2021-09-26 3:10 ` Matthew Wilcox
2021-09-26 22:36 ` Dave Chinner
2021-09-27 20:07 ` David Sterba
2021-09-28 3:11 ` NeilBrown
2021-09-30 15:54 ` Steve French
2021-09-29 15:45 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4005662.1632930302@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dsterba@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).