From: Tom Talpey <tom@talpey.com>
To: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [SMB3][Multichannel] avoid confusing warning message on mount to Azure
Date: Wed, 9 Dec 2020 08:40:37 -0500 [thread overview]
Message-ID: <472d2c7d-3e78-a570-0c0f-aab6ebfeb90b@talpey.com> (raw)
In-Reply-To: <CAH2r5mtx6zWZ2T_Erb=6JQ3mHJxh=bHydww-F52ts3zsvgd8Jw@mail.gmail.com>
Why not just delete the splat? It isn't causing a failure, and
appears to be legal protocol behavior.
On 12/8/2020 10:21 PM, Steve French wrote:
> Mounts to Azure cause an unneeded warning message in dmesg
> "CIFS: VFS: parse_server_interfaces: incomplete interface info"
>
> Azure rounds up the size (by 8 additional bytes, to a
> 16 byte boundary) of the structure returned on the query
> of the server interfaces at mount time. This is permissible
> even though different than other servers so do not log a warning
> if query network interfaces response is only rounded up by 8
> bytes or fewer.
>
> CC: Stable <stable@vger.kernel.org>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
> fs/cifs/smb2ops.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 3d914d7d0d11..22f1d8dc12b0 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -477,7 +477,8 @@ parse_server_interfaces(struct
> network_interface_info_ioctl_rsp *buf,
> goto out;
> }
>
> - if (bytes_left || p->Next)
> + /* Azure rounds the buffer size up 8, to a 16 byte boundary */
> + if ((bytes_left > 8) || p->Next)
> cifs_dbg(VFS, "%s: incomplete interface info\n", __func__);
>
>
prev parent reply other threads:[~2020-12-09 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 3:21 [SMB3][Multichannel] avoid confusing warning message on mount to Azure Steve French
2020-12-09 3:29 ` ronnie sahlberg
2020-12-09 13:40 ` Tom Talpey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472d2c7d-3e78-a570-0c0f-aab6ebfeb90b@talpey.com \
--to=tom@talpey.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).