From: "libaokun (A)" <libaokun1@huawei.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Namjae Jeon <namjae.jeon@samsung.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steve French <sfrench@samba.org>,
"Hyunchul Lee" <hyc.lee@gmail.com>, <linux-cifs@vger.kernel.org>,
<linux-cifsd-devel@lists.sourceforge.net>,
<kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] cifsd: fix WARNING: convert list_for_each to entry variant in smb2pdu.c
Date: Fri, 18 Jun 2021 15:47:12 +0800 [thread overview]
Message-ID: <4adc3507-6b34-1f23-36cb-21336d5e8e91@huawei.com> (raw)
In-Reply-To: <20210618051400.GG1861@kadam>
在 2021/6/18 13:14, Dan Carpenter 写道:
> On Fri, Jun 18, 2021 at 09:44:37AM +0800, libaokun (A) wrote:
>> I don't know what the difference is between
>>
>> list_for_each_entry() and list_for_each() for 'struct channel *chann',
>>
>> but I don't think there's any difference here.
> Correct. There is no difference, but Coccinelle is smart enough to
> parse list_for_each_entry() and it's not smart enough to parse
> list_for_each().
>
>> Would you give me more detial about this, please?
> There is a Coccinelle script scripts/coccinelle/iterators/itnull.cocci
> which will complain about the NULL check in the new code so this patch
> will introduce a new warning. We may as well remove the unnecessary
> NULL check and avoid the warning.
>
> regards,
> dan carpenter
>
> .
I get your point, but this bug has nothing to do with my patch.
It's from e2f34481b24d(cifsd: add server-side procedures for SMB3).
Thank you.
--
With Best Regards,
Baokun Li
next prev parent reply other threads:[~2021-06-18 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 6:46 [PATCH -next] cifsd: fix WARNING: convert list_for_each to entry variant in smb2pdu.c Baokun Li
2021-06-17 9:26 ` Dan Carpenter
2021-06-18 1:44 ` libaokun (A)
2021-06-18 5:14 ` Dan Carpenter
2021-06-18 7:47 ` libaokun (A) [this message]
2021-06-18 8:19 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4adc3507-6b34-1f23-36cb-21336d5e8e91@huawei.com \
--to=libaokun1@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=hulkci@huawei.com \
--cc=hyc.lee@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-cifsd-devel@lists.sourceforge.net \
--cc=namjae.jeon@samsung.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).