From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A965BC4321E for ; Mon, 21 Nov 2022 14:37:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231540AbiKUOh0 (ORCPT ); Mon, 21 Nov 2022 09:37:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbiKUOgz (ORCPT ); Mon, 21 Nov 2022 09:36:55 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D7F5AB0C0 for ; Mon, 21 Nov 2022 06:35:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669041303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=181ZHweS4wHRSdLySvK3fpfT7WMJLPwn/rNHBgW8rAk=; b=FRBRYMuD6hZhCYCxVRwZRgJ8ck3pHEBHmbmFxJ0T19hA5C3adeOKBQLUVS8O/+8axWjap6 vGGrN6UfeJSag0OV+Csxdo/4B1dXSsFFDK4GH4h++n0e7SUJ2bpSok3ZujHeHyKziqtkCA vLnTMwEOuAgklcJM8Xlm+welG63feW8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-220-cKpJPG72PVO5ijDDtOCqbA-1; Mon, 21 Nov 2022 09:34:58 -0500 X-MC-Unique: cKpJPG72PVO5ijDDtOCqbA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1521B811E7A; Mon, 21 Nov 2022 14:34:56 +0000 (UTC) Received: from [172.16.176.1] (unknown [10.22.50.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 61D8E492B06; Mon, 21 Nov 2022 14:34:47 +0000 (UTC) From: Benjamin Coddington To: David Howells Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Reisner , Lars Ellenberg , =?utf-8?q?Christoph_B=C3=B6hmwalder?= , Jens Axboe , Josef Bacik , Keith Busch , Christoph Hellwig , Sagi Grimberg , Lee Duncan , Chris Leech , Mike Christie , "James E.J. Bottomley" , "Martin K. Petersen" , Valentina Manea , Shuah Khan , Greg Kroah-Hartman , Marc Dionne , Steve French , Christine Caulfield , David Teigland , Mark Fasheh , Joel Becker , Joseph Qi , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ilya Dryomov , Xiubo Li , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, nbd@other.debian.org, linux-nvme@lists.infradead.org, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag Date: Mon, 21 Nov 2022 09:34:43 -0500 Message-ID: <51B5418D-34FB-4E87-B87A-6C3FCDF8B21C@redhat.com> In-Reply-To: <382872.1669039019@warthog.procyon.org.uk> References: <382872.1669039019@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On 21 Nov 2022, at 8:56, David Howells wrote: > Benjamin Coddington wrote: > >> Since moving to memalloc_nofs_save/restore, SUNRPC has stopped setting the >> GFP_NOIO flag on sk_allocation which the networking system uses to decide >> when it is safe to use current->task_frag. > > Um, what's task_frag? Its a per-task page_frag used to coalesce small writes for networking -- see: 5640f7685831 net: use a per task frag allocator Ben