From: Paulo Alcantara <pc@manguebit.com>
To: Steve French <smfrench@gmail.com>
Cc: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>,
linux-cifs@vger.kernel.org, sfrench@samba.org,
lsahlber@redhat.com, sprasad@microsoft.com, tom@talpey.com
Subject: Re: [PATCH v2 2/2] cifs: Move the in_send statistic to __smb_send_rqst()
Date: Fri, 01 Sep 2023 13:49:27 -0300 [thread overview]
Message-ID: <5DEA9FD6-10FA-4910-9E0E-D97B5365DA3A@manguebit.com> (raw)
In-Reply-To: <CAH2r5msd3JzDGR1pCCQFb4rP9dUEOSw5YxQj3o9OfNFDVk5mpA@mail.gmail.com>
Whopps - I replied to wrong email, sorry.
I meant patch 1/2 [1].
[1] https://lore.kernel.org/linux-cifs/20221116031136.3967579-2-zhangxiaoxu5@huawei.com/
On 1 September 2023 13:25:10 GMT-03:00, Steve French <smfrench@gmail.com> wrote:
>That patch was already been merged last year
>
>commit d0dc41119905f740e8d5594adce277f7c0de8c92
>Author: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>Date: Wed Nov 16 11:11:36 2022 +0800
>
> cifs: Move the in_send statistic to __smb_send_rqst()
>
> When send SMB_COM_NT_CANCEL and RFC1002_SESSION_REQUEST, the
> in_send statistic was lost.
>
> Let's move the in_send statistic to the send function to avoid
> this scenario.
>
> Fixes: 7ee1af765dfa ("[CIFS]")
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> Signed-off-by: Steve French <stfrench@microsoft.com>
>
>On Fri, Sep 1, 2023 at 10:25 AM Paulo Alcantara <pc@manguebit.com> wrote:
>>
>> Hi Steve,
>>
>> Zhang Xiaoxu <zhangxiaoxu5@huawei.com> writes:
>>
>> > When send SMB_COM_NT_CANCEL and RFC1002_SESSION_REQUEST, the
>> > in_send statistic was lost.
>> >
>> > Let's move the in_send statistic to the send function to avoid
>> > this scenario.
>> >
>> > Fixes: 7ee1af765dfa ("[CIFS]")
>> > Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>> > ---
>> > fs/cifs/transport.c | 21 +++++++++------------
>> > 1 file changed, 9 insertions(+), 12 deletions(-)
>>
>> Could you please pick this up?
>>
>> Thanks.
>
>
>
next prev parent reply other threads:[~2023-09-01 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 3:11 [PATCH v2 0/2] Fix some bug in cifs Zhang Xiaoxu
2022-11-16 3:11 ` [PATCH v2 1/2] cifs: Fix UAF in cifs_demultiplex_thread() Zhang Xiaoxu
2022-11-16 3:11 ` [PATCH v2 2/2] cifs: Move the in_send statistic to __smb_send_rqst() Zhang Xiaoxu
2023-09-01 15:25 ` Paulo Alcantara
2023-09-01 16:25 ` Steve French
2023-09-01 16:49 ` Paulo Alcantara [this message]
2023-03-03 2:02 ` [PATCH v2 0/2] Fix some bug in cifs ChenXiaoSong
2023-03-03 21:55 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DEA9FD6-10FA-4910-9E0E-D97B5365DA3A@manguebit.com \
--to=pc@manguebit.com \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).