From: Tom Talpey <tom@talpey.com>
To: Namjae Jeon <linkinjeon@kernel.org>, linux-cifs@vger.kernel.org
Cc: smfrench@gmail.com, senozhatsky@chromium.org, atteh.mailbox@gmail.com
Subject: Re: [PATCH] ksmbd: hide socket error message when ipv6 config is disable
Date: Wed, 28 Sep 2022 11:25:48 -0400 [thread overview]
Message-ID: <60322098-648f-2610-bcf2-1cec581d4f86@talpey.com> (raw)
In-Reply-To: <20220927215151.6931-1-linkinjeon@kernel.org>
On 9/27/2022 5:51 PM, Namjae Jeon wrote:
> When ipv6 config is disable(CONFIG_IPV6 is not set), ksmbd fallback to
> create ipv4 socket. User reported that this error message lead to
> misunderstood some issue. Users have requested not to print this error
> message that occurs even though there is no problem.
>
> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
> ---
> fs/ksmbd/transport_tcp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ksmbd/transport_tcp.c b/fs/ksmbd/transport_tcp.c
> index 143bba4e4db8..9b35afcdcf0d 100644
> --- a/fs/ksmbd/transport_tcp.c
> +++ b/fs/ksmbd/transport_tcp.c
> @@ -399,7 +399,8 @@ static int create_socket(struct interface *iface)
>
> ret = sock_create(PF_INET6, SOCK_STREAM, IPPROTO_TCP, &ksmbd_socket);
> if (ret) {
> - pr_err("Can't create socket for ipv6, try ipv4: %d\n", ret);
> + if (ret != -EAFNOSUPPORT)
> + pr_err("Can't create socket for ipv6, try ipv4: %d\n", ret);
Why not just eliminate the splat? The only real error seems to be
that IPv6 is not configured, which is undoubtedly intentional, and
in any case there's nothing to do about it. Suggesting to "try ipv4"
is kind of pointless, isn't it?
> ret = sock_create(PF_INET, SOCK_STREAM, IPPROTO_TCP,
> &ksmbd_socket);
> if (ret) {
The same question applies to IPv4 - socket creation is not something
that fails in general, and spraying the kernel log isn't particularly
useful toward fixing it. In any case, the error propagates back up
to the caller, right? Why wouldn't ksmbd.mountd do the reporting?
Tom.
next prev parent reply other threads:[~2022-09-28 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 21:51 [PATCH] ksmbd: hide socket error message when ipv6 config is disable Namjae Jeon
2022-09-28 15:25 ` Tom Talpey [this message]
2022-09-28 23:44 ` Namjae Jeon
2022-09-29 15:37 ` Tom Talpey
2022-09-29 2:08 ` Sergey Senozhatsky
2022-09-29 2:48 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60322098-648f-2610-bcf2-1cec581d4f86@talpey.com \
--to=tom@talpey.com \
--cc=atteh.mailbox@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).