From: Ronnie Sahlberg <lsahlber@redhat.com>
To: Steve French <smfrench@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH][SMB3] Fix modefromsid newly created files to allow more permission on server
Date: Thu, 16 Jan 2020 22:04:17 -0500 (EST) [thread overview]
Message-ID: <644970174.6192265.1579230257768.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAH2r5mvLCqTXVFG93AgSJHTu8daMLwV_hpbjgJs-7orUwr7ffg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1057 bytes --]
Reviewed-By: Ronnie Sahlberg <lsahlber@redhat.com>
But drop the extra parenthesises here :
+ (2 * sizeof(struct cifs_ace));
----- Original Message -----
From: "Steve French" <smfrench@gmail.com>
To: "CIFS" <linux-cifs@vger.kernel.org>
Sent: Friday, 17 January, 2020 12:28:03 PM
Subject: [PATCH][SMB3] Fix modefromsid newly created files to allow more permission on server
When mounting with "modefromsid" mount parm most servers will require
that some default permissions are given to users in the ACL on newly
created files, and for files created with the new 'sd context' -
when passing in
an sd context on create, permissions are not inherited from the parent
directory, so in addition to the ACE with the special SID (which contains
the mode), we also must pass in an ACE allowing users to access the file
(GENERIC_ALL for authenticated users seemed like a reasonable default,
although later we could allow a mount option or config switch to make
it GENERIC_ALL for EVERYONE special sid).
--
Thanks,
Steve
next prev parent reply other threads:[~2020-01-17 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 2:28 [PATCH][SMB3] Fix modefromsid newly created files to allow more permission on server Steve French
2020-01-17 3:04 ` Ronnie Sahlberg [this message]
2020-01-17 4:48 ` Steve French
2020-01-22 0:04 ` Pavel Shilovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644970174.6192265.1579230257768.JavaMail.zimbra@redhat.com \
--to=lsahlber@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).