From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B34C34026 for ; Tue, 18 Feb 2020 11:47:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 514D9207FD for ; Tue, 18 Feb 2020 11:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbgBRLr1 convert rfc822-to-8bit (ORCPT ); Tue, 18 Feb 2020 06:47:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:60542 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726043AbgBRLr0 (ORCPT ); Tue, 18 Feb 2020 06:47:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6BDBFAD08; Tue, 18 Feb 2020 11:47:25 +0000 (UTC) From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: Ronnie Sahlberg , linux-cifs Cc: Ronnie Sahlberg Subject: Re: [PATCH] cifs: don't leak -EAGAIN for stat() during reconnect In-Reply-To: <20200218044829.15629-1-lsahlber@redhat.com> References: <20200218044829.15629-1-lsahlber@redhat.com> Date: Tue, 18 Feb 2020 12:47:24 +0100 Message-ID: <878sl0azhv.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Hi Ronnie, Ronnie Sahlberg writes: > Fix this by re-trying the operation from within cifs_revalidate_dentry_attr() > if cifs_get_inode_info*() returns -EAGAIN. Would it make sense to use is_retryable_error() instead of checking for just EAGAIN? It also checks for interruption errors. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)