From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD29ECA9EA0 for ; Fri, 25 Oct 2019 16:24:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 852D42070B for ; Fri, 25 Oct 2019 16:24:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505607AbfJYQYo convert rfc822-to-8bit (ORCPT ); Fri, 25 Oct 2019 12:24:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:34440 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2505599AbfJYQYn (ORCPT ); Fri, 25 Oct 2019 12:24:43 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6F669B8C4; Fri, 25 Oct 2019 16:24:42 +0000 (UTC) From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: Ronnie Sahlberg , linux-cifs Subject: Re: Updated patch for the the lock_sem deadlock In-Reply-To: <20191024235120.8059-1-lsahlber@redhat.com> References: <20191024235120.8059-1-lsahlber@redhat.com> Date: Fri, 25 Oct 2019 18:24:41 +0200 Message-ID: <878sp8yera.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Ronnie Sahlberg writes: > This is a small update to Dave's patch to address Pavels recommendation > that we use a helper function for the trylock/sleep loop. Disclamer: I have not read all the emails regarding this patch but it is not obvious to me how replacing lock() by while (trylock()) sleep() is fixing things, but I'm sure I'm missing something :( Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)