linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [CIFS][PATCH] Clarify SMB1 code for delete
@ 2021-07-07  2:46 Steve French
  2021-07-07 16:27 ` Paulo Alcantara
  0 siblings, 1 reply; 2+ messages in thread
From: Steve French @ 2021-07-07  2:46 UTC (permalink / raw)
  To: CIFS

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

Coverity also complains about the way we calculate the offset
(starting from the address of a 4 byte array within the
header structure rather than from the beginning of the struct
plus 4 bytes) for SMB1 SetFileDisposition (which is used to
unlink a file by setting the delete on close flag).  This
changeset doesn't change the address but makes it slightly
clearer.

Addresses-Coverity: 711524 ("Out of bounds write")
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/cifssmb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index a513a89aad1a..0863238ddd20 100644
--- a/fs/cifs/cifssmb.c
+++ b/fs/cifs/cifssmb.c
@@ -5763,7 +5763,8 @@ CIFSSMBSetFileDisposition(const unsigned int
xid, struct cifs_tcon *tcon,
  param_offset = offsetof(struct smb_com_transaction2_sfi_req, Fid) - 4;
  offset = param_offset + params;

- data_offset = (char *) (&pSMB->hdr.Protocol) + offset;
+ /* SMB offsets are from the beginning of SMB which is 4 bytes in,
after RFC1001 field */
+ data_offset = (char *)(pSMB) + offset + 4;

  count = 1;
  pSMB->MaxParameterCount = cpu_to_le16(2);

-- 
Thanks,

Steve

[-- Attachment #2: 0001-CIFS-Clarify-SMB1-code-for-delete.patch --]
[-- Type: text/x-patch, Size: 1364 bytes --]

From 532db4bf85f9f2fae13154ffc45cfb71279a5dab Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Tue, 6 Jul 2021 21:42:08 -0500
Subject: [PATCH] CIFS: Clarify SMB1 code for delete

Coverity also complains about the way we calculate the offset
(starting from the address of a 4 byte array within the
header structure rather than from the beginning of the struct
plus 4 bytes) for SMB1 SetFileDisposition (which is used to
unlink a file by setting the delete on close flag).  This
changeset doesn't change the address but makes it slightly
clearer.

Addresses-Coverity: 711524 ("Out of bounds write")
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/cifssmb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index a513a89aad1a..0863238ddd20 100644
--- a/fs/cifs/cifssmb.c
+++ b/fs/cifs/cifssmb.c
@@ -5763,7 +5763,8 @@ CIFSSMBSetFileDisposition(const unsigned int xid, struct cifs_tcon *tcon,
 	param_offset = offsetof(struct smb_com_transaction2_sfi_req, Fid) - 4;
 	offset = param_offset + params;
 
-	data_offset = (char *) (&pSMB->hdr.Protocol) + offset;
+	/* SMB offsets are from the beginning of SMB which is 4 bytes in, after RFC1001 field */
+	data_offset = (char *)(pSMB) + offset + 4;
 
 	count = 1;
 	pSMB->MaxParameterCount = cpu_to_le16(2);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [CIFS][PATCH] Clarify SMB1 code for delete
  2021-07-07  2:46 [CIFS][PATCH] Clarify SMB1 code for delete Steve French
@ 2021-07-07 16:27 ` Paulo Alcantara
  0 siblings, 0 replies; 2+ messages in thread
From: Paulo Alcantara @ 2021-07-07 16:27 UTC (permalink / raw)
  To: Steve French, CIFS

Steve French <smfrench@gmail.com> writes:

> Coverity also complains about the way we calculate the offset
> (starting from the address of a 4 byte array within the
> header structure rather than from the beginning of the struct
> plus 4 bytes) for SMB1 SetFileDisposition (which is used to
> unlink a file by setting the delete on close flag).  This
> changeset doesn't change the address but makes it slightly
> clearer.
>
> Addresses-Coverity: 711524 ("Out of bounds write")
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
>  fs/cifs/cifssmb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-07 16:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07  2:46 [CIFS][PATCH] Clarify SMB1 code for delete Steve French
2021-07-07 16:27 ` Paulo Alcantara

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox