From: Paulo Alcantara <pc@cjr.nz>
To: Ding Hui <dinghui@sangfor.com.cn>, sfrench@samba.org
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, Ding Hui <dinghui@sangfor.com.cn>
Subject: Re: [PATCH] cifs: fix wrong release in sess_alloc_buffer() failed path
Date: Tue, 17 Aug 2021 21:30:17 -0300 [thread overview]
Message-ID: <87fsv7h9wm.fsf@cjr.nz> (raw)
In-Reply-To: <20210817145510.639-1-dinghui@sangfor.com.cn>
Ding Hui <dinghui@sangfor.com.cn> writes:
> smb_buf is allocated by small_smb_init_no_tc(), and buf type is
> CIFS_SMALL_BUFFER, so we should use cifs_small_buf_release() to
> release it in failed path.
>
> Signed-off-by: Ding Hui <dinghui@sangfor.com.cn>
> ---
> fs/cifs/sess.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
next prev parent reply other threads:[~2021-08-18 0:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 14:55 [PATCH] cifs: fix wrong release in sess_alloc_buffer() failed path Ding Hui
2021-08-18 0:30 ` Paulo Alcantara [this message]
2021-08-18 2:46 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsv7h9wm.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=dinghui@sangfor.com.cn \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).