From: Paulo Alcantara <pc@cjr.nz>
To: Enzo Matsumiya <ematsumiya@suse.de>, linux-cifs@vger.kernel.org
Cc: smfrench@gmail.com, ronniesahlberg@gmail.com,
nspmangalore@gmail.com, kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v3] cifs: replace kfree() with kfree_sensitive() for sensitive data
Date: Tue, 04 Oct 2022 16:04:06 -0300 [thread overview]
Message-ID: <87ilkz4di1.fsf@cjr.nz> (raw)
In-Reply-To: <20220920181035.8845-1-ematsumiya@suse.de>
Enzo Matsumiya <ematsumiya@suse.de> writes:
> Replace kfree with kfree_sensitive, or prepend memzero_explicit() in
> other cases, when freeing sensitive material that could still be left
> in memory.
>
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Link: https://lore.kernel.org/r/202209201529.ec633796-oliver.sang@intel.com
> ---
> v3: fix use-after-free reported by kernel test robot (this UAF existed before this patch,
> actually), adjust commit message slightly
> v2: remove unnecessary NULL checks before kfree_sensitive()
>
> fs/cifs/cifsencrypt.c | 12 ++++++------
> fs/cifs/connect.c | 6 +++---
> fs/cifs/fs_context.c | 12 ++++++++++--
> fs/cifs/misc.c | 2 +-
> fs/cifs/sess.c | 24 +++++++++++++++---------
> fs/cifs/smb2ops.c | 6 +++---
> fs/cifs/smb2pdu.c | 19 ++++++++++++++-----
> 7 files changed, 52 insertions(+), 29 deletions(-)
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
next prev parent reply other threads:[~2022-10-04 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 18:10 [PATCH v3] cifs: replace kfree() with kfree_sensitive() for sensitive data Enzo Matsumiya
2022-10-04 19:04 ` Paulo Alcantara [this message]
2022-10-05 7:09 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilkz4di1.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=oliver.sang@intel.com \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).