linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Aurélien Aptel" <aaptel@suse.com>
To: Paulo Alcantara <pc@cjr.nz>,
	linux-cifs@vger.kernel.org, smfrench@gmail.com
Cc: Paulo Alcantara <pc@cjr.nz>
Subject: Re: [PATCH] cifs: include regular shares to the list of unshared tcp servers
Date: Mon, 05 Jul 2021 12:51:48 +0200	[thread overview]
Message-ID: <87im1powxn.fsf@suse.com> (raw)
In-Reply-To: <20210702171710.406-1-pc@cjr.nz>

Paulo Alcantara <pc@cjr.nz> writes:
> We need to make regular shares to also not share tcp servers because
> we might have both regular and dfs mounts connecting to same server.

So with this change we never reuse tcp connections, and nosharesock
because the default mount option for all cases. We might as well remove
all the code for searching/matching/reusing tcp connection, smb session,
tree connects.

That doesn't seem good. If dfs connections are made with the nosharesock
flag they should not be reused already no?

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)


  reply	other threads:[~2021-07-05 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 17:17 [PATCH] cifs: include regular shares to the list of unshared tcp servers Paulo Alcantara
2021-07-05 10:51 ` Aurélien Aptel [this message]
2021-07-05 14:37   ` Paulo Alcantara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im1powxn.fsf@suse.com \
    --to=aaptel@suse.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=pc@cjr.nz \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).