From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B312C3A5A1 for ; Wed, 28 Aug 2019 10:21:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB71E208CB for ; Wed, 28 Aug 2019 10:21:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbfH1KVB convert rfc822-to-8bit (ORCPT ); Wed, 28 Aug 2019 06:21:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:35688 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726259AbfH1KVB (ORCPT ); Wed, 28 Aug 2019 06:21:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 90AABAF47; Wed, 28 Aug 2019 10:21:00 +0000 (UTC) From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: Steve French , CIFS Subject: Re: [RFC][SMB3][PATCH] Allow share to be mounted with "cache=ro" if immutable share In-Reply-To: References: Date: Wed, 28 Aug 2019 12:20:59 +0200 Message-ID: <87k1axlhf8.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org "Steve French" writes: > Increases performance a lot in cases where we know that the share is > not changing This is just adding the parsing of the option but it sounds like a good idea. > +#define CIFS_MOUNT_RO_CACHE 0x20000000 /* assumes share will not change */ This flag probably needs to be added to CIFS_MOUNT_MASK: if one cifs sb is using that flag, it should only be reused for new mounts that also require that flag. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)