From: "Aurélien Aptel" <aaptel@suse.com>
To: Shyam Prasad N <nspmangalore@gmail.com>
Cc: Pavel Shilovsky <piastryyy@gmail.com>,
Steve French <smfrench@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>,
sribhat.msa@outlook.com
Subject: Re: [PATCH][SMB3] mount.cifs: use SUDO_UID env variable for cruid
Date: Thu, 17 Sep 2020 12:13:11 +0200 [thread overview]
Message-ID: <87o8m4lnig.fsf@suse.com> (raw)
In-Reply-To: <CANT5p=rarYr0bErP77GF5QOu8=xx7Ovfy2dWdUNxnOTGkLXMKQ@mail.gmail.com>
Shyam Prasad N <nspmangalore@gmail.com> writes:
> Attaching the patch with the review comments incorporated.
> Tested a few positive and negative test cases. Works as expected.
Great, I only have one small comment:
> + reinit_parsed_info =
> + (struct parsed_mount_info *) malloc(sizeof(*reinit_parsed_info));
Don't cast malloc return value (void* gets implicitely promoted to
any pointer type).
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2020-09-17 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 10:00 [PATCH][SMB3] mount.cifs: use SUDO_UID env variable for cruid Shyam Prasad N
2020-09-16 10:56 ` Aurélien Aptel
2020-09-16 16:17 ` Shyam Prasad N
2020-09-17 8:57 ` Aurélien Aptel
2020-09-17 9:11 ` Shyam Prasad N
2020-09-17 10:13 ` Aurélien Aptel [this message]
2020-09-21 3:50 ` Shyam Prasad N
2020-09-21 8:19 ` Aurélien Aptel
2020-11-09 23:43 ` Pavel Shilovsky
2020-11-27 10:24 ` Shyam Prasad N
2020-12-09 19:32 ` Pavel Shilovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8m4lnig.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=piastryyy@gmail.com \
--cc=smfrench@gmail.com \
--cc=sribhat.msa@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).