From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9590FC32751 for ; Wed, 31 Jul 2019 10:09:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73F3820657 for ; Wed, 31 Jul 2019 10:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727267AbfGaKJf convert rfc822-to-8bit (ORCPT ); Wed, 31 Jul 2019 06:09:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:57628 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725866AbfGaKJe (ORCPT ); Wed, 31 Jul 2019 06:09:34 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9759CB08C; Wed, 31 Jul 2019 10:09:33 +0000 (UTC) From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: Colin King , samba-technical@lists.samba.org, Steve French , linux-cifs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cifs: remove redundant assignment to variable rc In-Reply-To: <20190731090526.27245-1-colin.king@canonical.com> References: <20190731090526.27245-1-colin.king@canonical.com> Date: Wed, 31 Jul 2019 12:09:31 +0200 Message-ID: <87r266seg4.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Colin King writes: > Variable rc is being initialized with a value that is never read > and rc is being re-assigned a little later on. The assignment is > redundant and hence can be removed. I think I would actually rather have rc set to an error by default than uninitialized. Just my personal opinion. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)