linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@cjr.nz>
To: "Aurélien Aptel" <aaptel@suse.com>, linux-cifs@vger.kernel.org
Cc: smfrench@gmail.com, metze@samba.org, Aurelien Aptel <aaptel@suse.com>
Subject: Re: [PATCH v1 0/2] Change CIFS_FULL_KEY_DUMP ioctl to return variable size keys
Date: Fri, 21 May 2021 12:42:28 -0300	[thread overview]
Message-ID: <87tumwks9n.fsf@cjr.nz> (raw)
In-Reply-To: <20210521151928.17730-1-aaptel@suse.com>

Aurélien Aptel <aaptel@suse.com> writes:

> From: Aurelien Aptel <aaptel@suse.com>
>
> This patchset changes the CIFS_FULL_KEY_DUMP ioctl to return variable
> size keys to userspace while keeping the same ioctl number.
>
> This version of the ioctl should be future proof if we ever add more
> cipher types or bigger keys.
>
> This also fixes the build error for ARM related to get_user() being
> undefined.
>
> I have tested this for AES-128 and AES-256.
>
> I have a separate patch for the smbinfo utility to make use of this
> new ioctl that I will send in a separate thread.
>
> Aurelien Aptel (2):
>   cifs: set server->cipher_type to AES-128-CCM for SMB3.0
>   cifs: change format of CIFS_FULL_KEY_DUMP ioctl
>
>  fs/cifs/cifs_ioctl.h |  25 ++++++--
>  fs/cifs/cifspdu.h    |   3 +-
>  fs/cifs/ioctl.c      | 143 +++++++++++++++++++++++++++++++------------
>  fs/cifs/smb2pdu.c    |   7 +++
>  4 files changed, 133 insertions(+), 45 deletions(-)

Looks good.

Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>

      parent reply	other threads:[~2021-05-21 15:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 15:19 [PATCH v1 0/2] Change CIFS_FULL_KEY_DUMP ioctl to return variable size keys Aurélien Aptel
2021-05-21 15:19 ` [PATCH v1 1/2] cifs: set server->cipher_type to AES-128-CCM for SMB3.0 Aurélien Aptel
2021-05-21 18:39   ` Steve French
2021-05-28  8:37     ` Aurélien Aptel
2021-05-27 20:23   ` Steve French
2021-05-21 15:19 ` [PATCH v1 2/2] cifs: change format of CIFS_FULL_KEY_DUMP ioctl Aurélien Aptel
2021-05-21 19:47   ` Steve French
2021-05-21 15:42 ` Paulo Alcantara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tumwks9n.fsf@cjr.nz \
    --to=pc@cjr.nz \
    --cc=aaptel@suse.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).