From: "Aurélien Aptel" <aaptel@suse.com>
To: Thiago Rafael Becker <trbecker@gmail.com>, linux-cifs@vger.kernel.org
Cc: sfrench@samba.org, samba-technical@lists.samba.org,
tbecker@redhat.com, jshivers@redhat.com
Subject: Re: [RFC PATCH] cifs: retry lookup and readdir when EAGAIN is returned.
Date: Mon, 07 Jun 2021 11:32:46 +0200 [thread overview]
Message-ID: <87v96qrpdt.fsf@suse.com> (raw)
In-Reply-To: <YLplrk3FQiUtVoWi@nyarly.rlyeh.local>
Thiago Rafael Becker <trbecker@gmail.com> writes:
> According to the investigation performed by Jacob Shivers at Red Hat,
> cifs_lookup and cifs_readdir leak EAGAIN when the user session is
> deleted on the server. Fix this issue by implementing a retry with
> limits, as is implemented in cifs_revalidate_dentry_attr.
If the user session is deleted trying again will always fail. Are you
sure this is the reason you get this issue?
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2021-06-07 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 17:41 [RFC PATCH] cifs: retry lookup and readdir when EAGAIN is returned Thiago Rafael Becker
2021-06-07 9:32 ` Aurélien Aptel [this message]
2021-06-07 13:57 ` Thiago Rafael Becker
2021-06-07 15:27 ` Thiago Rafael Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v96qrpdt.fsf@suse.com \
--to=aaptel@suse.com \
--cc=jshivers@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=tbecker@redhat.com \
--cc=trbecker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).